Bug 541376 - [GTK4] Replace signals which have been removed
Summary: [GTK4] Replace signals which have been removed
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.10   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: triaged
Depends on: 543987
Blocks: 540385
  Show dependency tree
 
Reported: 2018-11-20 11:05 EST by Eric Williams CLA
Modified: 2021-03-18 15:07 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Williams CLA 2018-11-20 11:05:38 EST
Signals like "map-event" are removed from GTK4 and have some implications for SWT functionality.
Comment 1 Eric Williams CLA 2018-11-22 15:48:42 EST
Here is a list I have compiled so far:

These are replaced by event controller work (bug 539524):

key-press-event
leave-notify-event
motion-notify-event
enter-notify-event
scroll-event

Others that need to be removed/replaced:

button-press-event
button-release-event
configure-event
delete-event (see bug 541378)
event-after
draw
focus-out-event
focus-in-event
grab-focus
map-event
show-help
size-allocate
style-set
unmap-event
window-state-event
Comment 2 Eric Williams CLA 2019-01-08 10:31:08 EST
The work for "style-set" is tracked by bug 541205.
Comment 3 Eclipse Genie CLA 2019-01-23 12:20:50 EST
New Gerrit change created: https://git.eclipse.org/r/135643
Comment 4 Xi Yan CLA 2019-01-30 17:16:57 EST
Signals replaced by GtkEventController (bug 539524)
- key-press-event
- leave-notify-event
- motion-notify-event
- enter-notify-event
- scroll-event
- focus-in-event
- focus-out-event 

Signals that can replaced by generic event signal
- button-press-event
- button-release-event
- configure-event 
- map-event
- unmap-event
- event-after

Other signals
- draw (bug 540674)
- expose-event (replaced by draw signal in GTK3)
- show-help
- window-state-event (bug 543987)
Comment 6 Eric Williams CLA 2019-02-07 14:13:04 EST
When running ControlExample on GTK4 I also see:

gsignal.c:2423: signal 'change-value' is invalid for instance '0x7f4be2d11e50' of type 'GtkScrollbar'

looks like "change-value" isn't a signal for scrollbars anymore in GTK4.
Comment 7 Eclipse Genie CLA 2019-03-01 16:53:41 EST
New Gerrit change created: https://git.eclipse.org/r/137904
Comment 8 Eric Williams CLA 2019-03-04 15:47:21 EST
(In reply to Eric Williams from comment #6)
> When running ControlExample on GTK4 I also see:
> 
> gsignal.c:2423: signal 'change-value' is invalid for instance
> '0x7f4be2d11e50' of type 'GtkScrollbar'
> 
> looks like "change-value" isn't a signal for scrollbars anymore in GTK4.

So it looks like they moved GtkScrollbar out of GtkRange into GtkWidget in GTK4.  The only signals we can connect to a GtkScrollbar are actually connected to its GtkAdjustment.
Comment 10 Xi Yan CLA 2019-03-22 10:01:49 EDT
More signals to be replaced: 

(SWT:4007): GLib-GObject-WARNING **: 10:00:07.392: gsignal.c:2423: signal 'activate' is invalid for instance '0x7fca1e51a1f0' of type 'GtkSpinButton'

(SWT:4007): GLib-GObject-WARNING **: 10:00:07.392: gsignal.c:2423: signal 'populate-popup' is invalid for instance '0x7fca1e51a1f0' of type 'GtkSpinButton'
Comment 11 Eclipse Genie CLA 2019-03-28 12:11:03 EDT
New Gerrit change created: https://git.eclipse.org/r/139690
Comment 13 Eclipse Genie CLA 2021-03-18 15:07:33 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.