Bug 541378 - [GTK4] Implement GtkWindow "close-request" signal
Summary: [GTK4] Implement GtkWindow "close-request" signal
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.10   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.11 M1   Edit
Assignee: Eric Williams CLA
QA Contact:
URL:
Whiteboard: RHT
Keywords: triaged
Depends on:
Blocks: 540385
  Show dependency tree
 
Reported: 2018-11-20 11:13 EST by Eric Williams CLA
Modified: 2019-01-09 10:51 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Williams CLA 2018-11-20 11:13:55 EST 
Instead of hooking into the "delete-event" signal for Shells, use GtkWindow's "close-request" signal.
Comment 1 Alexander Kurtakov CLA 2018-11-27 11:48:39 EST 
Is this the reason for Snippet1 not killing the process ?
Comment 2 Eric Williams CLA 2018-11-27 11:50:40 EST 
(In reply to Alexander Kurtakov from comment #1)
> Is this the reason for Snippet1 not killing the process ?

Correct.
Comment 3 Eclipse Genie CLA 2018-11-28 08:31:24 EST 
New Gerrit change created: https://git.eclipse.org/r/133181
Comment 5 Eric Williams CLA 2018-12-11 11:13:30 EST 
(In reply to Eclipse Genie from comment #4)
> Gerrit change https://git.eclipse.org/r/133181 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=9c5002d0a6ac4b37630cb03911b4de26c750699f

In master now.
Comment 6 Eric Williams CLA 2019-01-09 10:51:07 EST 
Verified in I20190108-1800.