539524 – [GTK4] Port event handling to GtkEventController

Bug 539524 - [GTK4] Port event handling to GtkEventController

Summary: [GTK4] Port event handling to GtkEventController

Status:	NEW

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.23
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Platform-SWT-Inbox
QA Contact:

URL:
Whiteboard:	RHT
Keywords:	triaged

Depends on:
Blocks:	540385
	Show dependency tree

Reported:	2018-09-26 14:10 EDT by Eric Williams
Modified:	2021-11-26 15:59 EST (History)
CC List:	2 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Gerrit Change Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eric Williams

2018-09-26 14:10:04 EDT

Port SWT's event handling to GtkEventController in preparation for GTK4.

Comment 1 Eric Williams

2018-10-03 14:33:51 EDT

I have had some basic success with a text widget and the "key-pressed" signal. 

However some widgets like Button aren't playing nicely, even at the native level. I've opened an issue against GTK for this: https://gitlab.gnome.org/GNOME/gtk/issues/1379

Comment 2 Eclipse Genie

2018-10-03 16:49:49 EDT

New Gerrit change created: https://git.eclipse.org/r/130369

Comment 3 Eclipse Genie

2018-10-03 17:09:42 EDT

Gerrit change https://git.eclipse.org/r/130369 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=7e252e3b676538e66261bfe18cb6922e90f192bd

Comment 4 Eclipse Genie

2019-01-17 11:44:33 EST

New Gerrit change created: https://git.eclipse.org/r/135264

Comment 5 Eclipse Genie

2019-01-17 15:53:07 EST

Gerrit change https://git.eclipse.org/r/135264 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ce2d380a4f6ab3facf81919f1e2546655ef70e7f

Comment 6 Eclipse Genie

2019-01-18 12:12:00 EST

New Gerrit change created: https://git.eclipse.org/r/135342

Comment 7 Eclipse Genie

2019-01-23 13:52:52 EST

Gerrit change https://git.eclipse.org/r/135342 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4c6f9b48145b05e0fa1ba1ca2d72508f386576b0

Comment 8 Eric Williams

2019-01-23 14:58:35 EST

Some things to note for GTK4 events:

-Enter/leave is not handled properly on the native side, and will be subject to change in the future. For now however this will lead to broken behaviour.

-It will probably be useful to maintain some sort of global controller registry to avoid having redundant controllers for a widget. This can be done later down the road when events are working 100% and can be tested

Comment 9 Eric Williams

2019-03-20 14:33:34 EDT

This isn't in a working state for 3.24, so I'm moving it to be GTK4 only.

Comment 10 Eric Williams

2019-12-16 14:55:27 EST

I think upstream GTK4 development has made some good progress on event handling. Whoever works on this in the future should confirm the status of comment 8.

Comment 11 Eclipse Genie

2021-07-13 11:38:02 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183027

Comment 12 Eclipse Genie

2021-07-19 13:31:42 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183027 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=956c7d6f207ebc12715f8dde298e58af6d33aa22

Comment 13 Eclipse Genie

2021-07-28 15:35:31 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183457

Comment 14 Eclipse Genie

2021-08-12 11:02:22 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183457 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=b70cd16c42914b617e770ad76a8e951fa6ebf325

Comment 15 Eclipse Genie

2021-08-12 11:29:01 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183706 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4ff9f1c7ce18ead311d01f49f210864266dbae88

Comment 16 Joel Majano

2021-11-26 15:59:10 EST

Signal handling is an ongoing process, not all signals have been converted to GtkEventController.