Bug 514466 - The change which renamed 'OK' to 'Save' in the SaveablesList$MyListSelectionDialog must be reverted
Summary: The change which renamed 'OK' to 'Save' in the SaveablesList$MyListSelectionD...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 4.7 M7   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 511198 514230
Blocks: 530569
  Show dependency tree
 
Reported: 2017-03-30 06:07 EDT by Dani Megert CLA
Modified: 2018-01-31 11:28 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2017-03-30 06:07:41 EDT 
I20170328-2000.

The change which renamed 'OK' to 'Save' in the SaveablesList$MyListSelectionDialog must be reverted.

When no file is selected it is very misleading and wrong to have an enabled 'Save' button. On the other hand, you can't disable the button in that case, because then, the user can't perform the 'Close All' operation.

==> The 'OK' button must be kept.


This also solves the mnemonic conflict and you don't have to change the mnemonics for 'Deselect All' and 'Select All'.

==> Parts of bug 514230 must to be reverted.
Comment 1 Lars Vogel CLA 2017-03-30 06:36:44 EDT 
Thanks for the analysis Dani, I agree with you.

I have a patch.
Comment 2 Eclipse Genie CLA 2017-03-30 06:37:37 EDT 
New Gerrit change created: https://git.eclipse.org/r/94123
Comment 4 Dani Megert CLA 2017-04-03 05:38:22 EDT 
Verified in I20170402-2000.
Comment 5 Lars Vogel CLA 2018-01-31 11:19:50 EST 
I think "Save Selected" would work, open Bug 530569 for the discussion.