Community
Participate
Working Groups
We should use verbs instead of yes, no dialogs. If an editor is changed, and if you close it, a "Do you want to Save" dialog is shown. This dialog should say save no save (see Microsoft user guide for good wording).
Created attachment 266584 [details] Image: the new save dialog buttons +1 as with "Save"/"Don't Save" dialog will be more consistent. Code change will follow shortly https://msdn.microsoft.com/en-us/library/windows/desktop/dn742470(v=vs.85).aspx
New Gerrit change created: https://git.eclipse.org/r/90151
Created attachment 266585 [details] image: Save list of resources is not changed Please, note: as you can see in the image above, the "Save Resources" (list) dialog is not (yet) changed. I think we could change also the "Ok" / "Cancel" button labels with "Save" / "Don't Save". Do you agree?
(In reply to Patrik Suzzi from comment #3) > I think we could change also the "Ok" / "Cancel" button labels with "Save" / > "Don't Save". Do you agree? +1
(In reply to Lars Vogel from comment #4) > (In reply to Patrik Suzzi from comment #3) > > > I think we could change also the "Ok" / "Cancel" button labels with "Save" / > > "Don't Save". Do you agree? > > +1 I think the Gerrit does not yet contain this change. Any plans to update it?
Created attachment 266629 [details] image: also saveable list now displays Save/don't save Also the SaveableList$MyListSelectionDialog displays "Save" / "Don't save" instead of "Yes" / "No"
(In reply to Patrik Suzzi from comment #6) > Created attachment 266629 [details] > image: also saveable list now displays Save/don't save > > Also the SaveableList$MyListSelectionDialog displays "Save" / "Don't > save" instead of "Yes" / "No" I think the Cancel label should be preserved, or even better called "Cancel Exit", if only used during existing the workbench.
I(In reply to Lars Vogel from comment #7) > I think the Cancel label should be preserved, or even better called "Cancel > Exit", if only used during existing the workbench. Thanks for pointing this. SaveableList seems generic. I'm rolling back "Don't save" to "Cancel"
Created attachment 266650 [details] iamge: updated save resources list selection dialog
Gerrit change https://git.eclipse.org/r/90151 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d7995d9b2f0ab407d7a94cb3070c1ae97536e86c
The change is now merged in master. Adding N&N shortly.
New Gerrit change created: https://git.eclipse.org/r/90379
Gerrit change https://git.eclipse.org/r/90379 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=e4e279ad923a31044902ebe2aac57aeeb5887fcc
These buttons still need mnemonics. Make sure you don't introduce a conflict with "&Save" and "&Select All". Since "&Save" should use the standard mnemonic S [1], try to change "&Select All" to "Select &All". Check all existing users of that label for further conflicts. [1] See e.g. table "Access keys" in https://msdn.microsoft.com/en-us/library/windows/desktop/dn742465(v=vs.85).aspx
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=975698231155df5cf90dc72556c62b736a9702ee This reverts the change since changing the labels for the MessageDialogWithToggle also changes the return codes and hence the mapping to ISaveablePart2.YES|NO|CANCEL fails. Test Case: 1. open a file and modify it 2. open a new window 3. open the same file from step 1 (should be dirty) 4. close the editor ==> none of the buttons does something useful. NOTE: "Don't save" must be title style, i.e. "Don't Save".
(In reply to Dani Megert from comment #15) > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=975698231155df5cf90dc72556c62b736a9702ee > > This reverts the change since changing the labels for the > MessageDialogWithToggle also changes the return codes and hence the mapping > to ISaveablePart2.YES|NO|CANCEL fails. Looks like this also requires the changes in Bug 511626. Patrik, maybe you can review the related change and use it here?
(In reply to Lars Vogel from comment #16) > (In reply to Dani Megert from comment #15) > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > > ?id=975698231155df5cf90dc72556c62b736a9702ee > > > > This reverts the change since changing the labels for the > > MessageDialogWithToggle also changes the return codes and hence the mapping > > to ISaveablePart2.YES|NO|CANCEL fails. > > Looks like this also requires the changes in Bug 511626. Patrik, maybe you > can review the related change and use it here? Reviewed; indeed the change 90281 (for bug 511626) looks good. In practice, it adds a map to link button labels with proper return values. When that change is merged, I can push a new change, similar to the old change, but with these improvements: - "Save" and "Don't Save" - mnemonics as suggested by Markus in comment #14 - label-to-value mappings: "Save"-> YES , "Don't Save" -> NO
New Gerrit change created: https://git.eclipse.org/r/92332
(In reply to Eclipse Genie from comment #18) > New Gerrit change created: https://git.eclipse.org/r/92332 Too late for M6. I've removed the N&N entry.
(In reply to Eclipse Genie from comment #18) > New Gerrit change created: https://git.eclipse.org/r/92332 The current version of the proposed change fixes the bug and addresses Dani's issue from #comment 15 About Markus' issue from #comment 14, "These buttons still needs mnemonics", (see https://bugs.eclipse.org/bugs/attachment.cgi?id=266650), I suggest addressing this in a following independent change, where we can edit SelectionDialog_selectLabel = Select &All And where we can introduce: SaveableHelper_Save = &Save SaveableHelper_Cancel = &Cancel SaveableHelper_Dont_Save = &Don't Save Having a new, independent change helps in separating the effects.
New Gerrit change created: https://git.eclipse.org/r/92782
(In reply to Patrik Suzzi from comment #20) > About Markus' issue from #comment 14, "These buttons still needs mnemonics", > (see https://bugs.eclipse.org/bugs/attachment.cgi?id=266650), I suggest > addressing this in a following independent change, where we can edit > SelectionDialog_selectLabel = Select &All > > And where we can introduce: > SaveableHelper_Save = &Save > SaveableHelper_Cancel = &Cancel > SaveableHelper_Dont_Save = &Don't Save > > Having a new, independent change helps in separating the effects. Sounds good to me. Can you please provide a Gerrit for the usages?
Gerrit change https://git.eclipse.org/r/92782 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ec9b497ece4293b634cc7648d70a26a4dcd08965
(In reply to Lars Vogel from comment #22) > (In reply to Patrik Suzzi from comment #20) > > > About Markus' issue from #comment 14, "These buttons still needs mnemonics", > > (see https://bugs.eclipse.org/bugs/attachment.cgi?id=266650), I suggest > > addressing this in a following independent change, where we can edit > > SelectionDialog_selectLabel = Select &All > > > > And where we can introduce: > > SaveableHelper_Save = &Save > > SaveableHelper_Cancel = &Cancel > > SaveableHelper_Dont_Save = &Don't Save > > > > Having a new, independent change helps in separating the effects. > > Sounds good to me. Can you please provide a Gerrit for the usages? Opened Bug 514230 for tracking the mnemonics.
New Gerrit change created: https://git.eclipse.org/r/93890
New Gerrit change created: https://git.eclipse.org/r/93891
Gerrit change https://git.eclipse.org/r/93890 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=65caa5209bb06d4a6d1ee8466d09621c9a56c961
(In reply to Eclipse Genie from comment #27) > Gerrit change https://git.eclipse.org/r/93890 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=65caa5209bb06d4a6d1ee8466d09621c9a56c961 Reverted to adjust the change to the changes of Bug 514058
New Gerrit change created: https://git.eclipse.org/r/93892
Gerrit change https://git.eclipse.org/r/93892 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=74e9a274d5a8ffd021707c747e60d1b32f53f4e3
(In reply to Markus Keller from comment #14) > These buttons still need mnemonics. > > Make sure you don't introduce a conflict with "&Save" and "&Select All". > Since "&Save" should use the standard mnemonic S [1], try to change "&Select > All" to "Select &All". Check all existing users of that label for further > conflicts. SelectionDialog_selectLabel ("Select All") is used by abstract class SelectionDialog hence we do not know who is using that already. David will define new label constants for it to avoid collisions with existing extenders.
