Comment 1 Lars Vogel 2017-03-27 04:43:47 EDT

David, can you please provide a patch for this?

Comment 2 Eclipse Genie 2017-03-27 08:51:54 EDT

New Gerrit change created: https://git.eclipse.org/r/93897

Comment 3 Lars Vogel 2017-03-28 08:49:43 EDT

From Bug 511198

(In reply to Markus Keller from comment #14)
> These buttons still need mnemonics.
> 
> Make sure you don't introduce a conflict with "&Save" and "&Select All".
> Since "&Save" should use the standard mnemonic S [1], try to change "&Select
> All" to "Select &All". Check all existing users of that label for further
> conflicts.

SelectionDialog_selectLabel ("Select All") is used by abstract class SelectionDialog hence we do not know who is using that already. David will define new label constants for it to avoid collisions with existing extenders.

Comment 4 David Weiser 2017-03-29 05:23:41 EDT

The label is set as a field constant in the SelectionDialog. It is not possible to change the selectAll-Label only for the save resources dialog. However, to be consistent with Microsofts access keys, I changed the mnemonic anyway. (https://msdn.microsoft.com/en-us/library/windows/desktop/dn742465(v=vs.85).aspx)

Comment 5 Eclipse Genie 2017-03-30 02:00:15 EDT

Gerrit change https://git.eclipse.org/r/93897 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b10e38fbbb4ed6aef37d4c12b4b0fc20d0aaf953

Comment 6 Lars Vogel 2017-03-30 02:00:25 EDT

Thanks David.

Comment 7 Dani Megert 2017-03-30 06:09:12 EDT

Most of the changes must be reverted since the change to the multi-save dialog is not OK, see bug 514466.

Comment 8 Lars Vogel 2017-03-30 06:35:10 EDT

Thanks Dani, lets do the fix via Bug 514466.