Bug 495230 - Two editors side-by-side and you have a lot of wasted/empty/uggly space above them
Summary: Two editors side-by-side and you have a lot of wasted/empty/uggly space above...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-01 22:00 EDT by Kris De Volder CLA
Modified: 2020-06-16 05:38 EDT (History)
10 users (show)

See Also:


Attachments
screenshot (238.85 KB, image/png)
2016-06-01 22:00 EDT, Kris De Volder CLA
no flags Details
editor area without css (158.73 KB, image/png)
2017-01-31 03:27 EST, Andrey Loskutov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kris De Volder CLA 2016-06-01 22:00:47 EDT
Created attachment 262176 [details]
screenshot

With the RC of Eclipse 4.6 when I drag and tear-off an editor to create two side-by-side editors, there's an ugly, very-wide empty space above the two editors.

Ugly... I can live with. But wasted space could be put to better use to show the contents of the files I'm editing.

These ugly borders aren't really 'new' they also existed in Eclipse 4.5 (and earlier). What's new is that these ugly border are now about 4 times as wide and wasting a lot more space than they did before.

I'll attach a screenshot to show what I mean.

OS: Ubuntu 12.04
Comment 1 Patrik Suzzi CLA 2016-06-02 15:12:40 EDT
This seems a duplicate of bug 494138 (see also Bug 495050)

Could you please tell which version of GTK are you using ?

See: 
https://coffeeorientedprogramming.wordpress.com/2014/10/27/how-to-tell-if-you-are-running-eclipse-on-gtk2-or-on-gtk3/

*** This bug has been marked as a duplicate of bug 494138 ***
Comment 2 Kris De Volder CLA 2016-06-03 11:31:13 EDT
GTK3
Comment 3 Andrey Loskutov CLA 2017-01-31 03:22:56 EST
This is not a dup of bug 494138, because I observe this issue and have NO problems with extra toolbar reserved for min/max.

This issue appears, if you drag/drop one editor next to the sibling editor *inside* the editor area. If you drag/drop the editor to the view stack, no ugly heading appears. 

So I this is the problem of the editor area rendering with two editors next to each other.
Comment 4 Andrey Loskutov CLA 2017-01-31 03:27:50 EST
Created attachment 266535 [details]
editor area without css

Here you see how it looks like *without* CSS themes.
It does NOT waste that huge extra space above the min/max upper border.

But without CSS we see another issue with this: the wrong white color applied to the editor area title. Without CSS this wrong white color applied to the border of the title only.
Comment 5 David Balažic CLA 2019-12-13 08:52:13 EST
This seems like a duplicate of bug 389833
Comment 6 Lars Vogel CLA 2020-06-12 06:10:14 EDT
Kris, can you still reproduce with 2020-06? Looks good to (using Linux).
Comment 7 Kris De Volder CLA 2020-06-15 19:44:47 EDT
Looks much better than before. There is however still a strange narrow empty space above the two editors. This bar contains two small buttons which shows the text 'minimize' and 'maximize' respectively when hovered over.

Do we really need this kind of extra widgetry?

BTW: I can get rid of this extra widgretry by doing some extra steps. When dragging the editor tab, rather than dragging it besides the original editor, instead drop it onto another view (e.g. the outline view). Then select the tab again in outline view and drag it again. Now drop it 'besides' the original editor.

Now I don't have the extra 'minimize / maximize' grey bar.

I think its a bit illogical / inconsistent. I think both cases should behave the same and should just drop the editor besides the other *without* extra widgets on top of them.

That being said, if the 'minimize / maximize' widgets are there for a good reason and this is 'by design'... yes they do look a lot less uggly and less intrusive than they used to. So if that's all we are after for a 'fix' then you can close this as fixed.
Comment 8 Lars Vogel CLA 2020-06-16 04:47:33 EDT
(In reply to Kris De Volder from comment #7)

Thanks for your reply. 

> Looks much better than before. There is however still a strange narrow empty
> space above the two editors. This bar contains two small buttons which shows
> the text 'minimize' and 'maximize' respectively when hovered over.
> 
> Do we really need this kind of extra widgetry?

I also think this is super ugly. I think this is bug 562510.

> BTW: I can get rid of this extra widgretry by doing some extra steps. When
> dragging the editor tab, rather than dragging it besides the original
> editor, instead drop it onto another view (e.g. the outline view). Then
> select the tab again in outline view and drag it again. Now drop it
> 'besides' the original editor.
> 
> Now I don't have the extra 'minimize / maximize' grey bar.
> 
> I think its a bit illogical / inconsistent. I think both cases should behave
> the same and should just drop the editor besides the other *without* extra
> widgets on top of them.


> That being said, if the 'minimize / maximize' widgets are there for a good
> reason and this is 'by design'... yes they do look a lot less uggly and less
> intrusive than they used to. So if that's all we are after for a 'fix' then
> you can close this as fixed.

I think the splitted stack should have the option to get minimized / maximized but it would be nice if min/max would not look ugly. I think we have Bug 562510 for that so I mark this one as fixed.