Bug 494138 - Minimize/Maximize wrapped to separate toolbar on parts in NEON RC1
Summary: Minimize/Maximize wrapped to separate toolbar on parts in NEON RC1
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
: 495050 497264 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-05-20 07:01 EDT by Markus Duft CLA
Modified: 2020-06-12 06:59 EDT (History)
11 users (show)

See Also:


Attachments
comparison mars.2 and neon (54.44 KB, image/png)
2016-05-20 07:01 EDT, Markus Duft CLA
no flags Details
GTK2 (left) vs. GTK3 (right) target on NEON RC1 (151.46 KB, image/png)
2016-05-30 02:00 EDT, Markus Duft CLA
no flags Details
E4 Model Spy of application (welcome screen) (615.99 KB, image/png)
2016-05-30 10:09 EDT, Markus Duft CLA
no flags Details
Eclipse 3.9.2 / STS on OSX (34.79 KB, image/png)
2018-02-06 18:07 EST, Steve Hunter CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Duft CLA 2016-05-20 07:01:22 EDT
Created attachment 261885 [details]
comparison mars.2 and neon

I tested Neon RC1 as target for our RCP application. It seems there is a slight difference between the two, as visible in the attached screenshot. Scaling of the icons is /not/ the issue. The problem is, that the minimize/maximize buttons are wrapped to a separate toolbar on Neon, where in Mars.2 (and all previous versions) those buttons have been next to the tabs.

Since this does not happen to the IDE views, I suspect that something in an area changed that is not obvious to me... 

What we're showing in our application is "extends EditorPart implements ISaveablePart2"
Comment 1 Patrik Suzzi CLA 2016-05-21 12:27:44 EDT
I notice there is also a difference in the size of the icons. 

This Looks like an SWT Issue. Could you please tell us which Linux and which GTK version are you using?

https://coffeeorientedprogramming.wordpress.com/2014/10/27/how-to-tell-if-you-are-running-eclipse-on-gtk2-or-on-gtk3/
Comment 2 Markus Duft CLA 2016-05-30 01:29:57 EDT
(In reply to Patrik Suzzi from comment #1)
> I notice there is also a difference in the size of the icons. 
> 
> This Looks like an SWT Issue. Could you please tell us which Linux and which
> GTK version are you using?
> 
> https://coffeeorientedprogramming.wordpress.com/2014/10/27/how-to-tell-if-
> you-are-running-eclipse-on-gtk2-or-on-gtk3/

Sure. This is GTK3 on Fedora 21:

Installed Packages
gtk3.x86_64 3.14.15-1.fc21

lrwxrwxrwx 1 root root      21 Jul 22  2015 /usr/lib64/libgtk-3.so.0 -> libgtk-3.so.0.1400.15
-rwxr-xr-x 1 root root 7150024 Jul 22  2015 /usr/lib64/libgtk-3.so.0.1400.15


Linux fril0025.wamas.com 4.1.8-100.fc21.x86_64 #1 SMP Tue Sep 22 12:13:06 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
Comment 3 Markus Duft CLA 2016-05-30 01:31:00 EDT
(In reply to Patrik Suzzi from comment #1)
> I notice there is also a difference in the size of the icons. 
> 

Side Note: on MARS.2 the size of the icons changes (to normal) when trying to click them ;) We had that issue for quite some time now, and NEON seems to fix it.
Comment 4 Nobody - feel free to take it CLA 2016-05-30 01:35:30 EDT
Does this happen if you run with SWT_GTK3=0 environment variable?
Comment 5 Markus Duft CLA 2016-05-30 01:57:56 EDT
Nope, with GTK2 everything seems as usual.
Comment 6 Markus Duft CLA 2016-05-30 02:00:15 EDT
Created attachment 262101 [details]
GTK2 (left) vs. GTK3 (right) target on NEON RC1

screenshot of the two GTK versions
Comment 7 Andrey Loskutov CLA 2016-05-30 02:10:10 EDT
Are you on KDE? Which GTK+ theme are you using? Can you try to use Adwaita?
Comment 8 Markus Duft CLA 2016-05-30 02:13:04 EDT
Cinnamon here. Theme is zukitwo.
Comment 9 Markus Duft CLA 2016-05-30 02:13:43 EDT
and, as stated in the original comment, this happens with our RCP application, but not with the NEON IDE itself - which seems strange...
Comment 10 Markus Duft CLA 2016-05-30 02:14:56 EDT
same happens with adwaita
Comment 11 Andrey Loskutov CLA 2016-05-30 08:04:36 EDT
(In reply to Markus Duft from comment #8)
> Cinnamon here. Theme is zukitwo.

Any chance to try with the "default" Gnome session/theme? IMHO GTK3 is known to fail if not used in Gnome :-).

(In reply to Markus Duft from comment #9)
> and, as stated in the original comment, this happens with our RCP
> application, but not with the NEON IDE itself - which seems strange...

Arggh, I've missed that! This would indicate that is not an SWT issue, but then I can't get why it is broken only on GTK3. Are you sure they both are using same Neon platform libraries?
Comment 12 Markus Duft CLA 2016-05-30 08:07:26 EDT
(In reply to Andrey Loskutov from comment #11)
> (In reply to Markus Duft from comment #8)
> > Cinnamon here. Theme is zukitwo.
> 
> Any chance to try with the "default" Gnome session/theme? IMHO GTK3 is known
> to fail if not used in Gnome :-).

Hmm, let's see whether I can get Gnome running here :D

> 
> (In reply to Markus Duft from comment #9)
> > and, as stated in the original comment, this happens with our RCP
> > application, but not with the NEON IDE itself - which seems strange...
> 
> Arggh, I've missed that! This would indicate that is not an SWT issue, but
> then I can't get why it is broken only on GTK3. Are you sure they both are
> using same Neon platform libraries?

The GTK2/3 tryouts 100% only differ by the environment variable to turn off GTK3.
Comment 13 Markus Duft CLA 2016-05-30 08:33:45 EDT
Happens with Gnome 3 session too. phew. :)
Comment 14 Markus Duft CLA 2016-05-30 10:09:41 EDT
Created attachment 262111 [details]
E4 Model Spy of application (welcome screen)

I just noticed that this also happens with the welcome screen. we're using a plain workbench intro for this... I also included the E4 model spy to give you some overview of the application model - no big surprises from my POV.

If you need to know more, please tell me.
Comment 15 Patrik Suzzi CLA 2016-05-31 20:03:59 EDT
*** Bug 495050 has been marked as a duplicate of this bug. ***
Comment 16 Patrik Suzzi CLA 2016-06-02 15:12:41 EDT
*** Bug 495230 has been marked as a duplicate of this bug. ***
Comment 17 Patrik Suzzi CLA 2016-07-04 17:36:46 EDT
*** Bug 497264 has been marked as a duplicate of this bug. ***
Comment 18 Steve Hunter CLA 2018-02-06 18:07:17 EST
Created attachment 272563 [details]
Eclipse 3.9.2 / STS on OSX

I'm seeing the same issue on OSX 10.13.3.
Comment 19 Eric Williams CLA 2018-08-16 15:00:11 EDT
(In reply to Steve Hunter from comment #18)
> Created attachment 272563 [details]
> Eclipse 3.9.2 / STS on OSX
> 
> I'm seeing the same issue on OSX 10.13.3.

Unlikely it's a Linux GTK issue or even SWT, then. Moving to Platform UI for comment.
Comment 20 David Balažic CLA 2019-12-13 08:55:31 EST
The latest comments and duplicates seem more to be bug 389833 (which is not Linux specific, happens at least on Windows) than the original issue reported here.
Comment 21 Lars Vogel CLA 2020-06-12 05:56:52 EDT
Rolf, please check if that is still valid.
Comment 22 Rolf Theunissen CLA 2020-06-12 06:52:51 EDT
The original issue is reported on Linux, and shows a difference between GTK2 and GTK3. I am not on Linux, so I cannot validate. Though, this could be a duplicate of Bug 499215.

w.r.t. the duplicates they are probably not related, as they are about the 'double' bars in top of the editor area. That should be Bug 389833 (stalebug) and/or Bug 495230.
Comment 23 Lars Vogel CLA 2020-06-12 06:59:06 EDT
Thanks Rolf, I cannot replicate on Linux with Eclipse SDK
Version: 2020-09 (4.17)
Build id: I20200610-1800
OS: Linux, v.5.4.0-37-generic, x86_64 / gtk 3.24.18, WebKit 2.28.2
Java version: 1.8.0_252


So this might be fixed via another bug as Rolf indicated.

Markus, please reopen if you still see this with 2020-06.