Community
Participate
Working Groups
Several users report bad performance if to many editors are opened. We should warn the user if he opens the first time more than 99 editors and explain to him that this might cause performance issues. We could also point tot the preference page for auto-closing editors once a certain threshold is reached.
Stefan, can you take this one?
> Several users report bad performance if to many editors are opened. Can you list those bugs here, please. > We should warn the user if he opens the first time more than 99 It would be good to make the trigger dynamic. "99" might work for normal textual editors on normal files. If editors are opened on very big files or more complex editors, like PDE editors, are opened, then 99 might already be too high.
> 99 might already be too high It might be too high to prevent performance or memory issues, yes... but I don't think that's the point of the prompt. The point of the prompt is to teach users what they should do about it if they find the performance unacceptable without annoying users who are already in the habit of closing their unused tabs regularly. > Can you list those bugs here, please. At least in my case, I generally resolved the user issues by telling them "close all those editors". I never filed a bug against Eclipse since I considered the large number of open editors itself to be the problem. Now that we're enabling the auto-close preference within Google, I'm unlikely to see such reports again. However, I'll run some of my own tests the next chance I get and will file some bugs about whatever I find.
Mass move to 4.6 RC1. We might push out more to 4.7.
I suggest to activate "Close editors automatically" and set the limit to 99. This way we prevent users from running Eclipse with a super large number of open editors in the default configuration. I know this was discussed before but IMHO the limit of 99 should be sufficient to affect normal users.
Mass move to M4.
(In reply to Lars Vogel from comment #5) > I suggest to activate "Close editors automatically" and set the limit to 99. > This way we prevent users from running Eclipse with a super large number of > open editors in the default configuration. Dani, any objections against this? I think this will help to keep the Eclipse IDE responsive by default, even if the user never look at the number of open editors. > I know this was discussed before but IMHO the limit of 99 should be > sufficient to not affect normal users.
I plan to commit this early M5, unless I hear concerns from Dani or others.
David, please provide a Gerrit review for this change.
New Gerrit change created: https://git.eclipse.org/r/87065
Gerrit change https://git.eclipse.org/r/87065 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ee463bf274be6a63bab1aaa3397084315a486c88
(In reply to Lars Vogel from comment #8) > I plan to commit this early M5, unless I hear concerns from Dani or others. The N&N must tell people who enabled that preference and did not change the default, will now no longer get the editors closed after 8 open editors. It will take them 99 editors.
This change made editor pinning more prominent/necessary, so it should raise your priority for fixing pinning-related bugs like bug 462613, bug 461667, bug 509456, bug 461579.
(In reply to Markus Keller from comment #13) > This change made editor pinning more prominent/necessary, so it should raise > your priority for fixing pinning-related bugs like bug 462613, bug 461667, > bug 509456, bug 461579. David, Lars, can you fix those for M5? Otherwise I tend to revert your change.
(In reply to Dani Megert from comment #14) > David, Lars, can you fix those for M5? Otherwise I tend to revert your > change. I don't see the connection to the pinned editor issues so I do not see why they should depend on each other.
(In reply to Lars Vogel from comment #15) > (In reply to Dani Megert from comment #14) > > David, Lars, can you fix those for M5? Otherwise I tend to revert your > > change. > > I don't see the connection to the pinned editor issues so I do not see why > they should depend on each other. Because enabling to close editors automatically enables the pin functionality.
New Gerrit change created: https://git.eclipse.org/r/88776
Gerrit change https://git.eclipse.org/r/88776 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2d70242174b0db98a6b72ac34318b770993b3835
(In reply to Eclipse Genie from comment #18) > Gerrit change https://git.eclipse.org/r/88776 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2d70242174b0db98a6b72ac34318b770993b3835 > This reverts the change. Since pinning was enabled out of the box, the bugs mentioned in comment 13 become prominent. Those need to be fixed before fixing this bug here.
(In reply to Dani Megert from comment #19) > Since pinning was enabled out of the box, the bugs > mentioned in comment 13 become prominent. Those need to be fixed before > fixing this bug here. The changed only closed automatically editors if they reached 99, I think the performance degradation (I just run into such an issue with lots of Asciidoctor editors open), is worse then making the pin bugs more prominent. I suggest enabling this again in 4.10. 99 seems like a high enough number so that this would only affect people which almost never close editors.
New Gerrit change created: https://git.eclipse.org/r/131433
(In reply to Eclipse Genie from comment #21) > New Gerrit change created: https://git.eclipse.org/r/131433 Lars, all bugs this one depends on are still open.
(In reply to Andrey Loskutov from comment #22) > (In reply to Eclipse Genie from comment #21) > > New Gerrit change created: https://git.eclipse.org/r/131433 > > Lars, all bugs this one depends on are still open. See comment 20.
(In reply to Lars Vogel from comment #20) > (In reply to Dani Megert from comment #19) > > Since pinning was enabled out of the box, the bugs > > mentioned in comment 13 become prominent. Those need to be fixed before > > fixing this bug here. > > The changed only closed automatically editors if they reached 99, I think > the performance degradation (I just run into such an issue with lots of > Asciidoctor editors open), is worse than making the pin bugs more prominent. > I suggest enabling this again in 4.10. 99 seems like a high enough number so > that this would only affect people which almost never close editors. Dani, what do you think? AFAIK pin editor is not so commonly used (I have not seen it in use) but having too many editors open is very common.
Mass change, please reset target if you still planning to fix this for 4.11.
(In reply to Lars Vogel from comment #24) > Dani, what do you think? AFAIK pin editor is not so commonly used (I have > not seen it in use) but having too many editors open is very common. Dani?
(In reply to Lars Vogel from comment #26) > (In reply to Lars Vogel from comment #24) > > Dani, what do you think? AFAIK pin editor is not so commonly used (I have > > not seen it in use) but having too many editors open is very common. > > Dani? At least bug 462613 and bug 509456 should be addressed first.
This bug is a duplicate of Bug 91486. However I don't want to destroy the discussion on this bug, so it adding as 'See also'.
(In reply to Dani Megert from comment #27) > > Dani? > At least bug 462613 and bug 509456 should be addressed first. Done. Planning to merge the 99 patch tomorrow.
*** Bug 91486 has been marked as a duplicate of this bug. ***
Gerrit change https://git.eclipse.org/r/131433 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f6cfc1a49e58f7b3dc6d56d69393fde01245b604
New Gerrit change created: https://git.eclipse.org/r/144407
(In reply to Dani Megert from comment #27) > > Dani? > At least bug 462613 and bug 509456 should be addressed first. Move the other bugs to see also.
Gerrit change https://git.eclipse.org/r/144407 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=afc4bb4e01b5c39b7b2ce9d3e8215f880f1d7855
