Community
Participate
Working Groups
Created attachment 252953 [details] Current Filter Icon In my opinion a suitable icon for filtering should be a funnel, rather than the attached one, which is currently used for filtering purposes.
Dani, what do you think? Shall we try to introduce a new filter icon in the next release? Background: The Gradle dev team is looking for a filter icon with a better semantic.
(In reply to Lars Vogel from comment #1) > Dani, what do you think? Shall we try to introduce a new filter icon in the > next release? > > Background: The Gradle dev team is looking for a filter icon with a better > semantic. What's not good with our icon and what is the semantic that Gradle has/wants, for which our icon doesn't fit? If it's not the same semantic then having a different icon would be the right approach.
(In reply to Dani Megert from comment #2) > What's not good with our icon I think a filter is typically represented via a filter icon (German: Trichter).
(In reply to Lars Vogel from comment #3) > (In reply to Dani Megert from comment #2) > > What's not good with our icon > > I think a filter is typically represented via a filter icon (German: > Trichter). Well, I could claim that this is a wrong icon since it does *not* filter: when I pour water into the funnels I have, I get the same amount of water out of it ;-)
But, if we put different colored dots(or waterdrops ;) ) over the funnel and underneath we have just one single color, I think it will be more clear than the current icon.
It's not a good idea to use color for usability purposes (color blind users, etc). Simon's suggestion is definitely the most widely used and common figure: https://www.google.com/search?q=filter+icon
Mass move to 4.7 as M7 is approaching. Please move back in case you are planning to fix it for Neon.
+1 for using the proposed type if icon for Filter. It is more immediate. Can you please provide links with the guidelines to create icons?
I am not sure if changing this very known icon is such a good idea. Wouldn't this confuse existing eclipse users? I currently find 10 different plugins in different eclipse repos that use use this icon (platform, jdt, pde, navigator, debug, )
(In reply to Matthias Becker from comment #9) > I am not sure if changing this very known icon is such a good idea. Wouldn't > this confuse existing eclipse users? +100 > I currently find 10 different plugins in different eclipse repos that use > use this icon (platform, jdt, pde, navigator, debug, )
I think the trick would be to keep some of the existing elements and orientation the same while making it less abstract looking. That way existing users will still recognize it and new users won't be baffled by the design.
You mean something like this ? http://i.imgur.com/QJS2pAc.png
(In reply to Matthias Becker from comment #9) > I am not sure if changing this very known icon is such a good idea. Wouldn't > this confuse existing eclipse users? Today at a new customer side with a group of developers using Eclipse for > 10 years, all of them were surprised that the Problems view can also filter. They were not expecting that based on the icon and never clicked on it to see what it does. IMHO the existing icon does not bring the message of that we can filter. I suggest we use a commonly used icon, e.g. similar to the icons Google shows if you search for "filter icon". This is what users understands.
(In reply to Dani Megert from comment #4) > (In reply to Lars Vogel from comment #3) > > (In reply to Dani Megert from comment #2) > > > What's not good with our icon > > > > I think a filter is typically represented via a filter icon (German: > > Trichter). > > Well, I could claim that this is a wrong icon since it does *not* filter: > when I pour water into the funnels I have, I get the same amount of water > out of it ;-) +1 A more appropriate metaphor is a sieve.
(In reply to Stephan Herrmann from comment #14) > +1 > > A more appropriate metaphor is a sieve. Something like https://www.iconfinder.com/icons/4154214/sieve_icon?
Looks like a magnifier for me. (especially in 32x32) Apart from the fact that I like the current icon if I think of a filter icon I come to the funnel. https://www.iconfinder.com/icons/4260114/filter_filtering_filtration_sieve_strainer_icon I know that was already discussed here but the only filter icon I found so far in another application was in Thunderbird which use a funnel.
(In reply to Paul Pazderski from comment #16) > Looks like a magnifier for me. (especially in 32x32) > > Apart from the fact that I like the current icon if I think of a filter icon > I come to the funnel. > https://www.iconfinder.com/icons/4260114/ > filter_filtering_filtration_sieve_strainer_icon > I know that was already discussed here but the only filter icon I found so > far in another application was in Thunderbird which use a funnel. I agree. All other apps I have looked at that use a "Filter" icon use a funnel like linked above. I never have seen a sieve on a "Filter" icon.
Will add: SQLDeveloper -> funnel SQuirreL SQL Client -> same icon as Eclipse :)
(In reply to Matthias Becker from comment #17) looked at that use a "Filter" icon use a funnel like > linked above. I never have seen a sieve on a "Filter" icon. Which one are these?
(In reply to Lars Vogel from comment #19) > Which one are these? If you want more, I additional found funnel in Inkscape, WinMerge, WinSCP, PDF-XChange Viewer, Process Monitor, Windows Events/Log Viewer (don't know the correct english name).
(In reply to Lars Vogel from comment #19) > (In reply to Matthias Becker from comment #17) > looked at that use a "Filter" icon use a funnel like > > linked above. I never have seen a sieve on a "Filter" icon. > > Which one are these? Thunderbird (as stated above) and some SAP Fiori Apps. See what SAP's Fiori Design Guidelines say. The following shows sort, filter and group icons https://experience.sap.com/fiori-design-web/wp-content/uploads/sites/5/2017/11/View-Settings-Dialog-Initial-1.52-1.png
In Excel, its a funnel https://www.excelcampus.com/wp-content/uploads/2016/10/Excel-Clear-All-Filters-and-Start-Over-Filter-Mate-Add-in.png In IntelliJ, a funnel https://d3nmt5vlzunoa1.cloudfront.net/idea/files/2017/06/Screen-Shot-2017-06-06-at-16.36.48.gif In Visual Studio, funnel https://visualstudioplatformteam.gallerycdn.vsassets.io/extensions/visualstudioplatformteam/solutionerrorvisualizer/15.0.4/1543238152087/117187/1/sfilter.gif
Sounds like most tools use a funnel, thanks everyone I bring this UX topic up in one of the next PMC calls.
The PMC agree that we should replace the old icon, ideally with a funnel with a filter indicator. Any volunteers?
(In reply to Lars Vogel from comment #24) > The PMC agree that we should replace the old icon, ideally with a funnel > with a filter indicator. Any volunteers? How about a combination of funnel and sieve, i.e. a sieve on top of the funnel where things go in.
For me, a funnel is enough as it is the standard icon for filtering. it tooks me 10 years to understand what the search eclipse icon is (a flash light) whereas it shall be a magnifying glass.
(In reply to Philippe DUL from comment #26) > For me, a funnel is enough as it is the standard icon for filtering. Some tools often use a magnifier icon. Funny enough, Thunderbird uses the funnel on its Quick Filter button, but the entry field then uses the magnifier.
(In reply to Dani Megert from comment #25) > (In reply to Lars Vogel from comment #24) > > The PMC agree that we should replace the old icon, ideally with a funnel > > with a filter indicator. Any volunteers? > How about a combination of funnel and sieve, i.e. a sieve on top of the > funnel where things go in. No. You won't be able so see this clearly in 16x16 pixel. You have to draw very basic shapes on such few pixels.. *All* other tools imply use a funnel. Eclipse should do the same.
(In reply to Lars Vogel from comment #24) > The PMC agree that we should replace the old icon, ideally with a funnel > with a filter indicator. Any volunteers? I can draw an icon. Replacing this in all the locations should do somebody else.
(In reply to Dani Megert from comment #27) > (In reply to Philippe DUL from comment #26) > > For me, a funnel is enough as it is the standard icon for filtering. > Some tools often use a magnifier icon. Funny enough, Thunderbird uses the > funnel on its Quick Filter button, but the entry field then uses the > magnifier. I would see the magnifier as icon for a special type of filter. The quick filter button opens me the possibility to filter by text, unread status, tags or something else. The magnifier then is for the special case of filter by text.
(In reply to Matthias Becker from comment #29) > (In reply to Lars Vogel from comment #24) > > The PMC agree that we should replace the old icon, ideally with a funnel > > with a filter indicator. Any volunteers? > > I can draw an icon. Replacing this in all the locations should do somebody > else. Thanks, sounds good. I can do the replacement in the platform base. As for a funnel with filter, I like a bar which indicates that not all will pass, e.g., as for example here: https://www.iconfinder.com/icons/3229105/filler_filter_funnel_sales_funnel_strainer_icon If you have better ideas, of course please go ahead with your icon proposal.
New Gerrit change created: https://git.eclipse.org/r/148639
New Gerrit change created: https://git.eclipse.org/r/148640
(In reply to Lars Vogel from comment #31) > (In reply to Matthias Becker from comment #29) > > (In reply to Lars Vogel from comment #24) > > > The PMC agree that we should replace the old icon, ideally with a funnel > > > with a filter indicator. Any volunteers? > > > > I can draw an icon. Replacing this in all the locations should do somebody > > else. > > Thanks, sounds good. I can do the replacement in the platform base. > > As for a funnel with filter, I like a bar which indicates that not all will > pass, e.g., as for example here: > https://www.iconfinder.com/icons/3229105/ > filler_filter_funnel_sales_funnel_strainer_icon If you have better ideas, of > course please go ahead with your icon proposal. See my two commits (one for images repo and one for the first usage in platform). How do you like the new icon?
Created attachment 279724 [details] New filter icon in light theme
Created attachment 279725 [details] New filter icon in dark theme
(In reply to Matthias Becker from comment #34) > How do you like the new icon? I did take the colors form the expland collapse all icons. But maybe we could take the yellow colors (e.g. like the link with editor icon). What do you think?
(In reply to Matthias Becker from comment #37) > What do you think? I like it, will upload a screenshot soon with it in the Problems View.
(In reply to Matthias Becker from comment #37) > (In reply to Matthias Becker from comment #34) > > How do you like the new icon? > > I did take the colors form the expland collapse all icons. > But maybe we could take the yellow colors (e.g. like the link with editor > icon). > > What do you think? Had the same thought. I would give it a try. By the way. There are some specialized filter icons based on the old one. Instances I remember: JUnit filter stacktrace icon and EGit filter history icons.
(In reply to Paul Pazderski from comment #39) > JUnit filter stacktrace icon and EGit filter history icons. Exactly. I like the blue. Besides, EGit will need to adapt its various filter icons in the history view to match this, and will overlay for instance a yellow folder to mean "filter the git history to show only changes in the folder the current resource is in". That won't work well if the filter itself is yellow.
Created attachment 279726 [details] Problem view Linux Light
Created attachment 279727 [details] Problems view Linux Dark view
(In reply to Thomas Wolf from comment #40) > (In reply to Paul Pazderski from comment #39) > > JUnit filter stacktrace icon and EGit filter history icons. > > Exactly. I like the blue. Besides, EGit will need to adapt its various > filter icons in the history view to match this, and will overlay for > instance a yellow folder to mean "filter the git history to show only > changes in the folder the current resource is in". That won't work well if > the filter itself is yellow. So we stick to the blue?
(In reply to Matthias Becker from comment #43) > > Exactly. I like the blue. > So we stick to the blue? +1
(In reply to Thomas Wolf from comment #40) > Exactly. I like the blue. Besides, EGit will need to adapt its various > filter icons in the history view to match this, and will overlay for > instance a yellow folder to mean "filter the git history to show only > changes in the folder the current resource is in". That won't work well if > the filter itself is yellow. Maybe you can try to adapt this for you needs. If we see that the platform icons could be improved to allow overlays better we can do that easily now.
(In reply to Matthias Becker from comment #45) > (In reply to Thomas Wolf from comment #40) > > Exactly. I like the blue. Besides, EGit will need to adapt its various > > filter icons in the history view to match this, and will overlay for > > instance a yellow folder to mean "filter the git history to show only > > changes in the folder the current resource is in". That won't work well if > > the filter itself is yellow. > > Maybe you can try to adapt this for you needs. If we see that the platform > icons > could be improved to allow overlays better we can do that easily now. Gave it a quick try and the light blue funnel works well with EGit's project/folder/resource overlays, in both light and dark mode.
(In reply to Matthias Becker from comment #34) > See my two commits (one for images repo and one for the first usage in > platform). > > How do you like the new icon? If anybody adapts other lcoations pls. keep in mind that the SVG also needs to be replaced in the images repo.
Gerrit change https://git.eclipse.org/r/148640 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=e28228c63789d9e213545b808c2a55e8387ddf5c
Thanks, Matthias for the new icon.
Gerrit change https://git.eclipse.org/r/148639 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=98944def0090af6878c722ac89e97ddbf2b4b119
New Gerrit change created: https://git.eclipse.org/r/149415
New Gerrit change created: https://git.eclipse.org/r/149416
New Gerrit change created: https://git.eclipse.org/r/149418
New Gerrit change created: https://git.eclipse.org/r/149417
New Gerrit change created: https://git.eclipse.org/r/149420
New Gerrit change created: https://git.eclipse.org/r/149419
New Gerrit change created: https://git.eclipse.org/r/149421
New Gerrit change created: https://git.eclipse.org/r/149422
New Gerrit change created: https://git.eclipse.org/r/149423
New Gerrit change created: https://git.eclipse.org/r/149424
New Gerrit change created: https://git.eclipse.org/r/149425
New Gerrit change created: https://git.eclipse.org/r/149426
New Gerrit change created: https://git.eclipse.org/r/149429
(In reply to Lars Vogel from comment #49) > Thanks, Matthias for the new icon. I pushed some more changes. They basically replace copies of that exact some icon in various repos. Lars, can you please review and test?
(In reply to Matthias Becker from comment #64) > (In reply to Lars Vogel from comment #49) > > Thanks, Matthias for the new icon. > > I pushed some more changes. They basically replace copies of that exact some > icon in various repos. > Lars, can you please review and test? Currently busy with my own patches. I looked through a few patches via the new Gerrit UI (shows icon differences) and they look good to me. So I suggest to merge if you are fine with them. If we find later issues, we can still adjust.
Gerrit change https://git.eclipse.org/r/149422 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=fc834b06b73a30fd6f8eed56fceb648723b4013f
Gerrit change https://git.eclipse.org/r/149423 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=881615b60a5da2db70cb86a969e26d791c64d473
Gerrit change https://git.eclipse.org/r/149415 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=b8f8fad70502d9364505a804fe5863e8def2dc13
Gerrit change https://git.eclipse.org/r/149425 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=fff998f53c567476ca114754ee752dab8e864eb2
Gerrit change https://git.eclipse.org/r/149424 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=4fafccfa0e5b17eac59689e59712630f44b05002
Gerrit change https://git.eclipse.org/r/149426 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=efaeab8bf9f9157eab5a643f5ca8422a037620d2
New Gerrit change created: https://git.eclipse.org/r/149579
New Gerrit change created: https://git.eclipse.org/r/149580
New Gerrit change created: https://git.eclipse.org/r/149582
New Gerrit change created: https://git.eclipse.org/r/149581
Gerrit change https://git.eclipse.org/r/149421 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=ac1c2dcb25b818bc67e4adee235c49f81fc1e6d3
Gerrit change https://git.eclipse.org/r/149416 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=2bf06a335729e47009f07578dffa4917140a42b4
Gerrit change https://git.eclipse.org/r/149417 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=39c9386ecc3ae5059f9d58bdacbd88e9c4bd128f
Gerrit change https://git.eclipse.org/r/149418 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=84c3201b821a16068d512c494bea0d879d751a3d
Gerrit change https://git.eclipse.org/r/149419 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=f72925d3bc637abef264c4b152504d94183c4bbe
Gerrit change https://git.eclipse.org/r/149420 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=7573c94e9b215bdc30c7ba8328f4f04e1acaf861
Gerrit change https://git.eclipse.org/r/149429 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=5b6dc850fa1a57fa45845034851d7cf212446607
Gerrit change https://git.eclipse.org/r/149579 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=58833535613e362f2cf13cc2a6de012259fd1cee
Gerrit change https://git.eclipse.org/r/149580 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=e4d1536035d6eadf7b77d66ff8996e7f3e582ae2
Gerrit change https://git.eclipse.org/r/149581 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=4c913a28062af31767b5184e68951127c84444ed
Gerrit change https://git.eclipse.org/r/149582 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=436efe28dca3b0148789ba31d309fb5bb170982a
