Bug 550597 - Update filter icons in history view
Summary: Update filter icons in history view
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 5.6   Edit
Assignee: Thomas Wolf CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 465914
Blocks:
  Show dependency tree
 
Reported: 2019-08-30 09:17 EDT by Thomas Wolf CLA
Modified: 2019-09-17 06:13 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wolf CLA 2019-08-30 09:17:14 EDT 
If platform changes the filter icon (see bug 465914), EGit should get matching new filter icons and use them on platforms that do use the new icon.

See UIIcons, FILTERNONE, FILTERRESOURCE, FILTERFOLDER, FILTERPROJECT, and do a similar version check as for ELCL16_TRASH.

These icons are not used in plugin.xml.
Comment 1 Thomas Wolf CLA 2019-08-30 10:21:42 EDT 
There's also UIIcons.ELCL16_FILTER which will need to be adapted.
Comment 2 Michael Keppler CLA 2019-09-05 02:31:06 EDT 
Are you thinking of just updating the files or instead of making this version dependent (like with the tray icon)?
Comment 3 Thomas Wolf CLA 2019-09-05 02:40:55 EDT 
No, I'm thinking of making it version dependent. On Eclipse platform version still using the old icons EGit should continue to use the existing icons. Otherwise the UI will be inconsistent.

I do have the files prepared; but first Platform shall update its icon.
Comment 4 Eclipse Genie CLA 2019-09-13 11:43:54 EDT 
New Gerrit change created: https://git.eclipse.org/r/149496
Comment 5 Eclipse Genie CLA 2019-09-17 06:13:03 EDT 
Gerrit change https://git.eclipse.org/r/149496 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=596edc64387ed67bf025db05360cca9e302ee7bf