Bug 500617 - [problems view] Add buttons to Problem View, to open Filter
Summary: [problems view] Add buttons to Problem View, to open Filter
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.7 M2   Edit
Assignee: Ian Pun CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 500778 500779 (view as bug list)
Depends on:
Blocks: 511269 500779
  Show dependency tree
 
Reported: 2016-08-31 18:12 EDT by Lars Vogel CLA
Modified: 2017-04-18 11:38 EDT (History)
9 users (show)

See Also:

Attachments
Brief demonstration of the filter button on the toolbar (246.71 KB, video/webm)
2016-09-07 10:55 EDT, Ian Pun CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-08-31 18:12:24 EDT 
We should add a button to open the filter to the Problem view / Bookmark and Tasks view. See also Bug 498356
Comment 1 Eclipse Genie CLA 2016-09-01 09:48:58 EDT 
New Gerrit change created: https://git.eclipse.org/r/80222
Comment 2 Ian Pun CLA 2016-09-01 09:50:41 EDT 
Added changes from Bug 498356 over to this instead. Ready for review and comments about possible choice of Filter icon.
Comment 3 Lars Vogel CLA 2016-09-01 10:00:48 EDT 
(In reply to Ian Pun from comment #2)
> Added changes from Bug 498356 over to this instead. Ready for review and
> comments about possible choice of Filter icon.

At the moment I suggest to use the same filter icon as JDT in the package explorer. Mid-term we should really find a better filter icon for Eclipse. See Bug 465914.
Comment 4 Ian Pun CLA 2016-09-06 10:45:05 EDT 
(In reply to Lars Vogel from comment #3)
> (In reply to Ian Pun from comment #2)
> > Added changes from Bug 498356 over to this instead. Ready for review and
> > comments about possible choice of Filter icon.
> 
> At the moment I suggest to use the same filter icon as JDT in the package
> explorer. Mid-term we should really find a better filter icon for Eclipse.
> See Bug 465914.

Hi Lars,

I noticed that you've created additional bugs for the different views that you wish to have the button on. All those views are actually part of the extendedMarkersView. Perhaps I can find a way to override that view so that all of those views listed will have the filter?
Comment 5 Eclipse Genie CLA 2016-09-06 16:51:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/80500
Comment 6 Mickael Istria CLA 2016-09-07 04:08:15 EDT 
@Ian: can you please provide a screenshot on this bug? It makes it easier to understand the proposal and we could reuse it for the N&N.
Comment 7 Ian Pun CLA 2016-09-07 10:55:12 EDT 
Created attachment 264009 [details]
Brief demonstration of the filter button on the toolbar
Comment 9 Lars Vogel CLA 2016-09-08 03:40:31 EDT 
Awesome Ian. Can you please add a new entry for this in our N&N for 4.7 M2?
Comment 10 Lars Vogel CLA 2016-09-08 08:27:22 EDT 
*** Bug 500779 has been marked as a duplicate of this bug. ***
Comment 11 Lars Vogel CLA 2016-09-08 08:27:46 EDT 
*** Bug 500778 has been marked as a duplicate of this bug. ***
Comment 12 Eclipse Genie CLA 2016-09-08 15:41:34 EDT 
New Gerrit change created: https://git.eclipse.org/r/80729
Comment 13 Ian Pun CLA 2016-09-08 15:47:31 EDT 
(In reply to Lars Vogel from comment #9)
> Awesome Ian. Can you please add a new entry for this in our N&N for 4.7 M2?

Hi Lars,

I updated the N&N; hopefully I did it correctly. Took me a bit of time to get it configured