Bug 454476 - [rulers] "Show Revision Information" should be a toggle
Summary: [rulers] "Show Revision Information" should be a toggle
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.8.2   Edit
Hardware: All All
: P3 enhancement with 6 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 509690 510371 517167 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-12-08 13:01 EST by Ed Willink CLA
Modified: 2018-07-31 11:27 EDT (History)
8 users (show)

See Also:

Attachments
Sceen shot (69.98 KB, image/png)
2017-01-03 11:24 EST, Leo Ufimtsev CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2014-12-08 13:01:04 EST 
Editing with Show Annotations on gives m,any UI freeezes, particular if the debugger is using the same source file as the current line.

Therefore it is important to allow Blame Annotations to be switched off once no longer needed.

This would be easy if Show Annotations in the menu was a toggle in the same way as Show QuickDiff.

Workaround: Close the editor then back to reopen it.
Comment 1 Matthias Sohn CLA 2014-12-09 06:34:09 EST 
You can close the annotations from the context menu of the annotations side bar, 
click "Revisions > Hide Revision Information"
Comment 2 Matthias Sohn CLA 2014-12-09 06:35:11 EST 
Are you really using Windows NT ?
Comment 3 Ed Willink CLA 2014-12-09 07:01:36 EST 
(In reply to Matthias Sohn from comment #2)
> Are you really using Windows NT ?

No Windows 8.1.

(In reply to Matthias Sohn from comment #1)
> You can close the annotations from the context menu of the annotations side
> bar, 
> click "Revisions > Hide Revision Information"

Thanks. Useful, but not obvious. Still worth having the switch it off the same way you switched it on menu paths.
Comment 4 Thomas Wolf CLA 2016-10-14 18:48:39 EDT 
(In reply to Ed Willink from comment #3)
> (In reply to Matthias Sohn from comment #1)
> > You can close the annotations from the context menu of the annotations side
> > bar, 
> > click "Revisions > Hide Revision Information"
> 
> Thanks. Useful, but not obvious. Still worth having the switch it off the
> same way you switched it on menu paths.

I agree, but unfortunately that whole "Revisions" submenu is hard-coded in AbstractDecoratedTextEditor. I don't see an obvious way how we could suppress that nested "Revisions > Hide Revision Information" menu entry and turn "Show Revision Information" into a toggle instead.
Comment 5 Thomas Wolf CLA 2016-12-23 16:16:58 EST 
*** Bug 509690 has been marked as a duplicate of this bug. ***
Comment 6 Leo Ufimtsev CLA 2017-01-03 11:23:46 EST 
Updating bug title as option was renamed.
Comment 7 Leo Ufimtsev CLA 2017-01-03 11:24:27 EST 
Created attachment 266103 [details]
Sceen shot
Comment 8 Andrey Loskutov CLA 2017-01-12 10:20:58 EST 
*** Bug 510371 has been marked as a duplicate of this bug. ***
Comment 9 Dani Megert CLA 2017-03-22 12:17:09 EDT 
> "Show Revision Information" should be a Toggle
	
I agree.
Comment 10 Andrey Loskutov CLA 2017-05-24 05:38:07 EDT 
*** Bug 517167 has been marked as a duplicate of this bug. ***
Comment 11 Dani Megert CLA 2018-05-24 12:52:18 EDT 
Removing target milestone for all bugs that are not major or above.
Comment 12 Dani Megert CLA 2018-05-25 04:07:32 EDT 
> Removing target milestone for all bugs that are not major or above.

Of course I meant "major or below".

Sorry for the noise!