Bug 509690 - Show/Hide revision information should be a single menu item
Summary: Show/Hide revision information should be a single menu item
Status: CLOSED DUPLICATE of bug 454476
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-23 10:30 EST by Leo Ufimtsev CLA
Modified: 2016-12-23 16:16 EST (History)
6 users (show)

See Also:

Attachments
Show Revision Information. (69.98 KB, image/png)
2016-12-23 10:30 EST, Leo Ufimtsev CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Ufimtsev CLA 2016-12-23 10:30:20 EST 
Created attachment 266045 [details]
Show Revision Information.

When you right click on the left ruler, you see the
"Show Revision Information"

When you activate it, the menu still says "Show Revision Information". Clicking on it again does nothing.

Revision information can be hidden via the submenu:
Revisions -> Hide Revision Information
(See screen shot)

This seems counter intuitive. Also it's hard to find the "Hide Revision Information" if you don't already know about it.

May I suggest that there is only one single menu item with a checkbox, that is checked when revision information is shown, and unchecked when it is not. (Following same behaviour of Show Quick Diff or Show Line Numbers).


# Screenshot from Egit from 2016/12/23rd
Comment 1 Andrey Loskutov CLA 2016-12-23 10:33:16 EST 
+1
But why it is on platform/CVS? Isn't this platform/team?
Comment 2 Leo Ufimtsev CLA 2016-12-23 10:36:39 EST 
(In reply to Andrey Loskutov from comment #1)
> +1
> But why it is on platform/CVS? Isn't this platform/team?

Not sure actually.  I just used the same classifications as the related bug. 
This seems to be part of EGit thou. I moved it to EGit. If someone knows the correct classification, please feel free to move to the right place.
Comment 3 Thomas Wolf CLA 2016-12-23 16:16:58 EST 
This is hardcoded in AbstractDecoratedTextEditor and should be fixed there. It's not something that EGit can do anything about. Feel free to move the duplicate to platform/text.

*** This bug has been marked as a duplicate of bug 454476 ***