Community
Participate
Working Groups
Deprecated since 2005, I think we should mark it for deletion.
> .. and related API for deletion Some which come to my mind: org.eclipse.ui.help.DialogPageContextComputer org.eclipse.ui.help.ViewContextComputer
(In reply to Dani Megert from comment #1) > > .. and related API for deletion > > Some which come to my mind: > org.eclipse.ui.help.DialogPageContextComputer > org.eclipse.ui.help.ViewContextComputer Please provide the full list of types that you intend to mark for deletion.
*** Bug 468330 has been marked as a duplicate of this bug. ***
Mass move to 4.7 as M7 is approaching. Please move back in case you are planning to fix it for Neon.
Gerrit change https://git.eclipse.org/r/42833 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=247c2a90f2c0565c886ad854bb2fa4217d8396da [reply] [−] Comment 9
This change was requested by Markus via Bug 442961.
Gerrit change https://git.eclipse.org/r/74274 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=51cb8e3b9ca94b5439520334068b55d78bb25a90
This cause now 33 API errors in the workbench plugins in the IDE. Description Resource Path Location Type Restrictions have been added for type org.eclipse.ui.help.IContextComputer IContextComputer.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 33 Compatibility Problem The constructor org.eclipse.ui.help.DialogPageContextComputer.DialogPageContextComputer(IDialogPage, Object) is no longer API DialogPageContextComputer.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 47 Compatibility Problem The constructor org.eclipse.ui.help.ViewContextComputer.ViewContextComputer(IViewPart, Object) is no longer API ViewContextComputer.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 47 Compatibility Problem The major version should be incremented in version 3.108.0, since API breakage occurred since version 3.107.1 MANIFEST.MF /org.eclipse.ui.workbench/META-INF line 5 Version Numbering Problem The method org.eclipse.ui.help.DialogPageContextComputer.computeContexts(HelpEvent) is no longer API DialogPageContextComputer.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 103 Compatibility Problem The method org.eclipse.ui.help.DialogPageContextComputer.getLocalContexts(HelpEvent) is no longer API DialogPageContextComputer.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 120 Compatibility Problem The method org.eclipse.ui.help.IContextComputer.computeContexts(HelpEvent) is no longer API IContextComputer.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 42 Compatibility Problem The method org.eclipse.ui.help.IContextComputer.getLocalContexts(HelpEvent) is no longer API IContextComputer.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 66 Compatibility Problem The method org.eclipse.ui.help.ViewContextComputer.computeContexts(HelpEvent) is no longer API ViewContextComputer.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 103 Compatibility Problem The method org.eclipse.ui.help.ViewContextComputer.getLocalContexts(HelpEvent) is no longer API ViewContextComputer.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 117 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.createHelpListener(ICommand) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 133 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.displayContext(IContext, int, int) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 96 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.displayHelp() is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 74 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.displayHelp(IContext) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 159 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.displayHelp(String) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 146 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.displayHelpResource(String) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 119 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.getHelp(Control) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 178 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.getHelp(Menu) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 197 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.getHelp(MenuItem) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 216 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.getHelpSupport() is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 229 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.isContextHelpDisplayed() is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 242 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(Control, IContextComputer) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 318 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(Control, Object[]) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 299 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(Control, String) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 416 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(IAction, IContextComputer) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 280 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(IAction, Object[]) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 261 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(IAction, String) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 405 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(Menu, IContextComputer) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 356 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(Menu, Object[]) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 337 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(Menu, String) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 427 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(MenuItem, IContextComputer) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 394 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(MenuItem, Object[]) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 375 Compatibility Problem The method org.eclipse.ui.help.WorkbenchHelp.setHelp(MenuItem, String) is no longer API WorkbenchHelp.java /org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help line 438 Compatibility Problem
(In reply to Andrey Loskutov from comment #8) > This cause now 33 API errors in the workbench plugins in the IDE. Dani, what is the correct solution to this?
(In reply to Lars Vogel from comment #9) > (In reply to Andrey Loskutov from comment #8) > > This cause now 33 API errors in the workbench plugins in the IDE. > > Dani, what is the correct solution to this? Looks like you work with a workspace that is not correctly setup. Using a clean workspace with the correct baseline shows the errors, which would have been a clear indication that such a change is not good. Those are API changes which will cause errors for clients. See also http://download.eclipse.org/eclipse/downloads/drops4/I20160601-2000/apitools/freeze_report.html and http://download.eclipse.org/eclipse/downloads/drops4/I20160601-2000/apitools/analysis/html/org.eclipse.help/report.html The annotations can't be added so late in the game. You have to remove the annotations (but keep the deletion comments). And then post to platform-releng-dev that you need a rebuild.
(In reply to Dani Megert from comment #10) > The annotations can't be added so late in the game. You have to remove the > annotations (but keep the deletion comments). Thanks. The annotations were requested shortterm via Bug 442961. I will remove them and post to platform-releng-dev for a rebuild.
(In reply to Lars Vogel from comment #11) > (In reply to Dani Megert from comment #10) > > The annotations can't be added so late in the game. You have to remove the > > annotations (but keep the deletion comments). > > Thanks. > The annotations were requested shortterm via Bug 442961. When this was requested, the target was reset to 4.7, so not requested short term. > I will remove them > and post to platform-releng-dev for a rebuild. Please also open a new bug to add them early 4.7.
(In reply to Lars Vogel from comment #6) > This change was requested by Markus via Bug 442961. False accusation. I never requested or approved such a change for RC4.
(In reply to Lars Vogel from comment #11) > I will remove them > and post to platform-releng-dev for a rebuild. Hi Lars. What's the ETA for this?
(In reply to Dani Megert from comment #14) > (In reply to Lars Vogel from comment #11) > > I will remove them > > and post to platform-releng-dev for a rebuild. > > Hi Lars. What's the ETA for this? I've had a minute and pushed this patch: https://git.eclipse.org/r/74371/ Please review, for my local IDE instance it fixes the API errors.
(In reply to Andrey Loskutov from comment #15) > (In reply to Dani Megert from comment #14) > > (In reply to Lars Vogel from comment #11) > > > I will remove them > > > and post to platform-releng-dev for a rebuild. > > > > Hi Lars. What's the ETA for this? > > I've had a minute and pushed this patch: https://git.eclipse.org/r/74371/ > > Please review, for my local IDE instance it fixes the API errors. Can you do the same for org.eclipse.help?
(In reply to Andrey Loskutov from comment #15) > (In reply to Dani Megert from comment #14) > > (In reply to Lars Vogel from comment #11) > > > I will remove them > > > and post to platform-releng-dev for a rebuild. > > > > Hi Lars. What's the ETA for this? > > I've had a minute and pushed this patch: https://git.eclipse.org/r/74371/ > > Please review, for my local IDE instance it fixes the API errors. +1 for RC4.
(In reply to Dani Megert from comment #16) > Can you do the same for org.eclipse.help? No, sorry, I have to leave now :-(
(In reply to Andrey Loskutov from comment #15) > I've had a minute and pushed this patch: https://git.eclipse.org/r/74371/ +1 for RC4.
(In reply to Dani Megert from comment #12) > Please also open a new bug to add them early 4.7. Filed bug 495286.
Markus uploaded this change: https://git.eclipse.org/r/#/c/74374/ +1 for RC4.
See bug 491269 for the missing updates by the Eclipse Genie.
New Gerrit change created: https://git.eclipse.org/r/74371
Gerrit change https://git.eclipse.org/r/74371 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4ac7846bf992a8828e59ec9182ef36d2cadef713
New Gerrit change created: https://git.eclipse.org/r/74374
Gerrit change https://git.eclipse.org/r/74374 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=dde1bcf707eac2b5c454295f2b0f37c3207b3ba4
