Bug 442961 - Mark IContextComputer for deletion
Summary: Mark IContextComputer for deletion
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.6 RC4   Edit
Assignee: Lars Vogel CLA
QA Contact: Lars Vogel CLA
URL:
Whiteboard:
Keywords: api, Documentation
: 495048 (view as bug list)
Depends on:
Blocks: 531277
  Show dependency tree
 
Reported: 2014-08-31 13:18 EDT by Lars Vogel CLA
Modified: 2018-02-16 08:43 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-08-31 13:18:22 EDT
Since 2002 IContextComputer is deprecated. I suggest to mark it for deletion (or simply delete it, as the Javadoc says it is no longer supported).
Comment 1 Lars Vogel CLA 2014-10-23 01:22:23 EDT
Dani, OK to do so?
Comment 2 Dani Megert CLA 2014-10-23 05:15:10 EDT
(In reply to Lars Vogel from comment #0)
> Since 2002 IContextComputer is deprecated. I suggest to mark it for deletion
> (or simply delete it, as the Javadoc says it is no longer supported).

The Javadoc lies ;-). The backwards compatibility code is still working.

I'm fine marking it for deletion.
Comment 3 Dani Megert CLA 2014-10-23 05:21:31 EDT
Note that you must list/mark all affected deletions, e.g. org.eclipse.ui.help.WorkbenchHelp will also go away as a consequence.
Comment 4 Eclipse Genie CLA 2015-05-26 09:45:19 EDT
New Gerrit change created: https://git.eclipse.org/r/48643
Comment 6 Lars Vogel CLA 2015-05-26 11:17:51 EDT
.
Comment 7 Dani Megert CLA 2015-05-27 11:21:45 EDT
The deletion date (after 2016) was wrong. We keep it for the next two releases. Fixed this to be 2017.
Comment 8 Markus Keller CLA 2016-05-31 11:59:06 EDT
If you really want to remove things, you have to follow
https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process

None of the API is currently marked for deletion in the @deprecated message and with @no* tags.
Comment 9 Lars Vogel CLA 2016-05-31 12:16:31 EDT
(In reply to Markus Keller from comment #8)
> If you really want to remove things, you have to follow
> https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process
> 
> None of the API is currently marked for deletion in the @deprecated message
> and with @no* tags.

Please stop this time waste and open new bugs.

This was marked for deletion before the process changed.
Comment 10 Markus Keller CLA 2016-05-31 12:42:41 EDT
(In reply to Lars Vogel from comment #9)
> Please stop this time waste and open new bugs.

Are you really so ignorant? Opening a new bug wastes even more time and makes the process even less understandable, but here you are: bug 495048.

> This was marked for deletion before the process changed.

Wrong. https://wiki.eclipse.org/index.php?title=Eclipse%2FAPI_Central%2FAPI_Removal_Process&type=revision&diff=392223&oldid=201263
Comment 11 Dani Megert CLA 2016-05-31 12:58:42 EDT
Lars, two simple ways to fix this:
1. Postpone deletion
2. Add a comment to IContextComputer
Comment 12 Dani Megert CLA 2016-05-31 13:00:13 EDT
*** Bug 495048 has been marked as a duplicate of this bug. ***
Comment 13 Lars Vogel CLA 2016-05-31 13:04:31 EDT
(In reply to Markus Keller from comment #10)
> (In reply to Lars Vogel from comment #9)
> > Please stop this time waste and open new bugs.
> 
> Are you really so ignorant?

My comment was unnecessary harsh, sorry for that. Thanks for watching out. I was only concerned that you would now reopen all old bugs, e.g. the 2.0 comp removal bunch and the like.
Comment 14 Markus Keller CLA 2016-05-31 13:09:44 EDT
(In reply to Dani Megert from comment #11)
> 2. Add a comment to IContextComputer

And to DialogPageContextComputer, ViewContextComputer, WorkbenchHelp

(In reply to Lars Vogel from comment #13)
> My comment was unnecessary harsh, sorry for that.
Mine wasn't better, sorry as well.
Comment 15 Eclipse Genie CLA 2016-06-01 13:43:43 EDT
New Gerrit change created: https://git.eclipse.org/r/74275
Comment 17 Lars Vogel CLA 2016-06-01 13:50:47 EDT
(In reply to Markus Keller from comment #14)
> (In reply to Dani Megert from comment #11)
> > 2. Add a comment to IContextComputer
> 
> And to DialogPageContextComputer, ViewContextComputer, WorkbenchHelp
Should be done. WorkbenchHelp was handled by Bug 442959