Bug 41340 - Support multi-select for Team>Create Patch
Summary: Support multi-select for Team>Create Patch
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement with 2 votes (vote)
Target Milestone: 3.2 M3   Edit
Assignee: Bogdan Gheorghe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 42337 43006 47342 50379 54516 59841 70959 85760 96249 96715 96790 118499 (view as bug list)
Depends on:
Blocks: 103871
  Show dependency tree
 
Reported: 2003-08-08 11:36 EDT by Gary Gregory CLA
Modified: 2005-12-23 10:39 EST (History)
14 users (show)

See Also:


Attachments
Heres a patch against 200404201300 (4.90 KB, patch)
2004-04-22 11:44 EDT, Matthew Conway CLA
no flags Details | Diff
NEw patch using CVS Team (4.98 KB, patch)
2004-05-03 12:51 EDT, Matthew Conway CLA
no flags Details | Diff
Create Patch zip (24.79 KB, application/zip)
2005-09-23 10:30 EDT, Bogdan Gheorghe CLA
no flags Details
Apply Patch zip (28.21 KB, application/zip)
2005-09-23 10:31 EDT, Bogdan Gheorghe CLA
no flags Details
Create Patch zip (24.81 KB, application/zip)
2005-09-23 11:17 EDT, Bogdan Gheorghe CLA
no flags Details
Apply Patch zip (28.27 KB, application/zip)
2005-09-23 11:17 EDT, Bogdan Gheorghe CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gary Gregory CLA 2003-08-08 11:36:06 EDT
Please enable Team/Create Patch when >1 item selected in Navigator View.

For example: in the Java Browsing Perspective, select two directories in the
same parent directory using Ctrl-click, then right-click Team and Create Patch
is /disabled/.

This is quite a pain since I want to generate ONE patch file with all of my
changes and I now must select the parent dir which contains many other dirs
which I do not care about.

Thanks.

eclipse-I20030806
Comment 1 Andre Weinand CLA 2003-08-08 17:38:12 EDT
Create Patch is VCM.
Comment 2 Jean-Michel Lemieux CLA 2003-09-12 11:45:04 EDT
*** Bug 42337 has been marked as a duplicate of this bug. ***
Comment 3 Jean-Michel Lemieux CLA 2003-09-12 11:45:33 EDT
*** Bug 43006 has been marked as a duplicate of this bug. ***
Comment 4 Jean-Michel Lemieux CLA 2003-11-24 16:16:20 EST
*** Bug 47342 has been marked as a duplicate of this bug. ***
Comment 5 Michael Valenta CLA 2004-01-22 09:30:59 EST
*** Bug 50379 has been marked as a duplicate of this bug. ***
Comment 6 Michael Valenta CLA 2004-03-11 14:21:23 EST
*** Bug 54516 has been marked as a duplicate of this bug. ***
Comment 7 Matthew Conway CLA 2004-04-22 11:44:22 EDT
Created attachment 9862 [details]
Heres a patch against 200404201300
Comment 8 Michael Valenta CLA 2004-04-23 16:50:10 EDT
*** Bug 59841 has been marked as a duplicate of this bug. ***
Comment 9 Matthew Conway CLA 2004-05-03 12:51:05 EDT
Created attachment 10223 [details]
NEw patch using CVS Team

Re-did the patch using CVS Team instead of command line
Comment 10 Jean-Michel Lemieux CLA 2004-05-04 10:19:19 EDT
Thanks for the patch. But this only solves part of the problem since currently
apply patch doesn't allow multi-select. We won't be able to fix this for 3.0.
Comment 11 Michael Valenta CLA 2004-08-16 15:30:02 EDT
*** Bug 70959 has been marked as a duplicate of this bug. ***
Comment 12 Michael Valenta CLA 2005-02-22 12:32:57 EST
*** Bug 85760 has been marked as a duplicate of this bug. ***
Comment 13 Michael Valenta CLA 2005-05-24 09:24:17 EDT
*** Bug 96249 has been marked as a duplicate of this bug. ***
Comment 14 Michael Valenta CLA 2005-05-26 10:03:28 EDT
*** Bug 96715 has been marked as a duplicate of this bug. ***
Comment 15 Michael Valenta CLA 2005-05-26 10:41:02 EDT
*** Bug 96790 has been marked as a duplicate of this bug. ***
Comment 16 Aaron Luchko CLA 2005-07-18 12:25:57 EDT
Would Bug 103871 work as a solution to this problem?
Comment 17 Matthew Conway CLA 2005-08-04 07:17:52 EDT
It would - the only case where it would fail would be to in creating a patch that spans projects.  But I 
guess in that case, one could always run "Create Patch" foir each project.
Comment 18 Gunnar Wagenknecht CLA 2005-08-04 07:46:19 EDT
See my comments in bub 103871 comment 3. I think the multi-selection can be used
to prepopulate the wizard page that is requested there.
Comment 19 Bogdan Gheorghe CLA 2005-09-23 10:30:00 EDT
Created attachment 27440 [details]
Create Patch zip
Comment 20 Bogdan Gheorghe CLA 2005-09-23 10:30:36 EDT
Here's a patch for the workspace patcher. Main changes made to the current
patching mechanism are as follows:

Create Patch
- Allows multiple selections of elements
- Preview page for changes contained in patch (also allows for selection of
patch contents)
- Patches can now be rooted at the workspace level, the project level or the
selection level

Apply Patch
- Wizard guides users to appropriate pages based on patch type
- Allows users to retarget workspace patches for projects that don't exist in
current workspace

To activate workspace patch, you have to pass in the following VM arg on startup:

-DworkspacePatch=true 

Comment 21 Bogdan Gheorghe CLA 2005-09-23 10:31:59 EDT
Created attachment 27441 [details]
Apply Patch zip
Comment 22 Bogdan Gheorghe CLA 2005-09-23 11:17:19 EDT
Created attachment 27442 [details]
Create Patch zip
Comment 23 Bogdan Gheorghe CLA 2005-09-23 11:17:47 EDT
Created attachment 27444 [details]
Apply Patch zip
Comment 24 Michael Valenta CLA 2005-10-14 21:17:38 EDT
This fix was released.
Comment 25 Michael Valenta CLA 2005-11-01 09:35:18 EST
Verified with some minor problems found (see bug 114517)
Comment 26 Bogdan Gheorghe CLA 2005-11-29 16:06:21 EST
*** Bug 118499 has been marked as a duplicate of this bug. ***
Comment 27 Andrew Overholt CLA 2005-12-22 19:43:54 EST
How difficult would it be for us to back-port this to 3.1.x?  I ask because we were looking into doing just this today but it would be great if we could take this work that's been done and include it in our packages for Fedora :)

What needs to be changed other than org.eclipse.compare?

Thanks,

Andrew
Comment 28 Michael Valenta CLA 2005-12-23 10:39:08 EST
There were quite a few changes in CVS since we also added the ability to perform the create patch in the background. I think they are localized to a few classes but, unfortunately, my development workstation just died so I can't give you the exact class names. You shoudl be able to see what changed by trying to port the 'Create Patch' wizard and then see what additional classes are referenced.