Bug 103871 - "Create Patch" should offer a Verify Patch step
Summary: "Create Patch" should offer a Verify Patch step
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.2 M3   Edit
Assignee: Bogdan Gheorghe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 41340
Blocks:
  Show dependency tree
 
Reported: 2005-07-14 14:09 EDT by Aaron Luchko CLA
Modified: 2005-11-01 09:48 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Luchko CLA 2005-07-14 14:09:00 EDT
Currently if you wish to make a patch for a single file in a directory, from the
perspective of that directory, it's impossible to do so without including any
other files you've changed in the directory in the patch.

For instance if I'm working on a project
foo/
    bar/
        A.java
        B.java
        C.java

and I've altered all three files but only wish to make a patch for A.java and
B.java which is appliable from the foo/ directory there is no way to do so.
Adding a "verify patch" similar to one used for "Apply Patch" would solve this
problem by allowing me to deselect C.java. Also a "Strip leading path name
segments" option similar to "Ignore leading path name segments" would offer a
solution to bug 41340 as well.
Comment 1 Markus Keller CLA 2005-07-18 13:13:02 EDT
I personally only ever want to create patches whose paths start at the topmost
(project) level. IMO, this should be the default. Since we already have "Ignore
leading path name segments", the "Strip leading path name segments" would not
even be necessary.
Comment 2 Aaron Luchko CLA 2005-07-18 13:25:19 EDT
(In reply to comment #1)
> I personally only ever want to create patches whose paths start at the topmost
> (project) level. IMO, this should be the default.

Same here, that's the main reason I suggested this patch. Right now the only way
to get a patch at the topmost level generates a patch for every altered file
within that project (which it not always what one wants).

> Since we already have "Ignore
> leading path name segments", the "Strip leading path name segments" would not
> even be necessary.

Yeah, that was just me suggesting a slightly different name for that
functionality which in hindsight was kinda pointless, just keep it as "Ignore" :)
Comment 3 Gunnar Wagenknecht CLA 2005-08-04 07:43:35 EDT
Indeed it would be nice if someone can exclude specific files/folders from a
project wide patch. I think the word "verify" in the summary is misleading. What
you really want is a page in the Create Patch wizard that allows to customize
the files/folders, which should be included in the patch.
Comment 4 Bogdan Gheorghe CLA 2005-09-23 10:35:05 EDT
This is addressed by the new Create Patch wizard.
Comment 5 Michael Valenta CLA 2005-10-14 21:33:39 EDT
Fixed
Comment 6 Michael Valenta CLA 2005-11-01 09:48:38 EST
Verified