Community
Participate
Working Groups
This bug is to track work related to getting a WTP build working with CBI. Discussion Thread: http://dev.eclipse.org/mhonarc/lists/cbi-dev/msg01020.html
Created attachment 233162 [details] webtools.common.patch Patch for webtools.common, all modules are buildable with CBI.
(In reply to comment #1) > Created attachment 233162 [details] > webtools.common.patch > > Patch for webtools.common, all modules are buildable with CBI. build.properties for the following files had to be modified to correctly create source bundles. docs/org.eclipse.wst.validation.infopop/build.properties plugins/org.eclipse.wst.common.infopop/build.properties
Created attachment 233163 [details] webtools.common.fproj.patch Patch for webtools.common.fproj, all modules are buildable with CBI.
Created attachment 233164 [details] webtools.common.snippets.patch Patch for webtools.common.snippets, all modules are buildable with CBI.
Created attachment 233165 [details] webtools.common.tests.patch Patch for webtools.common.tests, all modules are buildable with CBI. One bundle needed it's MANIFEST.MF file updated to include ".qualifier" in it's version: org.eclipse.wst.common.tests.collector
Created attachment 233166 [details] webtools.dali.patch Patch for webtools.dali, not yet buildable due to issue described in bug 412468. This patch is currently blocked on this issue. Initial poms created for all bundles but are untested due to bug 412468. jpa_diagram_editor appears to already use CBI to build and has it's own parent so this patch did not touch those bundles.
Created attachment 233168 [details] webtools.ejb.patch Patch for webtools.ejb, all modules except one are buildable with CBI. The module org.eclipse.jst.j2ee.ejb.generation.tests fails to build due to issue described in bug 412467 which is blocking the completion of this patch.
Created attachment 233169 [details] webtools.javaee.patch Patch for webtools.javaee, all modules are buildable with CBI except for 3 features. Unbuildable features: org.eclipse.jst.web_sdk.feature org.eclipse.jst.web_ui.feature org.eclipse.jst.web_ui.feature.patch These features are blocked on bug 412462 due to org.eclipse.wst.wsdl.ui running into a compile error. A few non-pom files needed to be modified as follows: build.properties updated to include src.includes (required for Tycho): - org.eclipse.jst.j2ee.infopop feature.xml missing version ".qualifier": - org.eclipse.jst.enterprise_core.feature.patch - org.eclipse.jst.enterprise_ui.feature.patch - org.eclipse.jst.servlet.ui.patch
Created attachment 233170 [details] webtools.javaee.tests.patch Patch for webtools.common, most modules are buildable with CBI. Unbuildable modules: - org.eclipse.jst.j2ee.core.tests.performance - org.eclipse.jst.j2ee.tests.performance These modules are blocked due to bug 412465 because org.eclipse.jst.j2ee.tests.performance is missing a MANIFEST.MF file. Also 3 non-pom related modifications were made due to missing version ".qualifier" for the following bundles (in plugin.xml or MANIFEST.MF): - org.eclipse.jst.j2ee.core.tests.performance - org.eclipse.jst.j2ee.tests.performance - org.eclipse.jst.validation.sample
Created attachment 233171 [details] webtools.jsdt.core.patch Patch for webtools.jsdt.core, all modules are buildable with CBI. Also build.properties for org.eclipse.wst.jsdt.doc was modified to add "src.includes" (needed for Tycho).
Created attachment 233172 [details] webtools.jsdt.debug.patch Patch for webtools.jsdt.debug, all modules are buildable with CBI
Created attachment 233173 [details] webtools.jsdt.tests.patch Patch for webtools.jsdt.tests, all modules are buildable with CBI
Created attachment 233174 [details] webtools.jsf.patch Patch for webtools.jsf, all modules are buildable with CBI
Created attachment 233175 [details] webtools.jsf.docs.patch Patch for webtools.jsf.docs, all modules are buildable with CBI
Created attachment 233176 [details] webtools.jsf.tests.patch Patch for webtools.jsf.tests, all modules are buildable with CBI
Created attachment 233177 [details] webtools.releng.patch Patch for webtools.releng, several modules are not buildable due to duplicate ID or missing bundles. I've documented them in comments inside the root pom.xml. I'm not entirely sure if some of these modules should be built or not. One feature.xml from org.eclipse.wtp.xml.dev.assembly.feature was modified to add a missing ".qualifier" to the version.
Created attachment 233178 [details] webtools.servertools.patch Patch for webtools.servertools, all modules except one are buildable with CBI. The module org.eclipse.jst.server.pde is blocked due to bug 412464 which appears to be dependent on some older versions of PDE UI which I'm unable to find.
Created attachment 233179 [details] webtools.servertools.docs.patch Patch for webtools.servertools.docs, all modules are buildable with CBI. build.properties for the following bundles needed to be modified to include "src.includes" (required for Tycho to build source bundles). - org.eclipse.jst.server.ui.infopop - org.eclipse.wst.server.ui.infopop
Created attachment 233180 [details] webtools.servertools.tests.patch Patch for webtools.servertools.tests, all modules are buildable with CBI
Created attachment 233181 [details] webtools.sourceediting.patch Patch for webtools.sourceediting.patch, all modules except one are buildable with CBI. The feature org.eclipse.wst.web_sdk.feature is not buildable and is blocked by bug 412462. The following build.properties were modified to include "src.includes" (needed by Tycho to build source bundles): docs/org.eclipse.jst.jsp.ui.infopop/build.properties docs/org.eclipse.wst.doc.user/build.properties docs/org.eclipse.wst.dtd.ui.infopop/build.properties docs/org.eclipse.wst.html.ui.infopop/build.properties docs/org.eclipse.wst.sse.ui.infopop/build.properties docs/org.eclipse.wst.xml.ui.infopop/build.properties The following feature.xml files were modified to add a missing version ".qualifier". features/org.eclipse.wst.xml_ui.feature.patch/feature.xml
Created attachment 233182 [details] webtools.sourceediting.tests.patch Patch for webtools.sourceediting.tests, all modules are buildable with CBI
Created attachment 233183 [details] webtools.sourceediting.xpath.patch Patch for webtools.sourceediting.xpath, all modules are buildable with CBI. *** This patch needs a closer look. I copied over my initial work from last year and it looks like it overwrote some poms that now exist. Need to determine what is useful between the 2 poms and merge them together. It looks like the existing poms in the repo also point to a relative parent pom "../../development/athena/org.eclipse.wst.xml.xpath2.releng" which I'm not sure where it comes from. Finally the build.properties for org.eclipse.wst.xml.xpath2 was modified to include "src.includes" which is needed for Tycho to generate source bundles.
Created attachment 233184 [details] webtools.sourceediting.xpath.tests.patch Patch for webtools.sourceediting.xpath.tests, all modules are buildable with CBI
(In reply to comment #23) > Created attachment 233184 [details] > webtools.sourceediting.xpath.tests.patch > > Patch for webtools.sourceediting.xpath.tests, all modules are buildable with > CBI *** Should take a closer look at this patch too. Looks like my patches from last year overwrote some poms that now exist in the repo. Some modules point to a parent pom "../../development/athena/org.eclipse.wst.xml.xpath2.releng" which I'm not sure where it comes from.
Created attachment 233185 [details] webtools.sourceediting.xsl.patch Patch for webtools.sourceediting.xsl, all modules are buildable with CBI. *** Need to take a closer look at this patch, it seems copying over my work from last year overwrote some poms that now exist in the repo. Need to determine what can be merged between the 2 poms. Also build.properties for the following 2 modules were modified to include "src.includes" which is needed by Tycho to generate source bundles. - org.eclipse.wst.xsl - org.eclipse.wst.xsl.doc
Created attachment 233186 [details] webtools.sourceediting.xsl.tests.patch Patch for webtools.sourceediting.xsl.tests, all modules are buildable with CBI. *** Should take a closer look at this patch. It looks like the work I copied over from last year overwrites some poms that now exist in this repo. Need to determine what can be merged.
Created attachment 233187 [details] webtools.webservices.patch Patch for webtools.webservices, most modules are buildable with CBI. Some modules blocked by bug 412462 due to org.eclipse.wst.wsdl.ui having compile issues. The following build.properties were modified to include "src.includes" which Tycho needs to build source bundles. bundles/org.eclipse.jst.ws.creation.ejb.ui/build.properties docs/org.eclipse.jst.ws.axis.infopop/build.properties docs/org.eclipse.jst.ws.consumption.infopop/build.properties docs/org.eclipse.jst.ws.infopop/build.properties docs/org.eclipse.wst.command.env.infopop/build.properties docs/org.eclipse.wst.ws.infopop/build.properties
Created attachment 233188 [details] webtools.webservices.axis2.patch Patch for webtools.webservices.axis2, all modules are buildable with CBI. The MANIFEST.MF for org.eclipse.jst.ws.axis2.tests.performance was modified to add missing version ".qualifier".
Created attachment 233189 [details] webtools.webservices.jaxws.patch Patch for webtools.webservices.jaxws, all modules are buildable with CBI. The following build.properties were modified to include "src.includes" which is needed for Tycho to generate source bundles. docs/org.eclipse.jst.ws.cxf.doc.user/build.properties docs/org.eclipse.jst.ws.jaxws.doc.user/build.properties
Created attachment 233190 [details] webtools.releng.aggregator.patch This is the initial commit for a new repo webtools.releng.aggregator. Currently webtools.dali submodule is commented out of the root pom due to build issues related to bug 412468.
Created attachment 233212 [details] webtools.releng.aggregator.patch v2 Fixed issue with undeclared extra repository causing warnings.
Created attachment 233244 [details] webtools.servertools.patch v2 (In reply to comment #17) > Created attachment 233178 [details] > webtools.servertools.patch > > Patch for webtools.servertools, all modules except one are buildable with > CBI. > > The module org.eclipse.jst.server.pde is blocked due to bug 412464 which > appears to be dependent on some older versions of PDE UI which I'm unable to > find. Turns out this module isn't needed. I added a comment to the pom.xml file linking to the bug for tracking.
Created attachment 233246 [details] webtools.ejb.patch v2 (In reply to comment #7) > Created attachment 233168 [details] > webtools.ejb.patch > > Patch for webtools.ejb, all modules except one are buildable with CBI. > > The module org.eclipse.jst.j2ee.ejb.generation.tests fails to build due to > issue described in bug 412467 which is blocking the completion of this patch. Per bug 412467 this bundle does not need to be built.
Created attachment 233251 [details] webtools.webservices.patch v2 (In reply to comment #27) > Created attachment 233187 [details] > webtools.webservices.patch > > Patch for webtools.webservices, most modules are buildable with CBI. > > Some modules blocked by bug 412462 due to org.eclipse.wst.wsdl.ui having > compile issues. > > The following build.properties were modified to include "src.includes" which > Tycho needs to build source bundles. > > bundles/org.eclipse.jst.ws.creation.ejb.ui/build.properties > docs/org.eclipse.jst.ws.axis.infopop/build.properties > docs/org.eclipse.jst.ws.consumption.infopop/build.properties > docs/org.eclipse.jst.ws.infopop/build.properties > docs/org.eclipse.wst.command.env.infopop/build.properties > docs/org.eclipse.wst.ws.infopop/build.properties Fixed issue with bug 412462.
Created attachment 233252 [details] webtools.javaee.patch v2 (In reply to comment #8) > Created attachment 233169 [details] > webtools.javaee.patch > > Patch for webtools.javaee, all modules are buildable with CBI except for 3 > features. > > Unbuildable features: > > org.eclipse.jst.web_sdk.feature > org.eclipse.jst.web_ui.feature > org.eclipse.jst.web_ui.feature.patch > > These features are blocked on bug 412462 due to org.eclipse.wst.wsdl.ui > running into a compile error. > > > A few non-pom files needed to be modified as follows: > > build.properties updated to include src.includes (required for Tycho): > > - org.eclipse.jst.j2ee.infopop > > > feature.xml missing version ".qualifier": > > - org.eclipse.jst.enterprise_core.feature.patch > - org.eclipse.jst.enterprise_ui.feature.patch > - org.eclipse.jst.servlet.ui.patch Fixed issue with bug 412462.
Created attachment 233253 [details] webtools.releng.patch v2 (In reply to comment #16) > Created attachment 233177 [details] > webtools.releng.patch > > Patch for webtools.releng, several modules are not buildable due to > duplicate ID or missing bundles. I've documented them in comments inside the > root pom.xml. > > I'm not entirely sure if some of these modules should be built or not. > > One feature.xml from org.eclipse.wtp.xml.dev.assembly.feature was modified > to add a missing ".qualifier" to the version. Fixed issue with bug 412462.
Created attachment 233254 [details] webtools.sourceediting.patch v2 (In reply to comment #20) > Created attachment 233181 [details] > webtools.sourceediting.patch > > Patch for webtools.sourceediting.patch, all modules except one are buildable > with CBI. > > The feature org.eclipse.wst.web_sdk.feature is not buildable and is blocked > by bug 412462. > > The following build.properties were modified to include "src.includes" > (needed by Tycho to build source bundles): > docs/org.eclipse.jst.jsp.ui.infopop/build.properties > docs/org.eclipse.wst.doc.user/build.properties > docs/org.eclipse.wst.dtd.ui.infopop/build.properties > docs/org.eclipse.wst.html.ui.infopop/build.properties > docs/org.eclipse.wst.sse.ui.infopop/build.properties > docs/org.eclipse.wst.xml.ui.infopop/build.properties > > The following feature.xml files were modified to add a missing version > ".qualifier". > features/org.eclipse.wst.xml_ui.feature.patch/feature.xml Fixed issue with bug 412462.
Created attachment 233255 [details] webtools.jsf.docs.patch v2 (In reply to comment #14) > Created attachment 233175 [details] > webtools.jsf.docs.patch > > Patch for webtools.jsf.docs, all modules are buildable with CBI Fixed issue with bug 412462 and discovered that I needed to patch build.properties for the following 2 plugins to add "src.includes" which Tycho needs to generate source plugins. plugins/org.eclipse.jst.jsf.doc.dev/build.properties plugins/org.eclipse.jst.jsf.doc.user/build.properties
Created attachment 233573 [details] webtools.webservices.patch v3 (In reply to comment #34) > Created attachment 233251 [details] > webtools.webservices.patch v2 > > (In reply to comment #27) > > Created attachment 233187 [details] > > webtools.webservices.patch > > > > Patch for webtools.webservices, most modules are buildable with CBI. > > > > Some modules blocked by bug 412462 due to org.eclipse.wst.wsdl.ui having > > compile issues. > > > > The following build.properties were modified to include "src.includes" which > > Tycho needs to build source bundles. > > > > bundles/org.eclipse.jst.ws.creation.ejb.ui/build.properties > > docs/org.eclipse.jst.ws.axis.infopop/build.properties > > docs/org.eclipse.jst.ws.consumption.infopop/build.properties > > docs/org.eclipse.jst.ws.infopop/build.properties > > docs/org.eclipse.wst.command.env.infopop/build.properties > > docs/org.eclipse.wst.ws.infopop/build.properties > > Fixed issue with bug 412462. Added workaround for bug 413198
Created attachment 233574 [details] webtools.dali.patch v2 (In reply to comment #6) > Created attachment 233166 [details] > webtools.dali.patch > > Patch for webtools.dali, not yet buildable due to issue described in bug > 412468. This patch is currently blocked on this issue. Initial poms created > for all bundles but are untested due to bug 412468. > > jpa_diagram_editor appears to already use CBI to build and has it's own > parent so this patch did not touch those bundles. Builds everything except for org.eclipse.jpt.jpadiagrameditor.ui.tests. Bug 413196 was opened for this issue.
Created attachment 233593 [details] webtools.dali.patch v3 (In reply to comment #40) > Created attachment 233574 [details] > webtools.dali.patch v2 > > (In reply to comment #6) > > Created attachment 233166 [details] > > webtools.dali.patch > > > > Patch for webtools.dali, not yet buildable due to issue described in bug > > 412468. This patch is currently blocked on this issue. Initial poms created > > for all bundles but are untested due to bug 412468. > > > > jpa_diagram_editor appears to already use CBI to build and has it's own > > parent so this patch did not touch those bundles. > > Builds everything except for org.eclipse.jpt.jpadiagrameditor.ui.tests. Bug > 413196 was opened for this issue. Now builds org.eclipse.jpt.jpadiagrameditor.ui.tests.
Created attachment 233594 [details] webtools.sourceediting.xpath v2 (In reply to comment #22) > Created attachment 233183 [details] > webtools.sourceediting.xpath.patch > > Patch for webtools.sourceediting.xpath, all modules are buildable with CBI. > > *** This patch needs a closer look. I copied over my initial work from last > year and it looks like it overwrote some poms that now exist. Need to > determine what is useful between the 2 poms and merge them together. > > It looks like the existing poms in the repo also point to a relative parent > pom "../../development/athena/org.eclipse.wst.xml.xpath2.releng" which I'm > not sure where it comes from. > > > Finally the build.properties for org.eclipse.wst.xml.xpath2 was modified to > include "src.includes" which is needed for Tycho to generate source bundles. Fixed (In reply to comment #22) > Created attachment 233183 [details] > webtools.sourceediting.xpath.patch > > Patch for webtools.sourceediting.xpath, all modules are buildable with CBI. > > *** This patch needs a closer look. I copied over my initial work from last > year and it looks like it overwrote some poms that now exist. Need to > determine what is useful between the 2 poms and merge them together. > > It looks like the existing poms in the repo also point to a relative parent > pom "../../development/athena/org.eclipse.wst.xml.xpath2.releng" which I'm > not sure where it comes from. > > > Finally the build.properties for org.eclipse.wst.xml.xpath2 was modified to > include "src.includes" which is needed for Tycho to generate source bundles. Merged my work with the existing work.
Created attachment 233595 [details] webtools.sourceediting.xpath.tests.patch v2 (In reply to comment #24) > (In reply to comment #23) > > Created attachment 233184 [details] > > webtools.sourceediting.xpath.tests.patch > > > > Patch for webtools.sourceediting.xpath.tests, all modules are buildable with > > CBI > > *** Should take a closer look at this patch too. Looks like my patches from > last year overwrote some poms that now exist in the repo. Some modules point > to a parent pom "../../development/athena/org.eclipse.wst.xml.xpath2.releng" > which I'm not sure where it comes from. Merged my poms with the existing ones.
Created attachment 233596 [details] webtools.sourceediting.xsl.patch v2 (In reply to comment #26) > Created attachment 233186 [details] > webtools.sourceediting.xsl.tests.patch > > Patch for webtools.sourceediting.xsl.tests, all modules are buildable with > CBI. > > *** Should take a closer look at this patch. It looks like the work I copied > over from last year overwrites some poms that now exist in this repo. Need > to determine what can be merged. Merged my work with the existing poms.
Created attachment 233597 [details] webtools.sourceediting.xsl.tests.patch v2 (In reply to comment #26) > Created attachment 233186 [details] > webtools.sourceediting.xsl.tests.patch > > Patch for webtools.sourceediting.xsl.tests, all modules are buildable with > CBI. > > *** Should take a closer look at this patch. It looks like the work I copied > over from last year overwrites some poms that now exist in this repo. Need > to determine what can be merged. Merged my work with the existing poms.
Created attachment 233598 [details] webtools.releng.aggregator.patch v3 Update the aggregator.
Created attachment 233599 [details] webtools.webservices.patch v4 Removed workaround for BREE.
Created attachment 233761 [details] webtools.sourceediting.patch v3 (In reply to comment #37) > Created attachment 233254 [details] > webtools.sourceediting.patch v2 > > (In reply to comment #20) > > Created attachment 233181 [details] > > webtools.sourceediting.patch > > > > Patch for webtools.sourceediting.patch, all modules except one are buildable > > with CBI. > > > > The feature org.eclipse.wst.web_sdk.feature is not buildable and is blocked > > by bug 412462. > > > > The following build.properties were modified to include "src.includes" > > (needed by Tycho to build source bundles): > > docs/org.eclipse.jst.jsp.ui.infopop/build.properties > > docs/org.eclipse.wst.doc.user/build.properties > > docs/org.eclipse.wst.dtd.ui.infopop/build.properties > > docs/org.eclipse.wst.html.ui.infopop/build.properties > > docs/org.eclipse.wst.sse.ui.infopop/build.properties > > docs/org.eclipse.wst.xml.ui.infopop/build.properties > > > > The following feature.xml files were modified to add a missing version > > ".qualifier". > > features/org.eclipse.wst.xml_ui.feature.patch/feature.xml > > Fixed issue with bug 412462. Rebased patch to pull in fix from bug 412459.
Created attachment 233762 [details] webtools.sourceediting.patch v4 Fix typo in pom.xml.
I assume WTP has successfully been ported to use CBI. Please re-open if something is mssing.
(In reply to Frederic Gurr from comment #50) > I assume WTP has successfully been ported to use CBI. > > Please re-open if something is mssing. Frederic, The biggest issue with building WTP with CBI is our lack of automated tests - when Julio and Thanh ported the WTP build over to CBI, those were broken, and both of them moved on before fixing that issue -see bug 425148 . However, due to the lack of progress in this area (and the fact that WTP Releng was handed back to me, and there is just me to do it all), this bug can be closed.
Thanks for the feedback Carl. I can certainly take a look at the tests and offer assistance, but since time is scarce I can't promise a lot of help. Can you point me to any specific test problems that you need help with? (let's discuss this in bug 425148)
> The biggest issue with building WTP with CBI is our lack of automated tests This is no longer an issue as of WTP 3.10, but there are a lot of automated tests in JavaEE taht had to be disabled because they don't run and need updating to junit 5 / jdk 8 / tycho 1.1 / maven 3.5. * Bug 534057 - JavaEE - org.eclipse.jst.j2ee.tests tests disabled because failing * Bug 534553 - JavaEE - JEM tests not yet enabled
