Community
Participate
Working Groups
Created attachment 234234 [details] webtools.releng.patch Patch for webtools.releng, several modules are not buildable due to duplicate ID or missing bundles. I've documented them in comments inside the root pom.xml. I'm not entirely sure if some of these modules should be built or not. One feature.xml from org.eclipse.wtp.xml.dev.assembly.feature was modified to add a missing ".qualifier" to the version.
Created attachment 234235 [details] webtools.releng.aggregator.patch A new aggregator will need to be created. locally I called mine webtools.releng.aggregator.git but any alternative names can be used if there is a preference. As a note, the aggregator does not yet include profiles for signing the build with Eclipse infrastructure. We should add this once the patches are merged and we can test against the repos.
Carl, Looks like this is the last of the patches to be merged. I guess after webtools.releng.patch gets merged we will need to create a webtools.releng.aggregator repo somewhere. Should I go ahead and create a new repo for this under /gitroot/webtools?
I had problems applying the following changes: features/org.eclipse.jst.doc.isv.feature/pom.xml (this feature lives in webtools.javaee now - neither are currently built) features/org.eclipse.wtp.package.jee.feature/pom.xml (this feature has the same id as org.eclipse.wtp.jee.feature - not part of the WTP build, this is EPP support) plugins/org.eclipse.javaee.intro/pom.xml (this plugin has the same id as org.eclipse.wtp.epp.package.jee.intro - not part of the WTP build, this is EPP support) plugins/org.eclipse.wtp.jee.intro/pom.xml (this plugin has the same id as org.eclipse.wtp.intro - not part of the WTP build, this is EPP support) plugins/org.eclipse.wtp.package.jee/pom.xml (this plugin has the same id as org.eclipse.wtp.jee - not part of the WTP build, this is EPP support) Since we do not build/ship these as part of WTP 3.6, I did not worry about adding their pom files.
(In reply to Carl Anderson from comment #3) > I had problems applying the following changes: > > features/org.eclipse.jst.doc.isv.feature/pom.xml (this feature lives in > webtools.javaee now - neither are currently built) > > features/org.eclipse.wtp.package.jee.feature/pom.xml (this feature has the > same id as org.eclipse.wtp.jee.feature - not part of the WTP build, this is > EPP support) > > plugins/org.eclipse.javaee.intro/pom.xml (this plugin has the same id as > org.eclipse.wtp.epp.package.jee.intro - not part of the WTP build, this is > EPP support) > > plugins/org.eclipse.wtp.jee.intro/pom.xml (this plugin has the same id as > org.eclipse.wtp.intro - not part of the WTP build, this is EPP support) > > plugins/org.eclipse.wtp.package.jee/pom.xml (this plugin has the same id as > org.eclipse.wtp.jee - not part of the WTP build, this is EPP support) > > Since we do not build/ship these as part of WTP 3.6, I did not worry about > adding their pom files. Yes if they are not used in the build I would just leave them out. I created poms for everything simply because I did not know what should / is built.
Thanh, please apply the webtools.releng.aggregator.patch. I am frustrated with my inability to do so with EGit.
(In reply to Carl Anderson from comment #5) > Thanh, please apply the webtools.releng.aggregator.patch. I am frustrated > with my inability to do so with EGit. Hi Carl, It just occurred to me that I wouldn't be able to do this since I'm not a committter. Would it make sense if I became a committer for wtp releng? or do we have other options?
(In reply to Carl Anderson from comment #5) > Thanh, please apply the webtools.releng.aggregator.patch. I am frustrated > with my inability to do so with EGit. And why is that? When I look, webtools.releng.aggregator is empty. If that is the case, then a "patch" is not appropriate form ... should be just a set of files to "share". Which would become the initial contents.
(In reply to David Williams from comment #7) > (In reply to Carl Anderson from comment #5) > > Thanh, please apply the webtools.releng.aggregator.patch. I am frustrated > > with my inability to do so with EGit. > > And why is that? When I look, webtools.releng.aggregator is empty. > If that is the case, then a "patch" is not appropriate form ... should be > just a set of files to "share". Which would become the initial contents. I'm not sure how Egit handles it but the patch works with commandline git. I just cloned the empty repo and ran: git am webtools.releng.aggregator.patch I will try attaching a zip of the repo I produced that contains all the files in case that helps.
Created attachment 236610 [details] aggregator.zip
I've shoe-horned something into the repository ... not sure it's quite right ... but maybe now that its none-empty more progress could be made. Good luck!
(In reply to David Williams from comment #10) > I've shoe-horned something into the repository ... not sure it's quite right > ... but maybe now that its none-empty more progress could be made. > > Good luck! Thanks David, Looks like my patches are there now. I will test and make sure they still work as expected.
I believe that David handled this request. (Thanks!) If there is something left to do, please reopen this bug.
(In reply to Carl Anderson from comment #12) > I believe that David handled this request. (Thanks!) If there is something > left to do, please reopen this bug. Yes this one's done we still need the patches from bug 419265 though.
