Community
Participate
Working Groups
Created attachment 234208 [details] webtools.common.fproj.patch Patch for webtools.common.fproj, all modules are buildable with CBI.
I am not sure about the change to org.eclipse.wst.common.fproj.feature.patch - that is a feature patch used for patching a feature after a release, and should not be part of the normal WTP build.
(In reply to Carl Anderson from comment #1) > I am not sure about the change to org.eclipse.wst.common.fproj.feature.patch > - that is a feature patch used for patching a feature after a release, and > should not be part of the normal WTP build. Should I create a new patch that excludes it from building? To exclude it from a regular build we simply need to remove the module declaration in the repo root pom.xml file. We could leave the bundle pom.xml existing in case someone needs to build the patch via cbi too. As long as the root pom does not include it, it won't be built.
I went ahead and committed all of the changes. I believe that we should go back and remove the two .feature.patch entries from the root pom.xml, but for now I will leave it as is, to get the CBI build working. Is there a way to comment out that line in a pom.xml? Also, I copied the .gitignore from webtools.common.tests, since it is much more complete.
(In reply to Carl Anderson from comment #3) > I went ahead and committed all of the changes. I believe that we should go > back and remove the two .feature.patch entries from the root pom.xml, but > for now I will leave it as is, to get the CBI build working. > > Is there a way to comment out that line in a pom.xml? > > Also, I copied the .gitignore from webtools.common.tests, since it is much > more complete. Yes it's just standard xml so you can add a comment with: <!-- single line comment --> or <!-- multi line comment -->
