Community
Participate
Working Groups
After opening the compare editor, duplicate inline comments are shown and the number of duplicates increases over time.
Created attachment 232361 [details] screenshot
I have only seen this with one review so far, but it happens consistenly, although sometimes it takes a minute after opening before the duplicates start appearing. Once or twice, I saw 2 copies of a draft comment where one had my name and the other had someone else's.
Is that the same as bug 410675?
(In reply to comment #3) > Is that the same as bug 410675? No, it's actually happening in the popup. My guess is that it's actually similar issue to bug 410532 and may be solved by bug 410673.
Merged: https://git.eclipse.org/r/#/c/13829/ (The user issue does indeed appear to be the culprit here.)
I just saw this again running on 70b66a7e31cca2979b802a231be70b231a283892
(In reply to comment #6) > I just saw this again running on 70b66a7e31cca2979b802a231be70b231a283892 :( This can only happen if the repository user changes somehow. The regression must have been introduced by some kind of change to the way accounts are handled or initialized. I'll take a look. Did you make any configuration changes proximate to when you observed this?
No, but it started happening again after I updated to the latest master. I have seen it 2 or 3 times since I did that.
(In reply to comment #8) > No, but it started happening again after I updated to the latest master. I have > seen it 2 or 3 times since I did that. Were these your reviews or someone else's? Were you a reviewer on those reviews initially? (I'm still not able to reproduce this.)
I've seen it on reviews where I'm a reviewer.
I saw this once recently, too. I don't recall anything particular about the review.
I'm not really sure how to move forward on this one, frankly. I don't have any theories about why it might be happening.
It wonder if it's caused by hovering over the glasses icon, as it seems that that sometimes increases the number of duplicates.
(In reply to comment #13) > It wonder if it's caused by hovering over the glasses icon, as it seems that > that sometimes increases the number of duplicates. Good thought. I'll try that out.
I'm still seeing this regularly...
I have a possible explanation here. I noticed that in some cases, the model object for a comment user is not the same model object as the Repository:Account user. We should ensure that those model objects are the same. Some UI functionality could be affected if this is not the case, such as comments not being seen as belonging to the same user as the repostiory author.
See bug 418878
Reassigning to default.
This is quite annoying. I would like to take a look at this for 2.2.
Is this behaviour triggered in specific reviews, or is the bug workspace dependent?
(In reply to comment #20) > Is this behaviour triggered in specific reviews, or is the bug workspace > dependent? I have seen this on various occasions in different workspaces. My suspicion is that the model update runs multiple times and adds the same comments multiple times to the model on refresh.
I don't think this is associated with specific reviews, but I have noticed that it tends to happen with multiple comments at the same time, i.e. sometimes I open a review for the first and find many of the comments get duplicated, and other times none of them do.
The way to reproduce this is to open a compare editor with comments, then while the compare editor is open, refresh the review.
I've submitted a changeset at https://git.eclipse.org/r/#/c/20632/. It seems that whenever a comparison editor is open, if review gets pulled (ie editor refresh) then the annotation model for the comparison editor is populated with additional comments. Ideally, the Comment would implement equality, but since I'm not familiar with EMF generated models, I added some additional equality checks to CommentAnnotation. Please review.
The fix has been merged. Thanks very much for the contribution!
