Community
Participate
Working Groups
* with a review editor open, restart eclipse * close and reopen the editor * duplicate files are shown in the patch set section * repeat the process and get another set of duplicates
A workaround is to delete the <workspace>\.metadata\.mylyn\reviews_xml\org.eclipse.mylyn.gerrit-<repository_url>-\Review\<review_id>.reviews file to remove the duplciates for the affected review.
https://git.eclipse.org/r/#/c/13784/ This is in some sense a quick fix, because I while it isn't really specified by API we probably shouldn't be calling createModel after the model exists, and we are in this instance.
I have also been able to reproduce this without restarting, by deletin gthe .reviews file while the review is open and then refreshing the editor.
(In reply to comment #3) > I have also been able to reproduce this without restarting, by deletin gthe > .reviews file while the review is open and then refreshing the editor. Yeah, that makes sense. What's happening there is that the file is still in memory, but then it gets rebuilt, causing create model to be called. After thinking it through, the overall framework is working correctly -- you need to force a creation pass at this point, and the fix that I've made is correct -- you shouldn't assume that at create time you wouldn't already have the model. (This is an issue only with EMF lists; with regular objects you're just recreating the model object so it doesn't matter.) Anyway, the fix above should take care of it. Can you confirm that, Sam?
This seems to be fixed now.
Great. I think we're starting to win this game of Whack-A-Mole.
Miles, please assign tasks to the person who completed the majority of the work when resolving them.
*** Bug 411180 has been marked as a duplicate of this bug. ***
