Community
Participate
Working Groups
Currently, we don't actually have a place in the model to store the IDE users (e.g. Gerrit repos login) information. We need that..
Can you elaborate why that is needed? The user is already stored in the TaskRepository instance.
The user isn't really stored in Task Repository, just the user name, etc.. What we need here is a link to a *model* User, that we can then use to determine e.g. "the local user is the same one as the commentor on this bug". Now, yeah, we could walk through all of the users and find the one that matches the user (but it may not even exist!), but this way is much more direct.
(In reply to comment #2) > The user isn't really stored in Task Repository, just the user name, etc.. What > we need here is a link to a *model* User, that we can then use to determine e.g. > "the local user is the same one as the commentor on this bug". Now, yeah, we > could walk through all of the users and find the one that matches the user (but > it may not even exist!), but this way is much more direct. Yes, but was I trying to point is that this information is already stored in the task repository and can change to you have to ensure the model stays in sync.
(In reply to comment #3) > Yes, but was I trying to point is that this information is already stored in the > task repository and can change to you have to ensure the model stays in sync. Right, but I think we have to favor the gerrit supplied information. If we're matching on the task repository information that probably creates more edge cases than matching on what the Gerrit connection is using. (Hopefully these will always be the same thing if we have a current configuration!). In the case where say the user changes their email, you need to match against the Gerrit account ID, which is an int.
https://git.eclipse.org/r/#/c/13829/
Steffen, I'm having the URL Handler Test issue crop up again. See https://hudson.eclipse.org/sandbox/job/mylyn-reviews-gerrit/592/testReport/org.eclipse.mylyn.gerrit.tests.ui/GerritUrlHandlerTest/testOpenUrl/ I'm not sure how this particular change could have affected things except perhaps in that there might be a slight increase in load times. Any ideas about diagnosing this?
Merged https://git.eclipse.org/r/#/c/13829/
