Bug 370248 - Mark Indigo (3.7) Platform API for deletion in Juno (4.2)
Summary: Mark Indigo (3.7) Platform API for deletion in Juno (4.2)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: PMC (show other bugs)
Version: 3.7.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.2 M6   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 527665 440136 457134 476404
  Show dependency tree
 
Reported: 2012-01-31 11:59 EST by John Arthorne CLA
Modified: 2020-09-19 07:44 EDT (History)
7 users (show)

See Also:
john.arthorne: pmc_approved+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2012-01-31 11:59:53 EST
We should indicate future deletion of the Platform authorization API, as outlined in:

http://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process
Comment 1 John Arthorne CLA 2012-02-01 16:37:31 EST
Should also queue up the following API packages for deletion:

org.eclipse.core.boot
org.eclipse.core.runtime.model

These packages are still available in the bundle org.eclipse.core.runtime.compatibility. They provide API that has been obsolete since Eclipse 2.1. Any API that was still valid was moved elsewhere, such as org.eclipse.core.runtime.
Comment 2 John Arthorne CLA 2012-02-01 16:41:49 EST
Here is the descriptive blurb I wrote for the authorization APIs in the migration guide:

What is affected: Clients that call the following methods for storing and retrieving passwords in the platform keyring file:

 - Platform#addAuthorizationInfo
 - Platform#getAuthorizationInfo
 - Platform#flushAuthorizationInfo
 - Platform#addProtectionSpace
 - Platform#getProtectionSpace

Description: These APIs were deprecated and superseded by new API in the org.eclipse.equinox.security.storage package in Eclipse 3.4. These APIs made use of a custom encryption algorithm that caused problems for organizations distributing and exporting Eclipse-based products. The system was also inherently flawed due to relying on a password supplied on the command line that users never set.
Comment 3 John Arthorne CLA 2012-03-06 09:50:13 EST
The summary of APIs I think we should mark for future deletion:

Entire packages:

org.eclipse.core.boot
org.eclipse.core.runtime.model
org.eclipse.ui.presentations

Methods:

 - Platform#addAuthorizationInfo
 - Platform#getAuthorizationInfo
 - Platform#flushAuthorizationInfo
 - Platform#addProtectionSpace
 - Platform#getProtectionSpace

These are all cases of API that are no longer functional in 4.2. Even if we never deleted them in the future, indicating they are marked for future deletion is the clearest possible signal that clients should not be referring to these APIs.
Comment 4 John Arthorne CLA 2012-03-07 09:48:36 EST
For reference, here is the porting guide entry we have in 4.2 describing the state of the presentation API:

Description: The workbench presentation API allowed plug-ins to override certain aspects of the workbench appearance, such as the shape of view and editor tabs. This mechanism is fundamentally incompatible with the pluggable rendering and declarative styling systems in Eclipse 4.2, which offer applications complete control over all aspects of the workbench layout and style.

Action required: Using the presentation API and extension point to customize the workbench appearance will no longer have any effect. Clients are encouraged to try out the provisional new API in Eclipse 4.2 for performing equivalent workbench customization. Complete rendering control can be achieved by supplying an org.eclipse.e4.ui.workbench.IPresentationEngine. Customization of fonts, spacing, and color can be achieved by supplying custom CSS style sheets via the org.eclipse.e4.ui.css.swt.theme extension point. For more details see the <a href="http://wiki.eclipse.org/Eclipse4/RCP/CSS">Eclipse 4 CSS Styling</a> wiki page.
Comment 5 John Arthorne CLA 2012-03-07 13:12:24 EST
This was agreed to at the March 7, 2012 PMC call:

http://wiki.eclipse.org/Eclipse/PMC
Comment 8 Dani Megert CLA 2012-03-13 05:41:23 EDT
Shouldn't we also add this info to the 3.8 release for those moving from 3.x to 4.x?
Comment 9 John Arthorne CLA 2012-03-13 08:55:40 EDT
Sure, I have cherry-picked the porting guide change to master:

http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=d0640648778fcc43dfbfa176d7f3d425f0e87bbb
Comment 10 Eclipse Genie CLA 2020-09-17 10:26:28 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.runtime/+/169526
Comment 11 Eclipse Genie CLA 2020-09-19 07:44:25 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.runtime/+/169614