Bug 457134 - Mark IPlatformRunnable for deletion
Summary: Mark IPlatformRunnable for deletion
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.8 M6   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on: 370248 482382
Blocks: 495330 564890
  Show dependency tree
 
Reported: 2015-01-09 06:45 EST by Lars Vogel CLA
Modified: 2020-07-03 04:04 EDT (History)
5 users (show)

See Also:
daniel_megert: pmc_approved+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2015-01-09 06:45:18 EST
Tom deprecated 2006 this interface. I suggest we mark it for deletion. Tom, please advice if that is OK for you. Marking it for deletion would allow us to remove if for Mars+2.
Comment 1 Lars Vogel CLA 2015-01-09 06:50:34 EST
First step deprecate all fields and methods: https://git.eclipse.org/r/39282
Comment 2 Thomas Watson CLA 2015-01-09 08:04:17 EST
(In reply to Lars Vogel from comment #0)
> Tom deprecated 2006 this interface. I suggest we mark it for deletion. Tom,
> please advice if that is OK for you. Marking it for deletion would allow us
> to remove if for Mars+2.

Fine with me.
Comment 3 Lars Vogel CLA 2015-01-12 07:44:24 EST
(In reply to Lars Vogel from comment #1)
> First step deprecate all fields and methods: https://git.eclipse.org/r/39282

Committed as https://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=2ec80e0c0502f92ff9a3a36cd78dcb2b5bdf63d4
Comment 4 Lars Vogel CLA 2015-01-19 13:26:05 EST
Tom, can you give the PMC flag or should I ask Dani?
Comment 5 Thomas Watson CLA 2015-01-19 14:48:15 EST
(In reply to Lars Vogel from comment #4)
> Tom, can you give the PMC flag or should I ask Dani?

This lives with the Eclipse PMC.
Comment 6 Dani Megert CLA 2015-01-28 10:56:59 EST
> Marking it for deletion would allow us
> to remove if for Mars+2.

No, it would be Mars + 3. The 2 year retention policy is "inclusive":
https://wiki.eclipse.org/Eclipse/API_Central/Deprecation_Policy#Retention_Policy


Note that the API is used at several places (mainly fallback code), so, someone will have to do some work here.
Comment 7 Eclipse Genie CLA 2015-05-26 11:44:20 EDT
New Gerrit change created: https://git.eclipse.org/r/48658
Comment 9 Lars Vogel CLA 2015-05-27 04:02:46 EDT
.
Comment 10 Dani Megert CLA 2015-05-27 11:22:34 EDT
The deletion date (after 2016) was wrong. We keep it for the next two releases. Fixed this to be 2017.
Comment 11 Lars Vogel CLA 2015-05-27 11:24:12 EDT
(In reply to Dani Megert from comment #10)
> The deletion date (after 2016) was wrong. We keep it for the next two
> releases. Fixed this to be 2017.

Thanks, as said in todays call I wasn't sure about the date.
Comment 12 Markus Keller CLA 2016-05-31 12:03:57 EDT
If you really want to remove things, you have to follow
https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process

IPlatformRunnable is currently not marked for deletion in the @deprecated message and with @no* tags.

Furthermore, there are many references to this type in various components, and I don't see announcements for all the referencing APIs. See also bug 482382.
Comment 13 Lars Vogel CLA 2016-05-31 12:14:45 EDT
(In reply to Markus Keller from comment #12)
> If you really want to remove things, you have to follow
> https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process

I think process changes are only valid for new API deprecation and not stuff that happened in the past. Please open a new bug to align the code with the new requirements.
Comment 14 Dani Megert CLA 2016-05-31 13:02:34 EDT
Lars, two simple ways to fix this:
1. Postpone deletion
2. Add a comment to IPlatformRunnable
Comment 15 Dani Megert CLA 2016-06-02 13:07:13 EDT
We will postpone this deletion (bug 495330), and first resolve bug 482382.
Comment 16 Eclipse Genie CLA 2018-02-14 05:28:29 EST
New Gerrit change created: https://git.eclipse.org/r/117340
Comment 18 Ed Merks CLA 2018-03-08 09:28:26 EST
When is the actual deletion scheduled to take place?  Is there a Bugzilla for that?
Comment 19 Lars Vogel CLA 2018-03-08 10:06:57 EST
(In reply to Ed Merks from comment #18)
> When is the actual deletion scheduled to take place?  Is there a Bugzilla
> for that?

In two years we will create one based on this one.
Comment 20 Lars Vogel CLA 2020-07-03 04:04:32 EDT
(In reply to Lars Vogel from comment #19)
> (In reply to Ed Merks from comment #18)
> > When is the actual deletion scheduled to take place?  Is there a Bugzilla
> > for that?
> 
> In two years we will create one based on this one.

Bug 564890.