Community
Participate
Working Groups
Following Bug 370248 we can delete the org.eclipse.ui.presentations package and the org.eclipse.ui.presentationFactories extension point. h
For the deletion of the package https://git.eclipse.org/r/30266
For the extension point I'm not sure what to do here, themes.exsd has also a reference to the org.eclipse.ui.presentationFactories extension point. <appinfo> <meta.attribute kind="identifier" basedOn="org.eclipse.ui.presentationFactories/factory/@id"/> </appinfo>
(In reply to Lars Vogel from comment #1) > For the deletion of the package https://git.eclipse.org/r/30266 This deletion causes a lot of follow up errors which are not API compliant. As John announced the deletion for Mars, I think deletion is still OK. Shall I increase the major version number for this plug-in in this case?
(In reply to Lars Vogel from comment #2) > For the extension point I'm not sure what to do here, themes.exsd has also a > reference to the org.eclipse.ui.presentationFactories extension point. Before you can do it, what does it mean to the theme extension point? What is it supposed to do for 3.x color and font themes? (In reply to Lars Vogel from comment #3) > This deletion causes a lot of follow up errors which are not API compliant. > As John announced the deletion for Mars, I think deletion is still OK. > > Shall I increase the major version number for this plug-in in this case? We had decided not to bump the major version from 3 to 4 originally, because it was a very select API, and we thought the disruption was not worth it. Dani, John, do you guys have a different opinion now? PW
Moving to M2 as we still avaiting feedback from Dani or John.
(In reply to Lars Vogel from comment #5) > Moving to M2 as we still avaiting feedback from Dani or John. Bumping the major version and breaking clients just so we can delete some stuff is obviously a no go. Please answer Paul's questions. You need to ask yourself whether this/a change disturbs more people than it actually helps.
(In reply to Paul Webster from comment #4) > (In reply to Lars Vogel from comment #2) > > For the extension point I'm not sure what to do here, themes.exsd has also a > > reference to the org.eclipse.ui.presentationFactories extension point. > Before you can do it, what does it mean to the theme extension point? What > is it supposed to do for 3.x color and font themes? Need to check, created Bug 441184 for the removal of the extension point.
(In reply to Lars Vogel from comment #7) > > Before you can do it, what does it mean to the theme extension point? What > > is it supposed to do for 3.x color and font themes? > > Need to check, created Bug 441184 for the removal of the extension point. We successfully removed it via Bug 441184.
Opened Bug 443905 to delete the performance tests for the Presentation API.
https://git.eclipse.org/r/#/c/34424
(In reply to Lars Vogel from comment #10) > https://git.eclipse.org/r/#/c/34424 Merged with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=97a45fb60a41961e905f7b0befc094e82dae8a8c
I'm assuming it was this removal that caused compile failure in 10/6 Nightly build? [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.21.0:compile (default-compile) on project org.eclipse.ui.intro: Compilation failure: Compilation failure: [ERROR] /opt/public/eclipse/builds/4N/gitCache/eclipse.platform.releng.aggregator/eclipse.platform.ua/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/presentations/IntroLaunchBar.java:[164] [ERROR] IWorkbenchPreferenceConstants.PRESENTATION_FACTORY_ID); [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^ [ERROR] PRESENTATION_FACTORY_ID cannot be resolved or is not a field
(In reply to David Williams from comment #12) > I'm assuming it was this removal that caused compile failure in 10/6 Nightly > build? Yes, sorry for that. Should be fixed with http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=ccd61518b0c1ed7ecb3f7a04dfac074d767c564e
.
(In reply to Lars Vogel from comment #13) > (In reply to David Williams from comment #12) > > I'm assuming it was this removal that caused compile failure in 10/6 Nightly > > build? > > Yes, sorry for that. Should be fixed with > http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/ > ?id=ccd61518b0c1ed7ecb3f7a04dfac074d767c564e This fix is not complete: - it causes a compile warning (see N20141007-0215) - it makes no sense to keep the 'presentationId' field
(In reply to Dani Megert from comment #15) > This fix is not complete: > - it causes a compile warning (see N20141007-0215) > - it makes no sense to keep the 'presentationId' field Thanks I clean that uptonight. I'm just wanted to fix the build as fast as possible, which I think worked.
(In reply to Lars Vogel from comment #16) > (In reply to Dani Megert from comment #15) > > > This fix is not complete: > > - it causes a compile warning (see N20141007-0215) > > - it makes no sense to keep the 'presentationId' field > > Thanks I clean that uptonight. I'm just wanted to fix the build as fast as > possible, which I think worked. Also take a look at the test failures in releng and ua. They are caused by the removal.
(In reply to Lars Vogel from comment #16) > (In reply to Dani Megert from comment #15) > > > This fix is not complete: > > - it causes a compile warning (see N20141007-0215) > > - it makes no sense to keep the 'presentationId' field Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=c7395ea23d91a525592731a6f04e48897c880fd5 and created Bug 446171 for the removal of the now obsolete isPlain() method. Where do I see the test failures? http://download.eclipse.org/eclipse/downloads/drops4/I20141007-0800/testResults.php does not report any AFAICS.
(In reply to Lars Vogel from comment #18) > Where do I see the test failures? > http://download.eclipse.org/eclipse/downloads/drops4/I20141007-0800/ > testResults.php does not report any AFAICS. http://download.eclipse.org/eclipse/downloads/drops4/N20141007-0215/testResults.php
(In reply to Dani Megert from comment #19) > http://download.eclipse.org/eclipse/downloads/drops4/N20141007-0215/ > testResults.php Thanks http://download.eclipse.org/eclipse/downloads/drops4/N20141007-0215/testresults/html/org.eclipse.ua.tests.doc_linux.gtk.x86_64_8.0.html should be fixed with commit http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=00cb37f4795695c5b06901d17fccf4cf8b718451 http://download.eclipse.org/eclipse/downloads/drops4/N20141007-0215/testresults/html/org.eclipse.releng.tests_linux.gtk.x86_64_8.0.html is a bit hard for me. It says: javadoc errors and/or warnings in: platform.doc.isv.javadoc.txt See the javadoc logs linked from the test results page for details Where do I find the javadoc logs? I cannot find a link to it.
(In reply to Lars Vogel from comment #16) > (In reply to Dani Megert from comment #15) > > > This fix is not complete: > > - it causes a compile warning (see N20141007-0215) > > - it makes no sense to keep the 'presentationId' field Done with http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=c7395ea23d91a525592731a6f04e48897c880fd5 and created Bug 446171 for a follow up.
(In reply to Lars Vogel from comment #20) > (In reply to Dani Megert from comment #19) > > http://download.eclipse.org/eclipse/downloads/drops4/N20141007-0215/ > > testResults.php > > Thanks > http://download.eclipse.org/eclipse/downloads/drops4/N20141007-0215/ > testresults/html/org.eclipse.ua.tests.doc_linux.gtk.x86_64_8.0.html should > be fixed with commit > http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/ > ?id=00cb37f4795695c5b06901d17fccf4cf8b718451 > > http://download.eclipse.org/eclipse/downloads/drops4/N20141007-0215/ > testresults/html/org.eclipse.releng.tests_linux.gtk.x86_64_8.0.html is a bit > hard for me. It says: > > javadoc errors and/or warnings in: platform.doc.isv.javadoc.txt See the > javadoc logs linked from the test results page for details > > Where do I find the javadoc logs? I cannot find a link to it. Find them yet? Did you check the "View the logs for the current build." link? http://download.eclipse.org/eclipse/downloads/drops4/N20141007-0215/testResults.php It's the first one on DL page. And there, you'll see "Javadoc Logs" ... the first one on that page! :) http://download.eclipse.org/eclipse/downloads/drops4/N20141007-0215/logs.php#javadoc
(In reply to David Williams from comment #22) > http://download.eclipse.org/eclipse/downloads/drops4/N20141007-0215/logs. > php#javadoc Thanks David. From the error message (javadoc: warning - No source files for package org.eclipse.ui.presentations) I'm not sure what to fix here. But I believe the following commit might have a realistic change: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=55bcbcc877edc933d4c7dac707c8131d532221c8 Please reopen if there is still a test failure related to the deletion.
Hopefully the last issue ;-) /org.eclipse.platform.doc.isv/porting/removals.html Needs to be updated.
(In reply to Dani Megert from comment #24) > Hopefully the last issue ;-) > > /org.eclipse.platform.doc.isv/porting/removals.html > Needs to be updated. What needs to be done here? We already have the entry. See git/eclipse.platform.common/bundles/org.eclipse.platform.doc.isv/porting/removals.html#presentation
(In reply to Lars Vogel from comment #25) > (In reply to Dani Megert from comment #24) > > Hopefully the last issue ;-) > > > > /org.eclipse.platform.doc.isv/porting/removals.html > > Needs to be updated. > > What needs to be done here? We already have the entry. See > git/eclipse.platform.common/bundles/org.eclipse.platform.doc.isv/porting/ > removals.html#presentation Take a look at the page again, and if you don't see it then, I can tell you ;-).
(In reply to Dani Megert from comment #26) > Take a look at the page again, and if you don't see it then, I can tell you > ;-). I see that the header must be adjusted to cover this release. If that is want you mean, I can do, but it would be a bit bending to say it is related to this bug.
(In reply to Lars Vogel from comment #27) > (In reply to Dani Megert from comment #26) > > > Take a look at the page again, and if you don't see it then, I can tell you > > ;-). > > I see that the header must be adjusted to cover this release. Yes and the removed item needs to go away from the removals after June 2014 section, since that covers the upcoming removals in future. > If that is > want you mean, I can do, but it would be a bit bending to say it is related > to this bug. Well, this bug/change made the page outdated/incorrect, so, I'd say it is related.
(In reply to Dani Megert from comment #28) > (In reply to Lars Vogel from comment #27) Opened Bug 446433 for the update of the remove section. While I agree that this activity is related to this bug, I think most people subscribed to this bug will not be interested to our documentation update discussion and I would like to spare these people will lots of "reopen/closed" email notifications.
Using 4.5.0.N20141018-2245 since a while without issues related to this change.
I've updated API baseline to 4.4.2 and I see now API errors on org.eclipse.ui project, which are correlating to the removed API here. I'm alone observing those API errors? Description Resource Path Location Type The re-exported type org.eclipse.ui.presentations.AbstractPresentationFactory has been removed from org.eclipse.ui_3.106.1 MANIFEST.MF /org.eclipse.ui/META-INF line 1 Compatibility Problem The re-exported type org.eclipse.ui.presentations.IPartMenu has been removed from org.eclipse.ui_3.106.1 MANIFEST.MF /org.eclipse.ui/META-INF line 1 Compatibility Problem The re-exported type org.eclipse.ui.presentations.IPresentablePart has been removed from org.eclipse.ui_3.106.1 MANIFEST.MF /org.eclipse.ui/META-INF line 1 Compatibility Problem The re-exported type org.eclipse.ui.presentations.IPresentationSerializer has been removed from org.eclipse.ui_3.106.1 MANIFEST.MF /org.eclipse.ui/META-INF line 1 Compatibility Problem The re-exported type org.eclipse.ui.presentations.IStackPresentationSite has been removed from org.eclipse.ui_3.106.1 MANIFEST.MF /org.eclipse.ui/META-INF line 1 Compatibility Problem The re-exported type org.eclipse.ui.presentations.PresentationUtil has been removed from org.eclipse.ui_3.106.1 MANIFEST.MF /org.eclipse.ui/META-INF line 1 Compatibility Problem The re-exported type org.eclipse.ui.presentations.StackDropResult has been removed from org.eclipse.ui_3.106.1 MANIFEST.MF /org.eclipse.ui/META-INF line 1 Compatibility Problem The re-exported type org.eclipse.ui.presentations.StackPresentation has been removed from org.eclipse.ui_3.106.1 MANIFEST.MF /org.eclipse.ui/META-INF line 1 Compatibility Problem The API problem filter for: 'The major version should be incremented in version 3.107.0, since API breakage occurred since version 3.106.0' is no longer used MANIFEST.MF /org.eclipse.ui/META-INF line 1 Unused API Problem Filter Problem The API problem filter for: 'The re-exported type org.eclipse.ui.presentations.AbstractPresentationFactory has been removed from org.eclipse.ui_3.106.0' is no longer used MANIFEST.MF /org.eclipse.ui/META-INF line 1 Unused API Problem Filter Problem The API problem filter for: 'The re-exported type org.eclipse.ui.presentations.IPartMenu has been removed from org.eclipse.ui_3.106.0' is no longer used MANIFEST.MF /org.eclipse.ui/META-INF line 1 Unused API Problem Filter Problem The API problem filter for: 'The re-exported type org.eclipse.ui.presentations.IPresentablePart has been removed from org.eclipse.ui_3.106.0' is no longer used MANIFEST.MF /org.eclipse.ui/META-INF line 1 Unused API Problem Filter Problem The API problem filter for: 'The re-exported type org.eclipse.ui.presentations.IPresentationSerializer has been removed from org.eclipse.ui_3.106.0' is no longer used MANIFEST.MF /org.eclipse.ui/META-INF line 1 Unused API Problem Filter Problem The API problem filter for: 'The re-exported type org.eclipse.ui.presentations.IStackPresentationSite has been removed from org.eclipse.ui_3.106.0' is no longer used MANIFEST.MF /org.eclipse.ui/META-INF line 1 Unused API Problem Filter Problem The API problem filter for: 'The re-exported type org.eclipse.ui.presentations.PresentationUtil has been removed from org.eclipse.ui_3.106.0' is no longer used MANIFEST.MF /org.eclipse.ui/META-INF line 1 Unused API Problem Filter Problem The API problem filter for: 'The re-exported type org.eclipse.ui.presentations.StackDropResult has been removed from org.eclipse.ui_3.106.0' is no longer used MANIFEST.MF /org.eclipse.ui/META-INF line 1 Unused API Problem Filter Problem The API problem filter for: 'The re-exported type org.eclipse.ui.presentations.StackPresentation has been removed from org.eclipse.ui_3.106.0' is no longer used MANIFEST.MF /org.eclipse.ui/META-INF line 1 Unused API Problem Filter Problem The major version should be incremented in version 3.107.0, since API breakage occurred since version 3.106.1 MANIFEST.MF /org.eclipse.ui/META-INF line 5 Version Numbering Problem
New Gerrit change created: https://git.eclipse.org/r/44411
Gerrit change https://git.eclipse.org/r/44411 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7c7d7d1e3cbe7481e6c0f34ae2d8b2f532283515
