Bug 291215 - [Sync View] "Link with Editor" works poor for old style sync
Summary: [Sync View] "Link with Editor" works poor for old style sync
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 291217 219570
  Show dependency tree
 
Reported: 2009-10-02 11:28 EDT by Tomasz Zarna CLA
Modified: 2009-10-16 06:47 EDT (History)
1 user (show)

See Also:


Attachments
Fix v01 (20.11 KB, patch)
2009-10-15 08:47 EDT, Tomasz Zarna CLA
no flags Details | Diff
mylyn/context/zip (65.23 KB, application/octet-stream)
2009-10-15 08:47 EDT, Tomasz Zarna CLA
no flags Details
Fix v02 (3.81 KB, patch)
2009-10-16 06:32 EDT, Tomasz Zarna CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2009-10-02 11:28:10 EDT
Bug 219570 introduced an option to link Sync view with editors but for old style sync (without model participants), the option doesn't work when:
* you have activated an editor. This has a similar cause as bug 291214 because sync tree holds SyncModelElements not IFiles.
* you have selected a non-local file e.g. incoming addition
* you activated editor for a non-local file e.g. remote revision
Comment 1 Tomasz Zarna CLA 2009-10-15 08:47:06 EDT
Created attachment 149632 [details]
Fix v01

This is combination of patch for bug 219570 and fix for the issues from comment 0. The only remaining problem seems to have the same cause as bug 291212.
Comment 2 Tomasz Zarna CLA 2009-10-15 08:47:11 EDT
Created attachment 149633 [details]
mylyn/context/zip
Comment 3 Tomasz Zarna CLA 2009-10-16 06:32:39 EDT
Created attachment 149733 [details]
Fix v02

Isolated changes for this bug only.
Comment 4 Tomasz Zarna CLA 2009-10-16 06:47:36 EDT
Applied to HEAD, available in builds >N20091015-2000.