Community
Participate
Working Groups
I20080219-1124 Due to low bandwidth I often start my update or commit work by clicking on several files in the Synchronize view. This way other files load and comparison starts while I review the changes of the first file. Now, my problem is that when I switch to another compare editor, the file is not automatically selected in the Synchronize view. There are two feature I'd like to see: 1. add the Synchronize view as 'Show In' target 2. add the commonly known 'Link with Editor' tool bar button and/or view menu item
(In reply to comment #0) > I20080219-1124 > > Due to low bandwidth I often start my update or commit work by clicking on > several files in the Synchronize view. This way other files load and comparison > starts while I review the changes of the first file. > > Now, my problem is that when I switch to another compare editor, the file is not > automatically selected in the Synchronize view. If I've understood you correctly after you switch to another compare editor the several files you clicked on in the Sync View are still selected. Would you like to loose the selection? > There are two feature I'd like to see: > 1. add the Synchronize view as 'Show In' target > 2. add the commonly known 'Link with Editor' tool bar button and/or view menu > item Would you like them to have in both compare and non-compare editors?
>If I've understood you correctly after you switch to another compare editor the >several files you clicked on in the Sync View are still selected. Would you >like to loose the selection? Yes, exactly as it works in all other views that allow linking. I don't have >1 selected as I clicked each of them to open the compare editor and hence only the last one was selected. >Would you like them to have in both compare and non-compare editors? I'm happy if it works with the compare editor but normally back-linking works for all editor parts.
*** Bug 284083 has been marked as a duplicate of this bug. ***
Due to Style-Guidelines 7.21 and 13.3 both features should be implemented.
Created attachment 148515 [details] Fix v01 Patch that adds linking when sync'ed using Workspace model (I guess with models turned off it will work as well). It's a working copy, so do not apply. It's still missing couple of things: * IShowInTarget is not implemented yet * linking doesn't work for editors that do not adapt to IFile.class * only IFile or IStorageEditorInput based elements are selected in the sync tree when linking, won't work for Java Workspace sync for instance :/
Created attachment 148516 [details] mylyn/context/zip
Do you think that making the "Link with Editor" action enabled only for non-model or Workspace model synchronizations is acceptable? For other types I would disable the action (for now) and file a separate bug to address it. This would make the fix, in it's current shape, available pretty soon.
>Do you think that making the "Link with Editor" action enabled only for >non-model or Workspace model synchronizations is acceptable? For me yes, and since it's limited scope I would probably not even add a toolbar button but simply add it to the view menu.
Sounds good to me. And put it back on the toolbar with the other bug as soon as linking starts to work for all synchronizations (i.e. including models)?
Created attachment 148537 [details] Fix v02 Sync view as "Show In" target available in Synchronize perspective.
(In reply to comment #9) > Sounds good to me. And put it back on the toolbar with the other bug as soon as > linking starts to work for all synchronizations (i.e. including models)? Yes, though I could also live without that button: I doubt people are going to toggle this frequently.
(In reply to comment #11) > (In reply to comment #9) > > Sounds good to me. And put it back on the toolbar with the other bug as soon as > > linking starts to work for all synchronizations (i.e. including models)? > Yes, though I could also live without that button: I doubt people are going to > toggle this frequently. In other views like Package-Explorer I use this button frequently. So a button in View-Toolbar would be useful. For first iteration a menu entry is admissible.
>In other views like Package-Explorer I use this button frequently. Yes me too, but I guess I won't toggle it often in the Sync view, e.g. I also never disable it in the History view. Anyway, I also don't care if it's there by default. Just make sure to put it into an action set so, that I can remove it.
>I also don't care if it's there by default. Just make sure to put it into an >action set so, that I can remove it. Forget this! Action sets are only for the main toolbar.
Created attachment 148657 [details] Fix v03 This is an updated version of the patch that imo is ready to be committed. However, it's still missing bunch of things (see bug 291212, bug 291213, bug 291214, bug 291215) so if you think any of these is a no-go for this patch to be applied please let me know.
I have not tried the patch, but when I glanced though it, I didn't see any command ID being used for the ToggleLinkingAction. IWorkbenchCommandConstants.NAVIGATE_TOGGLE_LINK_WITH_EDITOR should be used as actionDefinitionID. In the Package Explorer, we handle activation in PackageExplorerActionGroup.setGlobalActionHandlers(IActionBars).
*** Bug 249919 has been marked as a duplicate of this bug. ***
Created attachment 148740 [details] Fix v04 Added IWorkbenchCommandConstants.NAVIGATE_TOGGLE_LINK_WITH_EDITOR as actionDefinitionID for ToggleLinkingAction.
>so if you think any of these is a no-go for this patch to >be applied please let me know. For me it's useless given the current limitations as 1. my main use case is to link from compare editor to view and not the other way around (not working due to bug 291213) 2. I use the old non-model based sync (bug 291215)
All right, at least I now know which bugs I should fix first. Thanks for the comment.
Created attachment 149732 [details] Fix v05 Final version of the patch to be committed simultaneously with fixes for bug 291215, bug 291214 and bug 291213.
Applied to HEAD, available in builds >N20091015-2000. Bug 291213 no longer blocks this one.
Verified in I20091027-0100: works great! Remaining issue: the view menu action has not mnemonic (bug 293542 ).
