Bug 291214 - [Sync View] "Link with Editor" doesn't show current editor's input in model sync trees
Summary: [Sync View] "Link with Editor" doesn't show current editor's input in model s...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 291217
  Show dependency tree
 
Reported: 2009-10-02 11:27 EDT by Tomasz Zarna CLA
Modified: 2009-10-16 06:45 EDT (History)
0 users

See Also:

Attachments
Fix v01 (20.04 KB, patch)
2009-10-16 05:47 EDT, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (128.55 KB, application/octet-stream)
2009-10-16 05:47 EDT, Tomasz Zarna CLA 		no flags Details
Fix v02 (3.15 KB, patch)
2009-10-16 06:43 EDT, Tomasz Zarna CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2009-10-02 11:27:32 EDT 
Bug 219570 introduced an option to link Sync view with editors. It links fine if you select a node in the sync tree, but fails when you want to link the other way round, if an editor is activated it will select only nodes in Workspace or Change Sets model. This is caused be the fact that the current implementation, in order to select a node, creates a StructeredSelection object with an IFile passed in. This won't work if we want to select a node in a model participant tree.
Comment 1 Tomasz Zarna CLA 2009-10-16 05:47:26 EDT 
Created attachment 149727 [details]
Fix v01

Combined patches for "Link with Editor" (bug  291323) + old style sync (bug 291215) + compare editors linking (bug 291213) + fix for model sync tree (this bug).
Comment 2 Tomasz Zarna CLA 2009-10-16 05:47:36 EDT 
Created attachment 149728 [details]
mylyn/context/zip
Comment 3 Tomasz Zarna CLA 2009-10-16 05:49:43 EDT 
Oops, "Link with Editor" is bug 219570.
Comment 4 Tomasz Zarna CLA 2009-10-16 06:43:26 EDT 
Created attachment 149734 [details]
Fix v02

Isolated changes for this bug only. Did some code cleaning in the meantime too.
Comment 5 Tomasz Zarna CLA 2009-10-16 06:45:37 EDT 
Applied to HEAD, available in builds >N20091015-2000.