Bug 253855 - Use Jars
Summary: Use Jars
Status: RESOLVED FIXED
Alias: None
Product: Web Tools
Classification: WebTools
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: David Williams CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords:
Depends on: 262306 262305
Blocks: 252800
  Show dependency tree
 
Reported: 2008-11-04 20:43 EST by Anne Jacko CLA
Modified: 2009-05-14 13:04 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anne Jacko CLA 2008-11-04 20:43:26 EST
+++ This bug was initially created as a clone of Bug #252800 +++

Projects must use jar'ed plug-ins (with unpack=false) unless authorized by the planning council for technical reasons. Nested jars should be avoided if possible since it creates problems for projects that has dependencies to such plug-ins. The OSGi runtime is fine with it but the compiler is not able to handle classpaths that contain nested jars. In case only one nested jar exists, it is often better to expand the contents of that jar into the root folder (i.e. unnest the jar). If a plug-in contains large files that are frequently used (opened and closed), a jar'ed plug-in might degrade performance significantly since the file must be decompressed each time it is opened.
Comment 1 David Williams CLA 2009-01-24 22:14:37 EST
We are close, but I'll need to investigate. 

Some of these are "legacy" ... could be jarred up, but would take a lot of changes to our existing code, since it was written to use file IO to read data from the plugin directories. 

In some cases, its important to leave a nested jar, since we may be using it to "copy" to a server location where it's needed by a web application. In some cases, these could be fixed with enough effort, but no one is able/willing to do it. 

There is one or two I see that appear to be an oversight ... an info pop plugin and an isv doc plugin. 

For cases that can't be jarred, I'll open (or find existing) bugs that document/discuss them. 

Here's our current list from WTP, of plugins that are not jarred. 

javax.xml.rpc
javax.xml.soap
org.apache.axis
org.apache.cactus
org.apache.commons.discovery
org.eclipse.jst.ejb.ui.infopop
org.eclipse.jst.server.generic.jboss
org.eclipse.jst.server.generic.jonas
org.eclipse.jst.server.generic.oc4j
org.eclipse.jst.server.websphere.core
org.eclipse.jst.ws.consumption
org.eclipse.servertools.doc.isv
org.eclipse.wst.command.env

Comment 2 David Williams CLA 2009-01-24 22:33:54 EST
I've fixed the bundle of 
org.eclipse.jst.ejb.ui.infopop
and opened the two "depends on" bugs to cover the rest. 
Comment 3 David Williams CLA 2009-01-24 22:50:24 EST
maybe I should mention, our test bundles are not jarred, but they can not be due to a current limitation of the test framework we use, from the Platform. 
Comment 4 David Williams CLA 2009-03-16 09:53:43 EDT
Counting as 'fixed'. There are still a few hanging out: 

org.eclipse.jst.server.generic.jboss
org.eclipse.jst.server.generic.jonas
org.eclipse.jst.server.generic.oc4j
org.eclipse.jst.server.websphere.core


These may be fixed eventually, but also will not be part of our main distribution this release so will have little impact/visibility. 

Comment 5 Kaloyan Raev CLA 2009-05-14 12:32:32 EDT
David, it seems that this fix caused some upgrade problems. See bug 275709 for details. Maybe other plugins with changed "unpack" flag should be checked, too. 
Comment 6 David Williams CLA 2009-05-14 13:04:47 EDT
(In reply to comment #5)
> David, it seems that this fix caused some upgrade problems. See bug 275709 for
> details. Maybe other plugins with changed "unpack" flag should be checked, too. 
> 

Thanks Kaloyan. I've put a note in bug 252800 for the future ... and I don't think we need to check much (unless you were volunteering? :) I suspect Conan will tell us if there's others.