Bug 252800 - Use Jars
Summary: Use Jars
Status: RESOLVED FIXED
Alias: None
Product: Simultaneous Release
Classification: Eclipse Foundation
Component: Prereq (show other bugs)
Version: Galileo   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: M4   Edit
Assignee: Simultaneous Release Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 252834 253791 253832 253833 253834 253835 253836 253837 253838 253839 253840 253841 253842 253843 253844 253845 253846 253847 253848 253849 253850 253851 253852 253853 253854 253855 255882 257295 257567 257885 258607 260147 262478 263336 263364 263392
Blocks: 258464
  Show dependency tree
 
Reported: 2008-10-30 12:45 EDT by Bjorn Freeman-Benson CLA
Modified: 2009-10-09 13:14 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bjorn Freeman-Benson CLA 2008-10-30 12:45:34 EDT
Projects must use jar'ed plug-ins (with unpack=false) unless authorized by the planning council for technical reasons. Nested jars should be avoided if possible since it creates problems for projects that has dependencies to such plug-ins. The OSGi runtime is fine with it but the compiler is not able to handle classpaths that contain nested jars. In case only one nested jar exists, it is often better to expand the contents of that jar into the root folder (i.e. unnest the jar). If a plug-in contains large files that are frequently used (opened and closed), a jar'ed plug-in might degrade performance significantly since the file must be decompressed each time it is opened.
Comment 1 Thomas Watson CLA 2008-11-05 15:16:53 EST
In bug 253844 equinox has the list of launcher fragments that must not be jar'ed when deployed to a runtime.  What is the process to get the planning council's approval of our non-jared bundles?


Comment 2 Richard Gronback CLA 2008-11-05 17:11:07 EST
(In reply to comment #1)
>What is the process to get the planning  council's approval of our non-jared bundles?

As discussed on the PC call today, I'd say you're good to go with what you've documented in bug 253844.  Thanks.

Comment 3 Christian Damus CLA 2008-11-12 15:08:35 EST
Does this requirement include deploying source attachments as individual source bundle JARs, which is supported by PDE since 3.4?

The description makes reference to dependents of bundles, which presumably isn't an issue with source bundles, as no bundle would ever depend on them.
Comment 4 Richard Gronback CLA 2008-11-12 17:53:30 EST
Good question.  I'd like to see the promotion of jar'd individual source bundles.  I'll add this to the agenda for the next PC call to see what the consensus is: http://wiki.eclipse.org/Planning_Council/Dec_03_2008
Comment 5 Richard Gronback CLA 2008-12-03 14:18:49 EST
(In reply to comment #4)
>  I'll add this to the agenda for the next PC call to see what the
> consensus is: http://wiki.eclipse.org/Planning_Council/Dec_03_2008

The consensus was that individual source jars are included in the requirement, with the same stipulation that exceptions are allowable if documented.

Comment 6 Anthony Hunter CLA 2008-12-17 22:15:01 EST
Copied from Bug 253834 , why source bundles?

The Eclipse platform went to source bundles in 3.4 / Galileo. The PDE build has
documentation in place and it is supposed to be "trivial" to adopt.

The benefit is that it helps solves the long pathname limit issue on windows. In the Microsoft API (with some exceptions), the maximum length for a path is
MAX_PATH, which is defined as 260 characters.

In Ganymede, there exists the source folder
[eclipse]\dropins\plugins\org.eclipse.emf.source_2.4.0.v200806091234\src\org.eclipse.emf.codegen.ecore_2.4.0.v200806091234\src.zip
. Because of the path length limit, "C:\Program File\Some Vendor\Some
Product\eclipse" may longer be an option to install your Eclipse based
development application that includes EMF source. At worst, the length of "Some
Vendor\Some Product\eclipse" is significantly limited.
Comment 7 Kentarou Fukuda CLA 2008-12-18 14:09:35 EST
Technology ACTF project wants to use three plug-ins as non jar'ed plug-in (please see bug 258607). How can we get the plannning council's approval?

Comment 8 Kentarou Fukuda CLA 2009-01-07 12:51:12 EST
(In reply to comment #7)
Based on the discussion at the Planning Council call today, I closed the bug 258607. Thanks.
Comment 9 David Williams CLA 2009-05-14 13:02:34 EDT
We should remember, in future, to clarify in the "jar up bundles" rule that any bundles that change shape also require a version increase, preferably service field, but qualifier-only would also work, as far as I know (and it typically qualifier only in Orbit, since those are third party jars). It is easy to change since traditionally, the change is made in the feature, not the bundle. See bug 275709 for an example of where we forgot to do this. In the future, hopefully, people will move to the "bundle shape" directive, so may not be so easy to forget in those cases. 

Comment 10 David Williams CLA 2009-10-09 13:14:00 EDT
THis is a routine mass closing of the previous release umbrella tracking bugs.