Bug 262305 - Need to jar-up bundles for Galileo
Summary: Need to jar-up bundles for Galileo
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.ws (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Keith Chong CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard:
Keywords:
Depends on: 113122
Blocks: 253855
  Show dependency tree
 
Reported: 2009-01-24 22:24 EST by David Williams CLA
Modified: 2009-03-16 16:49 EDT (History)
2 users (show)

See Also:


Attachments
Patch to jar the plugins (5.29 KB, patch)
2009-03-10 17:02 EDT, Keith Chong CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2009-01-24 22:24:12 EST
There may be bugs open for some of these already, but I'm trying to do some "mass processing". 

I think all these belong to the "web services team," even though wst.command.env is in the common project. 

Can these be "jarred"? If not, or if not immediately, please open bugs to track, or, list existing bugs here to leave a document trail. In particular, the last two in the list would surprise me if there was a need to keep unjarred. 

javax.xml.rpc
javax.xml.soap
org.apache.axis
org.apache.commons.discovery
org.eclipse.jst.ws.consumption ?
org.eclipse.wst.command.env    ?
Comment 1 Kathy Chan CLA 2009-01-26 16:20:08 EST
Yes.  These plugins all "belong" to the Web services team.  These are plugins needed by the Axis1 emitter.  Two other plugins (javax.wsdl and org.apache.commons.logging) required by Axis1 are already jarred up.  I don't remember specific reason why the first 4 could not be jarred up. I think we just had not get around to it.  Please note that once they are jarred up, CopyAxisJarCommand needs to be updated to use copyPluginJar rather than copyIFile to copy those plugins.  Also, the plugin size (XXX_JAR_SIZE) needs to be updated.  

The plugin org.eclipse.jst.ws.consumption was not jarred up because we are copying webservicesutils.jar to the Web project when generating Web services samples JSP.  If this is jarred up, then CopyWebServiceUtilsJarCommand needs to be updated to properly get the location of webseriveutils.jar from the bundle.

The plugin org.eclipse.wst.command.env was not jarred up because Ant properties files are packaged in the ant directory of the plugin.  Users would have to copy the files from that directory and modify them when running Web services Ant task from command line.

Since WTP 3.1 M5 is fast approaching, I don't think this can be done for that milestone.  Retargeting to WTP 3.1 M6 instead to see what can be done for that milestone.

Keith, you can talk to Mark about the code that needs to change here for copying Axis JARs and webserviceutils.jar.  Talk to Eric and Yen regarding the strategy of how to handle the Ant tasks in org.eclipse.wst.command.env.

Comment 2 Keith Chong CLA 2009-02-04 10:29:49 EST
Hi Valentin, this one is mine.
Comment 3 Valentin Baciu CLA 2009-02-04 10:32:57 EST
Sorry, moved it by mistake in my inbox.
Comment 4 Keith Chong CLA 2009-03-04 13:47:31 EST
Bug 13122 is related.
Comment 5 Keith Chong CLA 2009-03-04 13:48:46 EST
Correction it's bug 113122 
Comment 6 Keith Chong CLA 2009-03-10 17:02:18 EDT
Created attachment 128278 [details]
Patch to jar the plugins

Patch to jar up plugins.  

For the plugins we 'own', we will remove the nested runtime jars in the org.eclipse.jst.ws.consumption (wsc.jar) and org.eclipse.wst.command.env (env.jar) plugins.  They will be 'exploded' and the @dot will be added to the plugin's runtime classpath, instead of the runtime jar.

The two jars, anttasks.jar and webserviceutils.jar will remain as nested jars.
Comment 7 Keith Chong CLA 2009-03-11 14:55:32 EDT
Fix released to 3.1 M6.
Comment 8 Keith Chong CLA 2009-03-16 16:49:38 EDT
Verified in I-3.1-20090313175458.  Closing bug.