Bug 244623 - Cannot perform compare from "Compare with Other" dialog
Summary: Cannot perform compare from "Compare with Other" dialog
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 224562 240298 241088 241643 243744 73923 241077 241649
  Show dependency tree
 
Reported: 2008-08-19 17:14 EDT by Aleksandra Wozniak CLA
Modified: 2009-06-02 05:21 EDT (History)
3 users (show)

See Also:

Attachments
patch #1 (974 bytes, patch)
2008-08-19 17:21 EDT, Aleksandra Wozniak CLA 		tomasz.zarna: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aleksandra Wozniak CLA 2008-08-19 17:14:04 EDT 
Sometimes two-way compare cannot be performed from "Compare with Other" dialog because "OK" is not enabled. For example, when you choose "Compare with">"Other resource" on one selected file and drag another file into appearing dialog, the OK button is disabled although comparison is possible.
Comment 1 Aleksandra Wozniak CLA 2008-08-19 17:21:46 EDT 
Created attachment 110399 [details]
patch #1

Here is the solution.
Comment 2 Tomasz Zarna CLA 2008-08-20 04:46:59 EDT 
The situation described in comment 0 occurs when you have a valid resource in left (or right) field, an invalid resource set as ancestor and than drag a valid resource on the right field (or left). The Ok button doesn't get enabled. The patch fixes the problem.
Comment 3 Tomasz Zarna CLA 2008-08-20 04:48:02 EDT 
Released to HEAD.
Comment 4 Pawel Pogorzelski CLA 2008-09-18 06:12:35 EDT 
Verified in build I20080916-0902.
Comment 5 Szymon Brandys CLA 2008-09-18 06:31:13 EDT 
VERIFIED by Pawel.