Bug 241649 - [Dialogs] Resizing of the "compare with other" dialog
Summary: [Dialogs] Resizing of the "compare with other" dialog
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 247837 (view as bug list)
Depends on: 239959 244623
Blocks: 224562
  Show dependency tree
 
Reported: 2008-07-22 07:28 EDT by Aleksandra Wozniak CLA
Modified: 2009-06-02 06:52 EDT (History)
2 users (show)

See Also:

Attachments
Patch_v01 (4.03 KB, patch)
2009-01-09 11:12 EST, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch_v02 (2.38 KB, patch)
2009-01-20 06:41 EST, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aleksandra Wozniak CLA 2008-07-22 07:28:22 EDT 
When ancestor section in "Compare with Other" dialog is not expanded there remains empty, grey area which doesn't look nice. The dialog should be resized after expanding or collapsing ancestor panel.
Comment 1 Tomasz Zarna CLA 2008-08-19 10:50:58 EDT 
Any news here?
Comment 2 Aleksandra Wozniak CLA 2008-08-25 03:25:09 EDT 
I think this issue is resolved in bug 241088 and bug 73923 (see attachments) and therefore we don't need a separate patch here.
Comment 3 Aleksandra Wozniak CLA 2008-09-05 08:46:10 EDT 
We have other resizing issues than the one mentioned in the description. Copied from bug 73923 comment 6:

Open the dialog, make it wider, open the ancestor part. Dialog's size changes so I need to resize it again. You may want open a separate bug for it.
Comment 4 Pawel Pogorzelski CLA 2008-12-08 09:58:48 EST 
Another issue is that dialog doesn't remember its settings. After closing it and reopening the default size is used.

BTW the default layout with default size isn't very nice. I'd change groups for left and right file to be one under another as it would save horizontal space.
Comment 5 Pawel Pogorzelski CLA 2008-12-08 10:01:09 EST 
Aleksandra, are you OK with placing controls for right file under the group for the left file?
Comment 6 Pawel Pogorzelski CLA 2009-01-09 11:12:11 EST 
Created attachment 122125 [details]
Patch_v01
Comment 7 Tomasz Zarna CLA 2009-01-13 02:31:52 EST 
Patch is in HEAD. Thanks Pawel!
Comment 8 Tomasz Zarna CLA 2009-01-19 09:38:34 EST 
The patch doesn't work when you open the dialog for 3 resources. The ancestor section gets expanded and the right section disappears. Workaround: collapse and expand again the ancestor section, this will layout the dialog properly.
Comment 9 Pawel Pogorzelski CLA 2009-01-20 06:41:58 EST 
Created attachment 123064 [details]
Patch_v02

That should solve the problem definitely.
Comment 10 Tomasz Zarna CLA 2009-01-20 07:20:35 EST 
(In reply to comment #9)
> Created an attachment (id=123064)
> Patch_v02

In HEAD. Thanks Pawel.
Comment 11 Tomasz Zarna CLA 2009-02-11 04:48:13 EST 
*** Bug 247837 has been marked as a duplicate of this bug. ***