Bug 21882 - [Coolbar] Cool item position should be persisted
Summary: [Coolbar] Cool item position should be persisted
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 2.0.1   Edit
Assignee: Lynne Kues CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 21611 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-07-24 21:58 EDT by Nick Edgar CLA
Modified: 2002-08-21 11:42 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2002-07-24 21:58:19 EDT
R2.0

- open a Java editor
- move the editor contribution cool item down to form a new row
- open a text editor
- switch back to the Java editor
- the editor contribution cool item is back on the first row
- it should be on the second row, by itself

Also:

- open a new Resource perspective
- move the external tools cool item down to form a new row
- Window / Customize Perspective / Other / uncheck External Tools / OK
- Window / Customize Perspective / Other / check External Tools / OK
- it's back on the first row
- it should be on the second row, by itself

The positions of cool items should be remembered even when they're not 
currently shown, based on the cool item's "identity" (which group of actions 
it's showing).

Must also persist the positions of editor contributions broken into multiple 
cool items using the special group marker.
Comment 1 Nick Edgar CLA 2002-07-24 22:01:34 EDT
See also bug 21882.
Comment 2 Nick Edgar CLA 2002-07-29 15:16:21 EDT
*** Bug 21611 has been marked as a duplicate of this bug. ***
Comment 3 Lynne Kues CLA 2002-07-30 12:29:14 EDT
This PR will be affected by [Bug 21834] Coolbar - deleting items corrupting 
layout.  In some instances, when the first item is a row is deleted, the 
platform widget gets rid of the row (i.e., moves the items after the deleted 
item to the previous row).  

Currently, my algorithm for restoring the position of a re-added item compares 
the row of the item before it was deleted to the same row (index-wise) in the 
current layout to determine where to add the item.  Since the platform is 
corrupting the row layout as a result of removing the coolitem, the reposition 
algorithm won't work as well as it could in this situation.  
Comment 4 Lynne Kues CLA 2002-07-30 16:24:04 EDT
This PR is affected by [Bug 22055] CoolBar - setWrapIndices causes rows to 
collapse/expand unnecessarily.  When attempting to restore the position of an 
item, if wrap indices need to be set to create a new row, you can visibly see 
the coolbar rows collapse than expand.  Can workaround it by always turning off 
redraw whenever an item is added to the coolbar.
Comment 5 Lynne Kues CLA 2002-08-03 15:12:31 EDT
This PR will be affected by SWT [Bug 22144] Coolbar - setSize not being honored 
after setWrapIndices API used.  Setting the size for a CoolItem is not honored 
after the setWrapIndices API is used.  This will affect restoring the position 
(which includes the size) of a CoolItem properly.
Comment 6 Lynne Kues CLA 2002-08-09 13:35:47 EDT
This PR is affected by the Linux SWT PR:
   
   [Bug 22320] Coolbar - delete item behavior problem 

and leads to undesirable behavior on Linux when CoolItems that were deleted are 
added back.
Comment 7 Lynne Kues CLA 2002-08-13 18:56:41 EDT
Released changes to 2.0 stream.
Comment 8 Lynne Kues CLA 2002-08-14 15:53:06 EDT
Opened SWT [Bug 22448] New: CoolBar - deleting first item in row does 
unnecessary collapse/expand of row.

This needs to be fixed for 2.0.1 - it leads to a "jumpy" coolbar under certain 
circumstances.
Comment 9 Lynne Kues CLA 2002-08-14 15:54:20 EDT
Changes released in 2.1 and 2.0.1 streams.
Comment 10 Lynne Kues CLA 2002-08-16 11:00:04 EDT
Verified that 22448 is fixed.  Removed temporary workaround.  Released in 2.1 
and 2.0.1 > 20020815.
Comment 11 Lynne Kues CLA 2002-08-16 16:15:13 EDT
Fixed problem with algorithm, released into 2.1 stream, need to merge into 
2.0.1 after more testing.
Comment 12 Lynne Kues CLA 2002-08-19 11:26:16 EDT
Changes merged into 2.0.1, > 20020815.
Comment 13 Lynne Kues CLA 2002-08-21 11:42:54 EDT
Fixed.