Bug 209897 - add a preview page to the Attach Screenshot wizard
Summary: add a preview page to the Attach Screenshot wizard
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Willian Mitsuda CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 211908 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-11-14 23:42 EST by Mik Kersten CLA
Modified: 2008-02-21 17:51 EST (History)
2 users (show)

See Also:

Attachments
Patch for preview (10.81 KB, patch)
2008-02-21 00:38 EST, Willian Mitsuda CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mik Kersten CLA 2007-11-14 23:42:12 EST 
The wizard supports cropping, but does not provide a preview of the cropped result.  I think that the easiest way to provide this would be with a "Crop" button that goes just before the Fit Image button.  This would would be disabled if there were no crop selection, and would have the visual effect of zooming into the cropped area.  The user would then still be able to use the Fit Image action to preview before submitting.  The alternative is to add a separate preview page.
Comment 1 Willian Mitsuda CLA 2007-11-15 16:14:43 EST 
The most obvious solution is to have a preview page, but I'm not sure adding one more page to the wizard just for this is a good idea.

The button sounds like a good alternative, but what do you have in mind? Zooming the crop selection to fit in the canvas, or zoom to 100% with the selection centered?
Comment 2 Mik Kersten CLA 2007-11-16 01:57:02 EST 
What I had in mind is zooming to the crop section, and calling the button "Crop".  To zoom to 100% we have the "Fit Image" button.  Maybe "Fit Image" should be called "Actual Size".  I think that this two button approach should work though, and agree that it seems better than another page.
Comment 3 Eugene Kuleshov CLA 2007-11-16 11:59:42 EST 
Mik, "Crop" usually mean the actual operation. Perhaps it would be better to call such action "Preview" and the "Fit Image" always been the opposite to the "Actual Size" (fit vs. 100% zoom)
Comment 4 Willian Mitsuda CLA 2007-11-16 13:52:29 EST 
Note that I have some complaints about the "Fit Image" functionality.

I opened bug#210020 for that.
Comment 5 Steffen Pingel CLA 2007-12-04 17:37:17 EST 
*** Bug 211908 has been marked as a duplicate of this bug. ***
Comment 6 Steffen Pingel CLA 2007-12-04 17:37:47 EST 
+1 for having a separate page. It is consistent with the workflow for attaching files and would give me the confidence that I am submitting exactly what I see in the wizard.
Comment 7 Willian Mitsuda CLA 2008-02-01 14:19:25 EST 
Mik and I have discussed some details about this in bug#195691, comments 26 and 27, so I think we have all agreed to make a single separate page for preview.

Anything else?
Comment 8 Mik Kersten CLA 2008-02-13 00:09:19 EST 
I think that's it, so you may get to kill two bugs with one patch ;)
Comment 9 Willian Mitsuda CLA 2008-02-20 14:09:04 EST 
Patch for this functionality posted together in bug#195691.

Please be aware of behavior described in bug#219637.
Comment 10 Willian Mitsuda CLA 2008-02-21 00:38:04 EST 
Created attachment 90288 [details]
Patch for preview
Comment 11 Mik Kersten CLA 2008-02-21 17:51:14 EST 
Patch applied (yesterday).