Bug 219637 - Attachment preview page should not expand itself to the size of image
Summary: Attachment preview page should not expand itself to the size of image
Status: RESOLVED WORKSFORME
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: dev   Edit
Hardware: PC Windows Vista
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Mylyn Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-20 13:10 EST by Willian Mitsuda CLA
Modified: 2009-05-21 22:42 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Willian Mitsuda CLA 2008-02-20 13:10:05 EST 
The attachment preview page expands to the size of image.

This can be annoying when using it for displaying captured screenshots of entire desktop because it expands to the size of screen.

And because the dialog auto-saves its size, next time you enter the wizard, it will come fully expanded.
Comment 1 Eugene Kuleshov CLA 2008-02-20 14:54:09 EST 
Usually it is annoying when dialog resizes on its own. Wouldn't it be better to fit/scale image to the dialog size by default and have an option to scale it to 100% (then maximize button would address the dialog resizing).
Comment 2 Willian Mitsuda CLA 2008-02-20 16:13:19 EST 
 (In reply to comment #1)
> Wouldn't it be better to
> fit/scale image to the dialog size by default and have an option to scale it to
> 100% (then maximize button would address the dialog resizing).

I'm initially -1 for this, because:

- I think it is better to keep the preview page simple as possible.
- It is important to show initially the image at 100%, so we are sure he sees what will be submitted exactly at its natural size.

BTW, I've been investigating this behavior since yesterday and hadn't find anything wrong yet with the way the Canvas/ScrolledComposite are being built... It shouldn't be happening since it is similar to the way it is built in ScreenshotAttachmentPage...
Comment 3 Eugene Kuleshov CLA 2008-02-20 17:40:59 EST 
I didn't realized wizard is already resizing itself when switching to the preview page. Wouldn't it make sense to remove that and just let user to resize window and use scrolled composite instead?
Comment 4 Willian Mitsuda CLA 2008-02-21 01:01:27 EST 
 (In reply to comment #3)
> I didn't realized wizard is already resizing itself when switching to the
> preview page. Wouldn't it make sense to remove that and just let user to resize
> window and use scrolled composite instead?

Yes, that is exactly what I'm trying to do :)
Comment 5 Steffen Pingel CLA 2009-05-21 22:42:05 EDT 
I can not reproduce this problem. Please reopen if you are still seeing it with the latest weekly build.