[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [tm-dev] Will "Terminal (Old)" be removed before GA?
|
Ok, I can reproduce the problem:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=468875
It looks like the issue is that a PropertyTester always returns true while the plug-in of its implementing class is not yet activated.
Thanks,
Martin
--
Martin Oberhuber, SMTS / Product Owner - Development Tools, Wind River
direct +43.662.457915.85 fax +43.662.457915.6
-----Original Message-----
From: tm-dev-bounces@xxxxxxxxxxx [mailto:tm-dev-bounces@xxxxxxxxxxx] On Behalf Of Oberhuber, Martin
Sent: Saturday, May 30, 2015 7:32 AM
To: TM project developer discussions
Subject: Re: [tm-dev] Will "Terminal (Old)" be removed before GA?
Hi Rob,
I'm referring to line 338ff here:
http://git.eclipse.org/c/tm/org.eclipse.tm.terminal.git/tree/plugins/org.eclipse.tm.terminal.view.ui/plugin.xml
Due to the PropertyTester, the capability should always be disabled:
http://git.eclipse.org/c/tm/org.eclipse.tm.terminal.git/tree/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/internal/PropertyTester.java
which means no UI contributions of it should be visible.
See also the "org.eclipse.ui.activities" extension point.
Thanks,
Martin
--
Martin Oberhuber, SMTS / Product Owner - Development Tools, Wind River direct +43.662.457915.85 fax +43.662.457915.6
-----Original Message-----
From: tm-dev-bounces@xxxxxxxxxxx [mailto:tm-dev-bounces@xxxxxxxxxxx] On Behalf Of Rob Stryker
Sent: Saturday, May 30, 2015 3:47 AM
To: tm-dev@xxxxxxxxxxx
Subject: Re: [tm-dev] Will "Terminal (Old)" be removed before GA?
On 05/29/2015 03:22 PM, Oberhuber, Martin wrote:
> The view is hidden (by means of capability) in all menus and views.
I'm sorry, I'm not very familiar with capabilities, so I'm not sure what you mean that it's hidden by capabilities. In my environment, the view is still present if I go to window -> show view -> other, and type "terminal".
Are there some specific eclipse platform plugins I must have in my environment to ensure "capabilities" is present and that the view is hidden?
- Rob Stryker
> It was implemented to fix this bug:
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=466644
>
>
> My explanation referred to the "RSE Terminals" view that is implemented by this:
> http://git.eclipse.org/c/tm/org.eclipse.tm.git/tree/rse/features/org.e
> clipse.rse.terminals-feature/feature.xml?h=master
> still available but marked as deprecated because it's now superseded by the RSE Terminal Connector for the new view which is here:
> http://git.eclipse.org/c/tm/org.eclipse.tm.terminal.git/tree/features/
> org.eclipse.tm.terminal.view.rse.feature/feature.xml
>
> HTH,
>
> Thanks,
> Martin
> --
> Martin Oberhuber, SMTS / Product Owner - Development Tools, Wind River
> direct +43.662.457915.85 fax +43.662.457915.6
>
>
> -----Original Message-----
> From: tm-dev-bounces@xxxxxxxxxxx [mailto:tm-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Rob Stryker
> Sent: Friday, May 29, 2015 8:40 PM
> To: tm-dev@xxxxxxxxxxx
> Subject: Re: [tm-dev] Will "Terminal (Old)" be removed before GA?
>
> I'm sorry, but I'm not following at all.
>
> As far as I can tell, the plugin org.eclipse.tm.terminal.view.ui is part of the distribution and is not hidden in any update site. It's an integral part of the org.eclipse.tm.terminal.view.feature. Am I wrong here?
>
> org.eclipse.tm.terminal.view.ui has, in its plugin xml, the following:
>
> <view
> allowMultiple="true"
> category="org.eclipse.tm.terminal.view.ui.views.category"
> class="org.eclipse.tm.terminal.view.ui.view.TerminalsView"
> icon="icons/eview16/terminal_view.gif"
> id="org.eclipse.tm.terminal.view.ui.TerminalsView"
> name="%TerminalsView.name">
> </view>
>
> <!-- Contribute another view with the old ID to handle the ID change -->
> <view
> allowMultiple="true"
> class="org.eclipse.tm.terminal.view.ui.view.OldTerminalsViewHandler"
> icon="icons/eview16/terminal_view.gif"
> id="org.eclipse.tcf.te.ui.terminals.TerminalsView"
> name="%TerminalsView.name.old">
> </view>
>
>
> So it seems this plugin.xml is contributing two views.
>
> > AFAIK neither the EPP packages nor Mars itself will offer the
> "Terminal(Old)" view; it's only on the TM update site and pretty hidden.
> So I'm not sure how any user would get the old view.
>
> Basically, it APPEARS as follows:
> 1) org.eclipse.tm.terminal.feature is the primary feature
> 2) org.eclipse.tm.terminal.feature includes
> org.eclipse.tm.terminal.view.feature
> 3) org.eclipse.tm.terminal.view.feature has the plugin
> org.eclipse.tm.terminal.view.ui
> 4) org.eclipse.tm.terminal.view.ui declares two views, one with
> name Terminal (Old)
>
> Can you please explain how this is hidden on an update site? Am I
> reading something wrong here? Is org.eclipse.tm.terminal.view.ui not
> part of the EPP distribution? As far as I can tell, that's the only
> plugin actually declaring a view, and it declares two.
>
> - Rob Stryker
>
>
>
> On 05/29/2015 06:46 AM, Oberhuber, Martin wrote:
>> Hi Rob,
>>
>> AFAIK neither the EPP packages nor Mars itself will offer the "Terminal(Old)" view; it's only on the TM update site and pretty hidden.
>> So I'm not sure how any user would get the old view.
>>
>> Perhaps if they "upgrade" from Luna to Mars ... then they probably keep/update the old view and I'm not sure if we can (or want to) avoid that.
>>
>> We've done a lot of testing on these kind of migration scenarios, we did find some issues (which you'll find in bugzilla, few are still unresolved), but from my POV we've come to a point where we (committers) don't want to invest more. If there is specific install/upgrade scenarios that you care about, please do the respective testing, file bugzilla's and contribute fixes if you find it necessary.
>>
>> Hope that helps and you can understand our stance !
>>
>> Thanks !
>> Martin
>> --
>> Martin Oberhuber, SMTS / Product Owner - Development Tools, Wind
>> River direct +43.662.457915.85 fax +43.662.457915.6
>>
>>
>> -----Original Message-----
>> From: tm-dev-bounces@xxxxxxxxxxx [mailto:tm-dev-bounces@xxxxxxxxxxx]
>> On Behalf Of Rob Stryker
>> Sent: Friday, May 29, 2015 5:33 AM
>> To: tm-dev@xxxxxxxxxxx
>> Subject: Re: [tm-dev] Will "Terminal (Old)" be removed before GA?
>>
>> Hi Uwe:
>>
>> The concern here (at least from our perspective) is that the unification was meant to reduce the number of terminals, so that when a user goes window -> show view -> other and types "Terminal", they see only one (or possibly two) relevant results with visibly different names. So I'd like to make sure that we're not going to see two views both named "Terminal" , which will be confusing for a user if a how-to guide indicates they should open the view named "Terminal".
>>
>> Can we ensure that the situation as currently projected to appear in GA won't be confusing for users?
>>
>> - Rob
>>
>> On 05/27/2015 04:09 AM, Stieber, Uwe wrote:
>>> Hi Rob,
>>>
>>> AFAIK, the "Terminal (Old)" view will stay for TM Terminal 4.0 GA. The view helps with migration issues from TM Terminal 3.x to TM Terminal 4.0. You should not see this label in the Eclipse UI anywhere, so it should not be a problem.
>>>
>>> Best regards, Uwe :)
>>>
>>>
>>>> -----Original Message-----
>>>> From: tm-dev-bounces@xxxxxxxxxxx
>>>> [mailto:tm-dev-bounces@xxxxxxxxxxx]
>>>> On Behalf Of Rob Stryker
>>>> Sent: Dienstag, 26. Mai 2015 19:43
>>>> To: tm-dev@xxxxxxxxxxx
>>>> Subject: [tm-dev] Will "Terminal (Old)" be removed before GA?
>>>>
>>>> Hi All:
>>>>
>>>> Just curious if the current plan includes removing the terminal
>>>> with name "Terminal (Old)" or if it will stay through GA?
>>>>
>>>> Thanks in advance.
>>>>
>>>> - Rob Stryker
>>>> _______________________________________________
>>>> tm-dev mailing list
>>>> tm-dev@xxxxxxxxxxx
>>>> To change your delivery options, retrieve your password, or
>>>> unsubscribe from this list, visit
>>>> https://dev.eclipse.org/mailman/listinfo/tm-dev
>>> _______________________________________________
>>> tm-dev mailing list
>>> tm-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or
>>> unsubscribe from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/tm-dev
>> _______________________________________________
>> tm-dev mailing list
>> tm-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or
>> unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/tm-dev
>> _______________________________________________
>> tm-dev mailing list
>> tm-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or
>> unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/tm-dev
> _______________________________________________
> tm-dev mailing list
> tm-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/tm-dev
> _______________________________________________
> tm-dev mailing list
> tm-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/tm-dev
_______________________________________________
tm-dev mailing list
tm-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/tm-dev
_______________________________________________
tm-dev mailing list
tm-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/tm-dev
