Re: [riena-dev] Failing tests in 'Riena - Alltests'

[Elias Volanakis <elias@xxxxxxxxxxxxxxxxx>]

After looking at this again I realized my idea from the previous email
did not help.

The real reason is that some tests change the look-and-feel for their
own purpose and don't restore the standard settings. This was causing
DialogViewTest to fail, depending on what tests had executed before.

I've fixed using this code snippet where necessary:

RienaDefaultLnf originalLnf = LnfManager.getLnf();
try {
 // test stuff
} finally {
  LnfManager.setLnf(originalLnf);
}

Kind regards,
Elias.

On Wed, Aug 12, 2009 at 10:58 AM, Elias
Volanakis<elias@xxxxxxxxxxxxxxxxx> wrote:
> Hi Stefan,
>
> actually I propose changing RienaDialogDelegate:57 from:
>  if (Beans.isDesignTime()) {
> to:
>  if (Beans.isDesignTime() || Activator.getDefault() == null) {
>
> this will supply a default renderer when running in 'plain-old-java' mode.
>
> Regarding an annotation, can you detail a bit more?
>
> Not sure how useful it will be, because the need to run a test as
> pde-junit may change over time (even without changing the test).
> Personally, for the sake of simplicity, I would prefer to address this
> on a case by case basis for the moment.
>
> Kind regards,
> Elias.
>
> On Tue, Aug 11, 2009 at 9:53 PM, Stefan
> Liebig<Stefan.Liebig@xxxxxxxxxxxx> wrote:
>> Hi Elias,
>>
>> Elias Volanakis wrote:
>>
>> Thanks Stefan,
>>
>> the all tests below work for me.
>>
>> However DialogViewTest.testBinding() fails with NullPointerException.
>>
>>
>> It works for me if run as a Junit Plugin Test, but fails with a NPE if run
>> as non plugin test.
>>
>> Hmm, I am thinking of an attribute for the test annotations. Any thoughts
>> about that?
>>
>> Tschüß,
>> Stefan
>>
>> Kind regards,
>> Elias.
>>
>> On Mon, Aug 10, 2009 at 11:22 PM, Stefan
>> Liebig<Stefan.Liebig@xxxxxxxxxxxx> wrote:
>>
>>
>> Hi Elias,
>>
>> Thanks!
>>
>> Elias Volanakis wrote:
>>
>>
>> Hi everybody,
>>
>> currently I've errors in the following unit tests:
>>
>> - ExceptionHandlerManagerTest
>>
>>
>>
>> Fixed!
>>
>>
>> - ExtensionInjectorBuilderTest (2)
>>
>>
>>
>> Fixed!
>>
>>
>> - WireTest
>>
>>
>>
>> Works for me - could you please rerun it
>>
>>
>> - LoginModuleTest
>>
>>
>>
>> Fixed!
>>
>>
>> If you have an idea what's going on please have a look. It would be
>> great if we can go back to 'green' soon :-).
>>
>> Thanks,
>> Elias.
>>
>>
>>
>>
>> _______________________________________________
>> riena-dev mailing list
>> riena-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/riena-dev
>>
>>
>>
>>
>>
>> _______________________________________________
>> riena-dev mailing list
>> riena-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/riena-dev
>>
>>
>
>
>
> --
> Elias Volanakis | Technical Lead | EclipseSource Portland
> elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 | http://eclipsesource.com
>



-- 
Elias Volanakis | Technical Lead | EclipseSource Portland
elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 | http://eclipsesource.com