Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[riena-dev] Deprecate IActionListener.addListener(Object, String) ?

Any objections against deprecating IActionListener.addListener(Object, String) ?

Reasons:
- it falls out of our normal style which is: addListener(Listener
listener) & removeListener(Listener listener)
- there is no corresponding removeListener(Object, String) method
- it is not used anywhere in the Riena code base
- IActionListener already has the regular addListener(lsnr) and
removeListener(lsnr) methods

IActionListener.java:
        /**
	 * Add an action listener to call back. This method is equal to calling
	 * #addListener(java.beans.EventHandler.create(IActionListener.class,
	 * target, method))
	 * <p>
	 * Adding the same listener several times has no effect.
	 *
	 * @param target
	 *            the object to notify
	 * @param action
	 *            the method on {@code target} to invoke
	 * @see java.beans.EventHandler#create(Class, Object, String)
	 */
	void addListener(Object target, String action);

Kind regards,
Elias.
-- 
Elias Volanakis | Technical Lead | EclipseSource Portland
elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 | http://eclipsesource.com


Back to the top