[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [rdf4j-dev] package naming issue in MemoryBenchmark?
|
On 01/05/18 20:20, "Håvard M. Ottestad" wrote:
Hi Jeen,
I wrote that code. The package should be fixed. Copy paste mistake.
No worries, could you perhaps push a quick fix for that package name?
What I still don't understand is why neither Jenkins nor Travis
complains about this. Is this class somehow ignored when it runs the
unit tests?
I’ve found that putting the benchmarks in the test directory makes it
easier to run the benchmarks.
The problem I see is that they really _shouldn't_ be run as part of
every unit test run. Is there a switch or option we can use to turn them
on or off?
I’ve also had trouble with having
multiple repos and getting changes to become visible across modules,
e.g. I tried to fix a performance issue in the query parser and mvn
install wouldn’t propagate it to the storage repo where my benchmark
was.
To be honest I've had some issues along those lines as well. I haven't
quite gotten the multiple-repo setup working smoothly for me; there's a
lot of forced refresh/rebuild going on. I'll try and figure if that's a
a config issue on my end or if there's something we can tweak in the
poms or the snapshot repo to make this easier to handle.
This benchmark here I developed when I discovered that every insert
triggers a get from the underlying sail. This is meant to be used for
the notifying sail code. However, even when there were no attached
sails to notify, it would still do the get. This made inserts slow,
especially for serialisable.
Good find. Don't get me wrong I think having the benchmarks available is
incredibly valuable. I'm just a bit wary of mixing them in with unit tests.
Cheers,
Jeen
