[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [rdf4j-dev] package naming issue in MemoryBenchmark?
|
Hi Jeen,
I wrote that code. The package should be fixed. Copy paste mistake.
I’ve found that putting the benchmarks in the test directory makes it easier to run the benchmarks. I’ve also had trouble with having multiple repos and getting changes to become visible across modules, e.g. I tried to fix a performance issue in the query parser and mvn install wouldn’t propagate it to the storage repo where my benchmark was.
This benchmark here I developed when I discovered that every insert triggers a get from the underlying sail. This is meant to be used for the notifying sail code. However, even when there were no attached sails to notify, it would still do the get. This made inserts slow, especially for serialisable.
Håvard
> On 1 May 2018, at 02:20, Jeen Broekstra <jeen.broekstra@xxxxxxxxx> wrote:
>
> Hi,
>
> My Eclipse is signaling a build problem on this file:
>
> https://github.com/eclipse/rdf4j-storage/blob/develop/memory/src/test/java/org/eclipse/rdf4j/sail/memory/MemoryBenchmark.java
>
> As you can see its package declaration does not correspond with its directory location. Funnily enough this doesn't look to affect any of the build or test tools: Jenkins is not complaining and if I run tests from the command line all works fine.
>
> When/where is this test class used? Should this package declaration be fixed or should the file be moved? I am a bit suspicious of having a benchmark test in the unit testing dir in the first place - shouldn't this be part of the benchmarks module in the rdf4-testsuite instead?
>
> Cheers,
>
> Jeen
> _______________________________________________
> rdf4j-dev mailing list
> rdf4j-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/rdf4j-dev
