[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [platform-ui-dev] Should we avoid -2 on Gerrit ?
|
Yes, thanks for pinging me.
I've merged your change.
Thanks for the fix Victor!
Dani
From:
"Victor V. Rubezhny"
<vrubezhny@xxxxxxxxxx>
To:
platform-ui-dev@xxxxxxxxxxx,
Daniel Megert/Zurich/IBM@IBMCH
Date:
09.10.2015 18:10
Subject:
Re: [platform-ui-dev]
Should we avoid -2 on Gerrit ?
I suppose we have to ask Dani Megert to review the latest
Patch Set for that issue.
Thanks in advance,
Victor
On 10/09/2015 06:59 PM, Mickael Istria wrote:
Hi all,
I'm trying to give a hand to Platform UI by reviewing a few patches. Not
sure how helpful I can be though :D
I've noticed several patches that have a red cross (so that they seem waiting
for contributor to fix them) whereas the contributor did resubmit a new
patchset to fix the suggested thing that made the reviewer vote -2. The
issue is that the -2 is persistent and while looking at all open contributions,
it's not clear which ones are waiting for contributor fix and which ones
are waiting for review.
Example: https://git.eclipse.org/r/#/c/48952/6
The -2 was given on patch set 2; and current patch set 6 contains the change
requested; but the contribution still appears as -2 whereas it seems in
a good state to be merged.
In order to make it easier for everyone to sort out the action to do, what
would you think about not using -2 on Gerrit, and stick with the -1 which
is more "volatile" ?
Cheers,
--
Mickael Istria
Eclipse developer at JBoss,
by Red Hat
My
blog - My
Tweets
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
CONFIDENTIALITY NOTICE: This
email and files attached to it are confidential. If you are not the intended
recipient you are hereby notified that using, copying, distributing or
taking any action in reliance on the contents of this information is strictly
prohibited. If you have received this email in error please notify the
sender and delete this email.
