Re: [mdt-ocl.dev] First shot at impact analyzer doc

[Axel Uhl <eclipse@xxxxxxxxxxxxxxxxxx>]

I updated the diagrams and the sizing instructions for the img tags in 
the html. Can you please check if the images look better for you now?

Thanks,
-- Axel

On 2/21/2011 5:58 PM, Ed Willink wrote:
> He Axel
> > > I could not understnad the EMF edior integration at all. This clearly
> > > needs at least a screen shot and possibly some Object Diagrams too.
> >
> > Screen shot of an editor or screen shot of the code showing how to
> > implement the integration?
> Screen sot of the ditor might enable me to know what the added
> functiionality is so that I could then comment more usefully.
>
>
> ---
>
> The diagrams help a bit., but
>
> a) Your diagramming tool seems to lose lines in the PNG, making thew
> diagrams very hard to understand. The ImpactAnalyzer with two horizontal
> lines looks like a Jackson data store. Even the bits that are there are
> confusing.
>
> b) The <<produce>> seems to indicate a dynamic relationship that is
> completely anomalous to all the others.
>
> It is unclear to me what is adapted.
>
> The diagram confuses two meta-levels.
>
> The OCLExpression refers to meta-model elements of the model elements in
> the ResourceSEt, so is the adapter on the Expression, or is it a
> prototype for an adapter on each model element, or is the expression
> cloned per model element?
>
> In the code snippet new AdapterImpl deserves to be a top level object,
> since the Adapter is a critical part of the framework. Anonymoizing it
> is an option for practical rather than exemplary code.
>
> As you can see, I'm not getting very far.
>
> Regards
>
> Ed
>
>
> _______________________________________________
> mdt-ocl.dev mailing list
> mdt-ocl.dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mdt-ocl.dev