[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [dsdp-tm-dev] Package org.eclipse.rse.core.subsystems.util

+1 on renaming and moving org.eclipse.rse.core.subsystems.util
+1 on moving org.eclipse.rse.ui.subsystems
+1 on moving types from org.eclipse.rse.core.servicesubsystem to org.eclipse.rse.core.subsystems


Moving SubSystem and ServiceSubSystem to the core plugin will be tough and my guess is that they will need some additional refactoring. This may be one bit we'll have to leave until after M6.

I'll get to SubSystemHelpers and SubSystemConfigurationProxy yet today.

On Apr 2, 2007, at 9:50 AM, Oberhuber, Martin wrote:

Hi Dave's,

I've been checking rse.doc.isv for broken links
in order to see if we have any API violations.
So far, it looks pretty good. But what I've seen
along the way is this:

org.eclipse.rse.ui/subsystems/org.eclipse.rse.core.subsystems.util

I believe this package is the UI adaptor (glue)
for subsystems. So the package name should better be

org.eclipse.rse.ui/UI/org.eclipse.rse.ui.subsystems

Agree? If yes, I'd create a bug and we should refactor it
for M6. BTW, Package org.eclipse.rse.ui.subsystems already
exists below the subsystems/ source path, I think this
should go below the UI/ source path.

There are others which we should put out of UI and into Core.
I believe you're pretty close to doing so, correct DaveD?
  SubSystemHelpers  - should work already
  SubSystemConfigurationProxy - only problem is the ImageDescriptor,
     should be possible to do this via Property similar to what
     we already did for the systemType when making it Core

The others (SubSystem, ServiceSubSystem) seem to be
still pretty hard to do. But it is probably time to
move the classes from
  org.eclipse.rse.ui/subsystems/org.eclipse.rse.core.servicesubsystem
into
  org.eclipse.rse.ui/subsystems/org.eclipse.rse.core.subsystems
since the corresponding interfaces are already in
that package.

Cheers,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
_______________________________________________
dsdp-tm-dev mailing list
dsdp-tm-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev