RE: [cdt-dev] "assert" in cdt source vs. java compilerversionsinprojects

["Schorn, Markus" <Markus.Schorn@xxxxxxxxxxxxx>]

The entry in the manifest-file should not be removed. Its purpose is to
inform the runtime about the minimal requirements needed to run the
plugin, which is J2SE-1.4. It is not intended to give a hint on how to
build the plugin.

As a potential solution we could add the build-relevant files to the
jar's of the SDK (for jdt-builds '.settings/org.eclipse.jdt.core.prefs'
is relevant, for pde-builds one needs 'build.properties'). 

Markus.

-----Original Message-----
From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
On Behalf Of Don Porges
Sent: Wednesday, December 12, 2007 4:47 PM
To: cdt-dev@xxxxxxxxxxx
Subject: RE: [cdt-dev] "assert" in cdt source vs. java
compilerversionsinprojects
Importance: Low


Looks like that's correct.  The three plugins in question, plus one
other (org.eclipse.cdt.debug.ui), are the ones that have this in their
MANIFEST.MF:

Bundle-RequiredExecutionEnvironment: J2SE-1.4

That must be what causes the difference.  (As it happens,
org.eclipse.cdt.debug.ui doesn't use the assert keyword, which is why it
didn't give me any trouble.)

So, as the only person in the world who cares, I wouldn't mind if that
line was removed from those 4 MANIFEST.MF files...unless those of you
who know better think that it should be in ALL of them.  But I bet they
should all be the same, one way or the other.


Schorn, Markus wrote:
> 
> PDE might use the information about the execution-environment stored 
> in the MANIFEST.MF file, but I don't really know that.
> Markus.
> 
> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Don Porges
> Sent: Tuesday, December 11, 2007 8:53 PM
> To: cdt-dev@xxxxxxxxxxx
> Subject: RE: [cdt-dev] "assert" in cdt source vs. java compiler 
> versionsinprojects
> Importance: Low
> 
> 
> I've verified that if I check one of these projects out from the 
> repository, I get the
> 1.4/1.4 settings you mention.  Presumably this is because the 
> repository version has .settings/org.eclipse.jdt.core.prefs; I see no 
> such file in the cdt-master-xxxxx.zip files, so that partially 
> explains that.  But when I get the sources from there, where is it 
> getting the Java Compiler settings such that they are different in the
different projects?
> 
> 
> Don Porges wrote:
>> 
>> I don't get the projects from cvs.  What I've been doing is:
>> 
>> Install the CDT SDK feature from the master .zip file (such as
>> cdt-master-4.0.2.zip)
>> Import-->Plugin Development-->Plugins and Fragments
>> Make sure that Import as "Projects with source folders" is selected 
>> Select all CDT plugins (minus src/doc/test) Import them.
>> 
>> The workbench does its building and then I get the errors I
described.
> 
>> The
>> Preferences-->Java Compiler panel indicates compiler compliance level

>> Preferences-->1.4,
>> with "Use default compliance settings" checked, and therefore the 
>> source compatibility settings are greyed out, but it indicates source

>> compatibility 1.3.
>> 
>> 
>> Schorn, Markus wrote:
>>> 
>>> Hi,
>>> The plugins can certainly be compiled for java 1.4. However the 
>>> sources are not 1.3 compatible.
>>> 
>>> When obtaining the projects for the plugins from the CVS repository,

>>> these settings are defined correctly. (compiler-compliance=1.4,
>>> source-compatibility=1.4)
>>> 
>>> How do you create the projects before you build them? Do you use the

>>> builder provided by JDT or the ant-build provided by PDE?
>>> 
>>> Markus.
>>> 
>>> -----Original Message-----
>>> From: cdt-dev-bounces@xxxxxxxxxxx
>>> [mailto:cdt-dev-bounces@xxxxxxxxxxx]
>>> On Behalf Of Don Porges
>>> Sent: Monday, December 10, 2007 6:13 PM
>>> To: cdt-dev@xxxxxxxxxxx
>>> Subject: [cdt-dev] "assert" in cdt source vs. java compiler versions

>>> inprojects
>>> Importance: Low
>>> 
>>> 
>>> Every time I try to build the CDT from source, as I did again this 
>>> week from the 4.0.2 update, I run into the same thing that has to be
> tweaked:
>>> 3 of the plugins use the Java "assert" statement but have the java 
>>> compiler version explicitly set to 1.4 in the project properties, 
>>> which implies source compatibility with 1.3, which does not know 
>>> about that keyword.  The
>>> 3 plugins are:
>>> 
>>> org.eclipse.cdt.core
>>> org.eclipse.cdt.refactoring
>>> org.eclipse.cdt.ui
>>> 
>>> In order to build these in the workbench, I have to change the Java 
>>> compiler version in each project to 5.0.  And then, if I want to 
>>> export them from the workbench, I have to change the version again, 
>>> this time in build.properties.  It's certainly possible that my 
>>> workflow is different from the way that the real developers do it, 
>>> but I don't understand how anybody ever builds these plugins without

>>> changing the project settings.  My installed java is Sun's 1.6.0, on

>>> Windows XP, if that makes a difference.
>>> 
>>> --
>>> View this message in context:
>>> http://www.nabble.com/%22assert%22-in-cdt-source-vs.-java-compiler-v
>>> e rsi ons-in-projects-tp14182576p14182576.html
>>> Sent from the Eclipse CDT - Development mailing list archive at 
>>> Nabble.com.
>>> 
>>> _______________________________________________
>>> cdt-dev mailing list
>>> cdt-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>> _______________________________________________
>>> cdt-dev mailing list
>>> cdt-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>> 
>>> 
>> 
>> 
> 
> --
> View this message in context:
> http://www.nabble.com/%22assert%22-in-cdt-source-vs.-java-compiler-ver
> si ons-in-projects-tp14182576p14281958.html
> Sent from the Eclipse CDT - Development mailing list archive at 
> Nabble.com.
> 
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
> 
> 

--
View this message in context:
http://www.nabble.com/%22assert%22-in-cdt-source-vs.-java-compiler-versi
ons-in-projects-tp14182576p14297833.html
Sent from the Eclipse CDT - Development mailing list archive at
Nabble.com.

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev