Bug 89782 - Manifest builder is overzealous
Summary: Manifest builder is overzealous
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Wassim Melhem CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
: 125137 137565 160862 176741 179420 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-03-31 01:41 EST by Wassim Melhem CLA
Modified: 2007-05-10 00:27 EDT (History)
10 users (show)

See Also:

Attachments
Patch (21.17 KB, patch)
2007-05-08 01:06 EDT, Wassim Melhem CLA 		baumanbr: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2005-03-31 01:41:08 EST 
The manifest builder is overzealous when it comes to revalidating a plugin.xml 
file.  It sometimes runs unnecessarily when the resource being changed has no 
effect on its content.
Comment 1 Wassim Melhem CLA 2006-04-19 14:55:42 EDT 
*** Bug 137565 has been marked as a duplicate of this bug. ***
Comment 2 Wassim Melhem CLA 2007-03-12 13:50:08 EDT 
*** Bug 176741 has been marked as a duplicate of this bug. ***
Comment 3 Wassim Melhem CLA 2007-03-26 22:38:28 EDT 
*** Bug 179420 has been marked as a duplicate of this bug. ***
Comment 4 Nick Edgar CLA 2007-04-03 15:47:56 EDT 
See also bug 172944 for an interesting side-effect: this was causing the PE to refresh the whole project.
Comment 5 Philipe Mulet CLA 2007-04-23 07:57:24 EDT 
Are we addressing this one for 3.3 ?
Comment 6 Dani Megert CLA 2007-04-26 03:02:07 EDT 
Ping.
Comment 7 Wassim Melhem CLA 2007-04-26 10:24:46 EDT 
Some things take time.  Working on it.
Comment 8 Wassim Melhem CLA 2007-05-01 15:54:58 EDT 
Coming along nicely, but will have to wait until RC1 to allow more in-house testing
Comment 9 Wassim Melhem CLA 2007-05-06 00:56:25 EDT 
*** Bug 160862 has been marked as a duplicate of this bug. ***
Comment 10 Wassim Melhem CLA 2007-05-08 01:06:20 EDT 
Created attachment 66240 [details]
Patch

Brian, could you give the patch a test drive please?

Run with with tracing on.
All you need is the debug and validation flags to be checked in the org.eclipse.pde.core plug-in on the Tracing tab of the launcher.

I will walk you through the list of things to look for tomorrow.
Comment 11 Wassim Melhem CLA 2007-05-08 01:10:57 EDT 
Brian, the patch also fixes bug 89321 and all its duplicates.  Easiest scenario to reproduce and verify is bug 178151
Comment 12 Brian Bauman CLA 2007-05-08 13:04:41 EDT 
Comment on attachment 66240 [details]
Patch

patch looks great.  Very creative way to solve some obstacles.  It's gets the coveted Bauman Seal of Approval.
Comment 13 Wassim Melhem CLA 2007-05-08 14:15:30 EDT 
Thanks Brian.
Comment 14 Wassim Melhem CLA 2007-05-10 00:27:09 EDT 
*** Bug 125137 has been marked as a duplicate of this bug. ***