Bug 87752 - [History View] CVS Resource History view: allow to copy tag
Summary: [History View] CVS Resource History view: allow to copy tag
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M4   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, helpwanted
: 73974 (view as bug list)
Depends on:
Blocks: 210646
  Show dependency tree
 
Reported: 2005-03-11 06:26 EST by Dani Megert CLA
Modified: 2008-05-16 13:52 EDT (History)
5 users (show)

See Also:

Attachments
Patch (4.81 KB, patch)
2007-11-19 08:55 EST, Jakub Jurkiewicz CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2005-03-11 06:26:54 EST 
I20050308-1510

I'd like to be able to copy tags from the CVS Resource History view (lower left
pane). Copy is already possible for the comment (lower right pane).
Comment 1 Michael Valenta CLA 2005-03-11 10:07:07 EST 
I thought we had a request for this alreaedy but I couln't find it. I won't 
have time to do this for 3.1.
Comment 2 Markus Keller CLA 2006-07-17 05:55:11 EDT 
*** Bug 73974 has been marked as a duplicate of this bug. ***
Comment 3 Eugene Kuleshov CLA 2006-07-17 10:25:53 EDT 
Michael, it was issue 39433 I opened while and and you've marked it as resolved for later.
Comment 4 Jakub Jurkiewicz CLA 2007-11-19 08:55:45 EST 
Created attachment 83231 [details]
Patch

I prepared a patch, but I'm not sure if this is the best way to do this, so I will appreciate any comments.
Comment 5 Tomasz Zarna CLA 2007-11-20 10:50:10 EST 
Thanks for the patch Jakub, I will take a look at it by the end of this week.
Comment 6 Tomasz Zarna CLA 2007-11-21 07:17:04 EST 
The patch looks good, but I have a few comments:

1) It would be nice if you could add a key binding for the copy tag action.
2) I think we could enable multiple selection in the tag table viewer. This should be handled in the copy tag action too.
3) If we decide to enable multi-selection, we could also consider adding "Select all" and "Deselect all" actions to the context menu.

How does that sound?

In the meantime I will release your patch, so if you like you could log a new bug to address the above bullets or attach a new patch to this one. Either way is ok with me.
Comment 7 Jakub Jurkiewicz CLA 2007-11-21 07:25:55 EST 
(In reply to comment #6)
> The patch looks good, but I have a few comments:
> 
> 1) It would be nice if you could add a key binding for the copy tag action.
> 2) I think we could enable multiple selection in the tag table viewer. This
> should be handled in the copy tag action too.
> 3) If we decide to enable multi-selection, we could also consider adding
> "Select all" and "Deselect all" actions to the context menu.
> 
> How does that sound?


It sounds good, in fact I was thinking about your last two suggestions but just wanted to be sure if what I had done was good.

> In the meantime I will release your patch, so if you like you could log a new
> bug to address the above bullets or attach a new patch to this one. Either way
> is ok with me.

I will open new bugs on Thursday and try to prepare patches for them.
Comment 8 Tomasz Zarna CLA 2007-11-22 07:52:56 EST 
Released to HEAD. Now you have the green light to fix bug 210646 :)
Comment 9 Tomasz Zarna CLA 2008-02-06 10:19:55 EST 
Verified in I20080205-0010, but logged bug 210646 and bug 218008.