Community
Participate
Working Groups
This bug was distinguished from the bug #87752. The action for copying tags in the CVS Resource History view should: 1) have a key binding defined, 2) allow multiple selection in the tag table viewer, 3) have "Select all" and "Deselect all" actions in the context menu.
As I said in the bug 87752, I would be happy to see these done. It's the little things that make us smile while working with Eclipse, isn't it?
Created attachment 83858 [details] Patch I'm attaching a patch, but there are two problems: 1) What should be copied to the clipboard when more then two tags are selected? e.g. we have tags: "Tag 1 Tag 2" I thought about "Tag1\nTag2" but this doesn't seem to work (there is a problem with \n). However, maybe this should be handled in some other way? 2) How should the key bindings be defined? I guess that the actions should be registered, but didn't find any good solution? Tomasz could you give me some hint?
Created attachment 83967 [details] Patch Patch with some adjustments to your TableViewerAction -- this is my answer to 1) from the previous comment
As for your second question, I'm afraid what I can give you will be only a hint. I hope it will help. So, this is what I would do: * set Action definition for the Copy Tag action - ie. copyTagAction.setActionDefinitionId(IWorkbenchActionDefinitionIds.COPY); * register the action - actionBars.setGlobalActionHandler(ActionFactory.COPY.getId(), copyTagAction); But I may be missing something. You can take a look at this page (and its "See Also"s): http://wiki.eclipse.org/FAQ_How_do_I_make_key_bindings_work_in_an_RCP_application%3F The other thing I would like to mentioned is the "Deselect All" button. On second thought it's not a good (neither common) idea to place such an action in the context menu. I think "Select All" will be enough, but still, this seems to be a standard workbench action so we could use a keybinding here too.
Created attachment 84051 [details] Patch Thanks for the patch for TableViewerAction, now it looks much better. I used your hints according key bindings, but there is a problem I encountered earlier: there are already registered actions (copying and selecting all) for the comment window (textViewer), so which actions should be active: those for tags or those for comment? Any suggestions?
The patch still needs some improvements in order to release it to HEAD (and mark as FIXED). We will try to work it out during M5.
Can we move it to M6? I should have time o finish this up.
I'm removing the target milestone. When the patch is ready we can set it again appropriately. Jakub, it wouldn't look good, if the bug was postponed again. I'm looking forward to the fix. Thanks.
Comment on attachment 83967 [details] Patch Marking the second patch as obsolete - I've logged a separate bug for it (see bug 218008).
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
